-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SVLS-4299] Extract trace context from AWSTraceHeader in SQS java upstream case #511
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #511 +/- ##
==========================================
- Coverage 82.10% 82.08% -0.02%
==========================================
Files 54 54
Lines 2191 2211 +20
Branches 511 513 +2
==========================================
+ Hits 1799 1815 +16
- Misses 329 332 +3
- Partials 63 64 +1 ☔ View full report in Codecov by Sentry. |
Hmmm, the codecov report seems to highlight some important gaps where we return undefined or null, can we cover those? https://app.codecov.io/gh/DataDog/datadog-lambda-js/pull/511?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog |
9ab5092
to
2568721
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments and nits, but overall, looks good! Great work on fixing the code coverage!
Co-authored-by: jordan gonzález <30836115+duncanista@users.noreply.github.com>
Co-authored-by: jordan gonzález <30836115+duncanista@users.noreply.github.com>
Co-authored-by: jordan gonzález <30836115+duncanista@users.noreply.github.com>
What does this PR do?
In the case where
Java lambda ==> SQS ==> NodeJS lambda
the tracecontext is injected into the
Records[i].attributes.AWSTraceHeader
.This PR refactors around XRayService and SQSEventTraceExtractor to extract that context out.
Result:
Motivation
Testing Guidelines
Additional Notes
Types of Changes
Check all that apply