Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SVLS-4298] Java upstream sqs trace context propagation #454

Merged
merged 4 commits into from
Mar 27, 2024

Conversation

joeyzhao2018
Copy link
Contributor

@joeyzhao2018 joeyzhao2018 commented Mar 27, 2024

What does this PR do?

This is python's version of the same logic done in the NodeJS layer PR DataDog/datadog-lambda-js#511

Motivation

JAVA lambda would put trace context information in the AWSTracerHeader inside the message.attributes
This PR extract that so that JAVA Lambda => sqs => python lambda would show as one connected trace.

Additional Notes

I refrained from refactoring too much of the code logic in this PR. But I plan to do some refactoring in a following PR. This is because the refactoring would focus more on the general structure of the extractors. Therefore not very relevant to the java upstream case here.

Testing Guidelines

Added unittest case using a java upstream example payload.
Manually tested in a real lambda setup:
Screenshot 2024-03-27 at 2 02 08 PM

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@joeyzhao2018 joeyzhao2018 requested a review from a team as a code owner March 27, 2024 17:52
Copy link
Contributor

@duncanista duncanista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM – left a non-blocking nit.

Looking forward for the refactor 🙏🏽 lmk if you need help there!

@joeyzhao2018 joeyzhao2018 merged commit 33b7bfc into main Mar 27, 2024
51 checks passed
@joeyzhao2018 joeyzhao2018 deleted the joey/upstream_java branch March 27, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants