Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added histogram min and adjusted unit tests. #1224

Closed
wants to merge 2 commits into from

Conversation

kkumler
Copy link

@kkumler kkumler commented Nov 25, 2014

Implementing #1219 (thanks for adding the issue -- I saw it there and figuring I'd write something, after having asked support earlier).

tests/test_bucket_aggregator.py tests/test_dogstatsd.py tested clean. I could not execute the entire test suite locally yet.

@remh remh added this to the 5.2.0 milestone Dec 3, 2014
@LeoCavaille
Copy link
Member

Looking good @kkumler thank you so much for taking the time to implement this! 👍
It looks like this modification breaks other test cases that are depending on histograms, for instance tests.test_go_expvar.TestGoExpVar (see the Travis build with flavor default), would you mind fixing those test cases? Some of the Travis builds might be failing because of flaky tests or deps, but we are working on improving that.

@kkumler
Copy link
Author

kkumler commented Dec 10, 2014

@LeoCavaille I fixed the one I missed there.

@LeoCavaille LeoCavaille self-assigned this Dec 30, 2014
@LeoCavaille
Copy link
Member

Thanks @kkumler again, see #1303 for the final merge with your code and how to use the new behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants