Make histogram aggregates & percentiles configurable globally #1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeoCavaille
force-pushed
the
leo/histogram_min
branch
3 times, most recently
from
299bbeb to
24bcaf0
Compare
| @@ -605,6 +617,10 @@ def __init__(self, hostname, interval=1.0, expiry_seconds=300, formatter=None, r | |||
| 'ms': Histogram, | |||
| 's': Set, | |||
| } | |||
| self.histogram_aggregates = histogram_aggregates\ | |||
There was a problem hiding this comment.
That should probably be in the Aggregator class so you don't have to duplicate it in all its subclasses.
There was a problem hiding this comment.
That was my first approach, before realizing that no metric specific (say Histograms for instance) code was in this class, I can put that here but I find it lacking consistency a bit. Maybe I should just refactor more things 😒
LeoCavaille
force-pushed
the
leo/histogram_min
branch
4 times, most recently
from
e84a996 to
1cd1c08
Compare
|
@remh this is should be ready for final review hopefully (allowing per metric type config to be passed, with no special case for histograms) |
| @@ -42,7 +43,7 @@ def testBadPidFile(self): | |||
|
|
|||
| p = PidFile('test', pid_dir) | |||
| path = p.get_path() | |||
| self.assertEquals(path, "/tmp/test.pid") | |||
| self.assertEquals(path, os.path.join(os.environ.get('TMPDIR', '/tmp'), 'test.pid')) | |||
There was a problem hiding this comment.
even better:
self.assertEquals(path, os.path.join(tempfile.gettempdir(), 'test.pid')
LeoCavaille
force-pushed
the
leo/histogram_min
branch
from
1cd1c08 to
9b8d250
Compare
LeoCavaille
added a commit
that referenced
this pull request
Jan 28, 2015
Make histogram aggregates & percentiles configurable globally
|
Changes Unknown when pulling 9b8d250 on leo/histogram_min into * on master*. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.