Add pg_database_size and custom metrics to postgres integration #1302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
January 5, 2015 11:46
Get upstream commits from DataDog
Merge from upstream
Merge upstream changes
Merge upstream changes
Merge upstream changes
ipolishchuk
changed the title
|
Thanks a lot @ipolishchuk ! We've frozen the changelog of our 5.2.0 release so we'll review this PR once 5.2.0 is out and we'll aim at releasing your work for the 5.3.0 release. Thanks again! |
|
I see a message 'Travis CI build failed', I suspect this might be because I've added a new metric postgresql.database_size, which i snot present in the test suite. |
LeoCavaille
pushed a commit
to DataDog/puppet-datadog-agent
that referenced
this pull request
Feb 23, 2015
This can be merged with its upstream buddy DataDog/dd-agent#1302
remh
pushed a commit
that referenced
this pull request
Feb 25, 2015
- Fix tests (and add one more) - Add a limit to the number of results custom queries can return - small copy changes to improve readability
|
Thanks a lot @ipolishchuk i made a few changes and opened a new pul request that will be merged very soon ( #1395 ) so i'm closing this one. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom metrics may be defined in postgres.yaml in the same format as metrics are defined in postgres.py
As an example, Londiste 3 replication lag metric is added to postgres.yaml.example.