Add pg_database_size and custom metrics to postgres integration #1395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Get upstream commits from DataDog
Merge from upstream
Merge upstream changes
Merge upstream changes
Merge upstream changes
- Fix tests (and add one more) - Add a limit to the number of results custom queries can return - small copy changes to improve readability
remh
pushed a commit
that referenced
this pull request
Feb 25, 2015
Add pg_database_size and custom metrics to postgres integration
LeoCavaille
added a commit
that referenced
this pull request
Mar 20, 2015
Fix regression introduced by #1395. The idea is that because the pre-processing function `_process_customer_metrics` was modifying "in-place" instance attributes, and for instance converting the string "GAUGE" to the method "AgentCheck.gauge" at the first pass, the second time it would expect to find a string and fail when it encounters a method. Instead we cache the pre-preprocessed dict the first time, and hit this dictionnary in the next runs if it is present.
LeoCavaille
added a commit
that referenced
this pull request
Mar 20, 2015
Fix regression introduced by #1395. The idea is that because the pre-processing function `_process_customer_metrics` was modifying "in-place" instance attributes, and for instance converting the string "GAUGE" to the method "AgentCheck.gauge" at the first pass, the second time it would expect to find a string and fail when it encounters a method. Instead we cache the pre-preprocessed dict the first time, and hit this dictionnary in the next runs if it is present.
LeoCavaille
added a commit
that referenced
this pull request
Apr 7, 2015
Fix regression introduced by #1395. The idea is that because the pre-processing function `_process_customer_metrics` was modifying "in-place" instance attributes, and for instance converting the string "GAUGE" to the method "AgentCheck.gauge" at the first pass, the second time it would expect to find a string and fail when it encounters a method. Instead we cache the pre-preprocessed dict the first time, and hit this dictionnary in the next runs if it is present.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #1302 with a few minor changes
Thanks a lot to @ipolishchuk !