Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REPLAY-1765 Add records count session replay stats #1347

Merged
merged 8 commits into from
Jul 6, 2023

Conversation

maciejburda
Copy link
Member

@maciejburda maciejburda commented Jun 29, 2023

What and why?

Adds SR records count to RUM view events.

How?

Using message bus and passing the info from SR to RUM.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests
  • Run integration tests
  • Run smoke tests

@maciejburda maciejburda force-pushed the maciey/REPLAY-1765-replay-stats branch from dbe87ca to f4ff4b5 Compare June 30, 2023 08:51
@maciejburda maciejburda marked this pull request as ready for review June 30, 2023 09:31
@maciejburda maciejburda requested a review from a team as a code owner June 30, 2023 09:31
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jun 30, 2023

Datadog Report

Branch report: maciey/REPLAY-1765-replay-stats
Commit report: acd3713

dd-sdk-ios: 0 Failed, 0 New Flaky, 2168 Passed, 0 Skipped, 6m 13.51s Wall Time

Copy link
Member

@ncreated ncreated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a test in demo app, most views and actions do not have has_replay: true anymore (haven't tested other events).

Screenshot 2023-07-04 at 11 26 17 Screenshot 2023-07-04 at 11 26 43

@maciejburda maciejburda force-pushed the maciey/REPLAY-1765-replay-stats branch from 0efb864 to f9c9c94 Compare July 4, 2023 15:58
@maciejburda maciejburda force-pushed the maciey/REPLAY-1765-replay-stats branch from f9c9c94 to 7dfacd4 Compare July 5, 2023 09:27
@maciejburda
Copy link
Member Author

@ncreated @maxep

I added updated the PR with update function.

We discussed with @maxep and we'll have a pairing session later this month to:

  • allow nullifying values
  • remove set and rely only on update

@maciejburda maciejburda force-pushed the maciey/REPLAY-1765-replay-stats branch from 7dfacd4 to eee95d9 Compare July 5, 2023 09:31
Copy link
Member

@ncreated ncreated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Awesome. Please make sure it is tested manually before merge as we don't yet have RUM + SR integration tests.

@maciejburda maciejburda merged commit 628279b into develop Jul 6, 2023
@maciejburda maciejburda deleted the maciey/REPLAY-1765-replay-stats branch July 6, 2023 12:27
maxep added a commit that referenced this pull request Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants