Merge feature/v2 to develop
#1366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RUMM-2617 Create Trace Module
Update `feature/v2` with `develop`
Co-Authored-By: Maciek Grzybowski <maciek.grzybowski@datadoghq.com>
RUMM-2616 Create RUM Feature
…entation RUMM-2616 RUM Resource Instrumentation v2
…o-provider RUMM-2616 Remove User Info Provider
Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>
Pre-release `2.0.0-beta1`
RUMM-3404 Create MIGRATION.md
Fix v2 assets validation
Datadog ReportBranch report: ✅ |
|
maciejburda
approved these changes
Jul 10, 2023
ganeshnj
approved these changes
Jul 10, 2023
buraizu
approved these changes
Jul 10, 2023
ncreated
requested changes
Jul 11, 2023
There was a problem hiding this comment.
🏋️♀️ Looks good, except that we also need to fix E2E tests build by updating the API to 2.0.0 (it uses V1 on feature/v2):
Otherwise, all monitors we define in MI org will fail in next nightly build. The E2E tests are safe to try in local, as they send data to different env:
https://github.com/DataDog/dd-sdk-ios/blob/develop/Datadog/E2E/E2EConfig.swift#L48-L53
|
@ncreated! Indeed, I was planning on doing it after the merge but better to do it now 👍 I have also updated the api-surface. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Merge
feature/v2todevelopHow?
The following conflicts were resolved during the merge. Authors of the following PRs are invited to review their respective changes.
Additionally, the E2E Tests have been migrated, see 16f13ad
Review checklist
Custom CI job configuration (optional)