Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RUMM-3151 feat: remove RUMViewUpdatesThrottlerType and send all events to batch writer #1354

Merged
merged 1 commit into from
Jul 3, 2023
Merged

RUMM-3151 feat: remove RUMViewUpdatesThrottlerType and send all events to batch writer #1354

merged 1 commit into from
Jul 3, 2023

Conversation

ganeshnj
Copy link
Contributor

@ganeshnj ganeshnj commented Jun 30, 2023 •
edited
Loading

What and why?

Given, payload based filtering has been merged, we are unblocked to remove the filtering logic that works during the batch writing.

How?

Remove RUMViewUpdatesThrottler

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests
  • Run integration tests
  • Run smoke tests

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jun 30, 2023 •
edited
Loading

Datadog Report

Branch report: ganeshnj/feat/RUMM-3151-remove-throttler
Commit report: f005eca

✅ dd-sdk-ios: 0 Failed, 0 New Flaky, 2204 Passed, 0 Skipped, 26m 23.04s Wall Time

@ganeshnj ganeshnj changed the title [WIP] RUMM-3151 feat: remove RUMViewUpdatesThrottlerType and send all events to batch writer RUMM-3151 feat: remove RUMViewUpdatesThrottlerType and send all events to batch writer Jun 30, 2023
@ganeshnj ganeshnj marked this pull request as ready for review June 30, 2023 16:22
@ganeshnj ganeshnj requested a review from a team as a code owner June 30, 2023 16:22
maxep
maxep approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@maxep maxep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🧹

@ganeshnj ganeshnj merged commit d3d7722 into develop Jul 3, 2023
@ganeshnj ganeshnj deleted the ganeshnj/feat/RUMM-3151-remove-throttler branch July 3, 2023 14:32
maxep added a commit that referenced this pull request Jul 10, 2023
@maxep
Fix conflicts with #1354
08540ad
@maxep maxep mentioned this pull request Jul 10, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxep maxep maxep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ganeshnj @maxep