RUMM-830 Add consent provider #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buranmert
approved these changes
Dec 3, 2020
Comment on lines
+63
to
+65
| objc_sync_enter(self) | ||
| block() | ||
| objc_sync_exit(self) |
There was a problem hiding this comment.
this is totally fine 👍 i'm just wondering why we didn't use self.queue?
There was a problem hiding this comment.
It's because in this PR the FileWriter is still async. It dispatches writes asynchronously to this queue. Making self.queue.async {} in this PR would lead to doubling the async call to queue (queue.async { queue.async { /* write */ } }).
But I'm aware of this and this was changed in #330 where queue is used instead of objc_sync. In #330 the FileWriter is changed to be synchronous, which provides simpler threading model.
Base automatically changed from
ncreated/RUMM-829-add-consent-aware-data-writer
to
tracking-consent
December 7, 2020 07:30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
📦 As the next part of tracking consent feature, this PR introduces the
ConsentProvider.How?
ConsentProviderimplements basic subscription model. TheConsentAwareDataWriterreads the consent value and subscribes to its updates.Review checklist