-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RUMM-830 Add consent provider #328
Merged
ncreated
merged 2 commits into
tracking-consent
from
ncreated/RUMM-830-add-consent-provider
Dec 7, 2020
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51 changes: 51 additions & 0 deletions
51
Sources/Datadog/Core/Persistence/Privacy/ConsentProvider.swift
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| /* | ||
| * Unless explicitly stated otherwise all files in this repository are licensed under the Apache License Version 2.0. | ||
| * This product includes software developed at Datadog (https://www.datadoghq.com/). | ||
| * Copyright 2019-2020 Datadog, Inc. | ||
| */ | ||
|
|
||
| import Foundation | ||
|
|
||
| internal protocol ConsentSubscriber: class { | ||
| func consentChanged(from oldValue: TrackingConsent, to newValue: TrackingConsent) | ||
| } | ||
|
|
||
| /// Provides the current `TrackingConsent` value and notifies all subscribers on its change. | ||
| internal class ConsentProvider { | ||
| private let queue = DispatchQueue( | ||
| label: "com.datadoghq.tracking-consent", | ||
| target: .global(qos: .userInteractive) | ||
| ) | ||
| private var subscribers: [ConsentSubscriber] = [] | ||
|
|
||
| init(initialConsent: TrackingConsent) { | ||
| self.unsafeCurrentValue = initialConsent | ||
| } | ||
|
|
||
| // MARK: - Consent Value | ||
|
|
||
| /// Unsychronized consent value. Use `self.currentValue` setter & getter. | ||
| private var unsafeCurrentValue: TrackingConsent | ||
|
|
||
| /// The current value of`TrackingConsent`. | ||
| private(set) var currentValue: TrackingConsent { | ||
| get { queue.sync { unsafeCurrentValue } } | ||
| set { queue.async { self.unsafeCurrentValue = newValue } } | ||
| } | ||
|
|
||
| /// Sets the new value of `TrackingConsent` and notifies all subscribers. | ||
| func changeConsent(to newValue: TrackingConsent) { | ||
| let oldValue = currentValue | ||
| currentValue = newValue | ||
|
|
||
| subscribers.forEach { subscriber in | ||
| subscriber.consentChanged(from: oldValue, to: newValue) | ||
| } | ||
| } | ||
|
|
||
| // MARK: - Managing Subscribers | ||
|
|
||
| func subscribe(consentSubscriber: ConsentSubscriber) { | ||
| subscribers.append(consentSubscriber) | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is totally fine 👍 i'm just wondering why we didn't use
self.queue?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's because in this PR the
FileWriteris still async. It dispatches writes asynchronously to thisqueue. Makingself.queue.async {}in this PR would lead to doubling the async call toqueue(queue.async { queue.async { /* write */ } }).But I'm aware of this and this was changed in #330 where
queueis used instead ofobjc_sync. In #330 theFileWriteris changed to be synchronous, which provides simpler threading model.