Small updates to telemetry in preparation for V2 #4180

andrewlock · 2023-05-24T15:23:15Z

Summary of changes

Tweaks to metric telemetry DTOs to match v2 schema
Stop storing Telemetry properties in settings objects (not necessary)
Fix log in AgentlessTelemetryTransport
Add support for disabling sending dependency data
Added some extensions to ConfigurationOrigin (used later)

Reason for change

These are all bits and pieces I need as part of the v2 telemetry work. Extracted to a separate PR to make it easier to review both.

Implementation details

Mostly small changes. For disabling dependency data, created an IDependencyTelemetryCollector and a null implementation

Test coverage

Mostly covered by existing tests, added some more integration test

datadog-ddstaging · 2023-05-24T15:46:44Z

Datadog Report

Branch report: andrew/telemetry/odds-and-ends
Commit report: 4c723fb

✅ dd-trace-dotnet: 0 Failed, 0 New Flaky, 276007 Passed, 913 Skipped, 29m 22.97s Wall Time

…equired)

…hem during aggregation)

tracer/src/Datadog.Trace/Configuration/ConfigurationKeys.cs

pierotibou · 2023-05-30T07:04:17Z

tracer/test/Datadog.Trace.ClrProfiler.IntegrationTests/TelemetryTests.cs

        {
            EnvironmentHelper.EnableUnixDomainSockets();
+            EnableDependencies(enableDependencies);
            using var agent = EnvironmentHelper.GetMockAgent(useTelemetry: true);

            int httpPort = TcpPortProvider.GetOpenPort();


Don't you want to assert dependencies in that test?

Yep, good catch

Add integration tests

andrewlock · 2023-05-30T09:28:01Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4180) - mean (3,031ms)  : 2937, 3125
     .   : milestone, 3031,
    master - mean (3,018ms)  : 2929, 3106
     .   : milestone, 3018,

    section CallTarget+Inlining+NGEN
    This PR (4180) - mean (3,773ms)  : 3683, 3864
     .   : milestone, 3773,
    master - mean (3,763ms)  : 3677, 3850
     .   : milestone, 3763,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4180) - mean (3,160ms)  : 3070, 3250
     .   : milestone, 3160,
    master - mean (3,158ms)  : 3066, 3249
     .   : milestone, 3158,

    section CallTarget+Inlining+NGEN
    This PR (4180) - mean (3,610ms)  : 3534, 3686
     .   : milestone, 3610,
    master - mean (3,574ms)  : 3500, 3648
     .   : milestone, 3574,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4180) - mean (3,137ms)  : 3022, 3251
     .   : milestone, 3137,
    master - mean (3,121ms)  : 2996, 3247
     .   : milestone, 3121,

    section CallTarget+Inlining+NGEN
    This PR (4180) - mean (3,579ms)  : 3513, 3646
     .   : milestone, 3579,
    master - mean (3,563ms)  : 3508, 3618
     .   : milestone, 3563,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4180) - mean (188ms)  : 184, 191
     .   : milestone, 188,
    master - mean (188ms)  : 183, 193
     .   : milestone, 188,

    section CallTarget+Inlining+NGEN
    This PR (4180) - mean (1,033ms)  : 1001, 1066
     .   : milestone, 1033,
    master - mean (1,034ms)  : 1003, 1065
     .   : milestone, 1034,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4180) - mean (367ms)  : 361, 372
     .   : milestone, 367,
    master - mean (370ms)  : 362, 377
     .   : milestone, 370,

    section CallTarget+Inlining+NGEN
    This PR (4180) - mean (1,136ms)  : 1105, 1168
     .   : milestone, 1136,
    master - mean (1,129ms)  : 1099, 1159
     .   : milestone, 1129,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4180) - mean (355ms)  : 351, 360
     .   : milestone, 355,
    master - mean (356ms)  : 349, 362
     .   : milestone, 356,

    section CallTarget+Inlining+NGEN
    This PR (4180) - mean (1,089ms)  : 1054, 1124
     .   : milestone, 1089,
    master - mean (1,091ms)  : 1066, 1116
     .   : milestone, 1091,

andrewlock · 2023-05-30T09:28:54Z

Benchmarks Report 🐌

Benchmarks for #4180 compared to master:

All benchmarks have the same speed
All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	631μs	250ns	969ns	0	2.63 KB
master	`WriteAndFlushEnrichedTraces`	net472	800μs	282ns	1.09μs	0.398	3.22 KB
#4180	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	655μs	184ns	688ns	0	2.63 KB
#4180	`WriteAndFlushEnrichedTraces`	net472	812μs	342ns	1.33μs	0.406	3.22 KB

Benchmarks.Trace.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`AllCycleSimpleBody`	netcoreapp3.1	40.9μs	42.5ns	159ns	0.0205	0	1.63 KB
master	`AllCycleSimpleBody`	net472	42μs	87.3ns	338ns	0.267	0	1.69 KB
master	`AllCycleMoreComplexBody`	netcoreapp3.1	229μs	388ns	1.5μs	0.115	0	9.12 KB
master	`AllCycleMoreComplexBody`	net472	239μs	45.8ns	177ns	1.42	0	9.28 KB
master	`ObjectExtractorSimpleBody`	netcoreapp3.1	175ns	0.0421ns	0.157ns	0.00371	0	272 B
master	`ObjectExtractorSimpleBody`	net472	144ns	0.152ns	0.569ns	0.0446	0	281 B
master	`ObjectExtractorMoreComplexBody`	netcoreapp3.1	4.19μs	1.31ns	5.07ns	0.0503	0	3.78 KB
master	`ObjectExtractorMoreComplexBody`	net472	4.08μs	4.37ns	16.4ns	0.617	0.00617	3.89 KB
#4180	`AllCycleSimpleBody`	netcoreapp3.1	41.1μs	130ns	505ns	0.0201	0	1.63 KB
#4180	`AllCycleSimpleBody`	net472	42.7μs	10.3ns	39.8ns	0.252	0	1.69 KB
#4180	`AllCycleMoreComplexBody`	netcoreapp3.1	229μs	275ns	1.07μs	0.114	0	9.12 KB
#4180	`AllCycleMoreComplexBody`	net472	239μs	68.6ns	266ns	1.43	0	9.28 KB
#4180	`ObjectExtractorSimpleBody`	netcoreapp3.1	193ns	0.971ns	4.23ns	0.0037	0	272 B
#4180	`ObjectExtractorSimpleBody`	net472	146ns	0.165ns	0.617ns	0.0446	0	281 B
#4180	`ObjectExtractorMoreComplexBody`	netcoreapp3.1	4.33μs	1.72ns	6.64ns	0.05	0	3.78 KB
#4180	`ObjectExtractorMoreComplexBody`	net472	4.1μs	3.78ns	14.1ns	0.617	0.00613	3.89 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	netcoreapp3.1	181μs	271ns	1.05μs	0.182	19.93 KB
master	`SendRequest`	net472	0.00101ns	0.000397ns	0.00154ns	0	0 b
#4180	`SendRequest`	netcoreapp3.1	182μs	225ns	872ns	0.181	19.92 KB
#4180	`SendRequest`	net472	0.000632ns	0.000182ns	0.000655ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	616μs	696ns	2.6μs	0.317	0	0	41.66 KB
master	`WriteAndFlushEnrichedTraces`	net472	785μs	4.04μs	18.5μs	8.31	2.37	0.396	53.23 KB
#4180	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	606μs	1.86μs	7.2μs	0.308	0	0	41.62 KB
#4180	`WriteAndFlushEnrichedTraces`	net472	793μs	3.54μs	13.7μs	8.44	2.68	0.383	53.24 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteNonQuery`	netcoreapp3.1	1.15μs	0.669ns	2.5ns	0.0097	0	728 B
master	`ExecuteNonQuery`	net472	1.39μs	0.662ns	2.48ns	0.11	0	690 B
#4180	`ExecuteNonQuery`	netcoreapp3.1	1.2μs	0.225ns	0.841ns	0.00954	0	728 B
#4180	`ExecuteNonQuery`	net472	1.39μs	0.652ns	2.52ns	0.109	0.000692	690 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`CallElasticsearch`	netcoreapp3.1	1.19μs	0.294ns	1.14ns	0.0101	0	0	752 B
master	`CallElasticsearch`	net472	1.92μs	0.474ns	1.84ns	0.121	0.000958	0	762 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.2μs	0.58ns	2.25ns	0.0108	0	0	800 B
master	`CallElasticsearchAsync`	net472	2.16μs	0.849ns	3.06ns	0.13	0.00108	0	819 B
#4180	`CallElasticsearch`	netcoreapp3.1	1.18μs	1.11ns	4.02ns	0.00982	0	0	752 B
#4180	`CallElasticsearch`	net472	2.07μs	0.71ns	2.66ns	0.121	0.00206	0.00103	762 B
#4180	`CallElasticsearchAsync`	netcoreapp3.1	1.22μs	1.04ns	3.9ns	0.0105	0	0	800 B
#4180	`CallElasticsearchAsync`	net472	2.15μs	0.777ns	3.01ns	0.13	0	0	819 B

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteAsync`	netcoreapp3.1	1.34μs	1.23ns	4.43ns	0.0126	0	920 B
master	`ExecuteAsync`	net472	1.53μs	0.603ns	2.34ns	0.14	0.000763	883 B
#4180	`ExecuteAsync`	netcoreapp3.1	1.35μs	1.39ns	5ns	0.0121	0	920 B
#4180	`ExecuteAsync`	net472	1.57μs	0.31ns	1.12ns	0.14	0	883 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	netcoreapp3.1	4.24μs	1.63ns	6.1ns	0.0298	2.26 KB
master	`SendAsync`	net472	6.65μs	2.18ns	8.43ns	0.446	2.82 KB
#4180	`SendAsync`	netcoreapp3.1	4.24μs	1.78ns	6.65ns	0.0296	2.26 KB
#4180	`SendAsync`	net472	6.7μs	2.21ns	8.28ns	0.448	2.82 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	netcoreapp3.1	1.9μs	1.26ns	4.73ns	0.0218	1.63 KB
master	`EnrichedLog`	net472	2.21μs	1.22ns	4.55ns	0.245	1.55 KB
#4180	`EnrichedLog`	netcoreapp3.1	1.79μs	0.949ns	3.55ns	0.0217	1.63 KB
#4180	`EnrichedLog`	net472	2.2μs	1.4ns	5.22ns	0.245	1.55 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	netcoreapp3.1	117μs	238ns	922ns	0.0579	0	4.22 KB
master	`EnrichedLog`	net472	148μs	99.2ns	384ns	0.665	0.222	4.39 KB
#4180	`EnrichedLog`	netcoreapp3.1	118μs	191ns	740ns	0	0	4.22 KB
#4180	`EnrichedLog`	net472	147μs	141ns	546ns	0.661	0.22	4.39 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	netcoreapp3.1	3.79μs	1.97ns	7.37ns	0.0491	0	3.7 KB
master	`EnrichedLog`	net472	4.75μs	1.33ns	4.96ns	0.526	0.00237	3.32 KB
#4180	`EnrichedLog`	netcoreapp3.1	3.66μs	1.43ns	5.35ns	0.0492	0	3.7 KB
#4180	`EnrichedLog`	net472	4.86μs	1.09ns	4.21ns	0.526	0.00244	3.32 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	netcoreapp3.1	1.45μs	0.667ns	2.58ns	0.0136	1.01 KB
master	`SendReceive`	net472	1.63μs	0.719ns	2.49ns	0.16	1.01 KB
#4180	`SendReceive`	netcoreapp3.1	1.44μs	0.636ns	2.38ns	0.0136	1.01 KB
#4180	`SendReceive`	net472	1.64μs	1.7ns	6.38ns	0.16	1.01 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	netcoreapp3.1	3.53μs	2.42ns	9.04ns	0.0212	1.58 KB
master	`EnrichedLog`	net472	3.99μs	1.4ns	5.42ns	0.311	1.97 KB
#4180	`EnrichedLog`	netcoreapp3.1	3.5μs	0.742ns	2.78ns	0.021	1.58 KB
#4180	`EnrichedLog`	net472	3.99μs	2.08ns	8.07ns	0.311	1.97 KB

Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	netcoreapp3.1	553ns	0.498ns	1.93ns	0.0075	544 B
master	`StartFinishSpan`	net472	590ns	0.176ns	0.68ns	0.0866	546 B
master	`StartFinishScope`	netcoreapp3.1	666ns	0.294ns	1.1ns	0.00883	664 B
master	`StartFinishScope`	net472	791ns	0.39ns	1.51ns	0.0992	626 B
#4180	`StartFinishSpan`	netcoreapp3.1	586ns	0.397ns	1.49ns	0.00733	544 B
#4180	`StartFinishSpan`	net472	640ns	0.42ns	1.63ns	0.0867	546 B
#4180	`StartFinishScope`	netcoreapp3.1	658ns	0.243ns	0.875ns	0.00889	664 B
#4180	`StartFinishScope`	net472	776ns	0.675ns	2.61ns	0.0992	626 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	netcoreapp3.1	842ns	1.3ns	4.5ns	0.00905	664 B
master	`RunOnMethodBegin`	net472	965ns	0.524ns	2.03ns	0.0994	626 B
#4180	`RunOnMethodBegin`	netcoreapp3.1	814ns	0.204ns	0.705ns	0.00884	664 B
#4180	`RunOnMethodBegin`	net472	977ns	2.05ns	7.68ns	0.0991	626 B

andrewlock · 2023-05-30T09:51:04Z

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4180) (11.467M)   : 0, 11466751
    master (11.524M)   : 0, 11523947
    benchmarks/2.30.0 (11.511M)   : 0, 11511353
    benchmarks/2.9.0 (11.162M)   : 0, 11161538

    section Automatic
    This PR (4180) (8.114M)   : 0, 8114191
    master (8.153M)   : 0, 8152620
    benchmarks/2.30.0 (8.079M)   : 0, 8079433
    benchmarks/2.9.0 (8.099M)   : 0, 8099075

    section Trace stats
    master (8.182M)   : 0, 8181770
    benchmarks/2.30.0 (8.064M)   : 0, 8064379

    section Manual
    This PR (4180) (10.257M)   : 0, 10257223
    master (10.366M)   : 0, 10366300
    benchmarks/2.30.0 (10.301M)   : 0, 10300812

    section Manual + Automatic
    This PR (4180) (7.722M)   : 0, 7722456
    master (7.801M)   : 0, 7800793
    benchmarks/2.30.0 (7.818M)   : 0, 7817667

    section Version Conflict
    master (7.116M)   : 0, 7116047
    benchmarks/2.30.0 (6.977M)   : 0, 6977174

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4180) (9.489M)   : 0, 9488586
    master (9.893M)   : 0, 9893315
    benchmarks/2.30.0 (9.717M)   : 0, 9717283
    benchmarks/2.9.0 (9.705M)   : 0, 9704781

    section Automatic
    This PR (4180) (6.684M)   : 0, 6684433
    master (6.896M)   : 0, 6895965
    benchmarks/2.30.0 (6.859M)   : 0, 6858691

    section Trace stats
    master (6.852M)   : 0, 6852274
    benchmarks/2.30.0 (6.632M)   : 0, 6631563

    section Manual
    This PR (4180) (8.619M)   : 0, 8618584
    master (8.535M)   : 0, 8535267
    benchmarks/2.30.0 (8.510M)   : 0, 8509554

    section Manual + Automatic
    This PR (4180) (6.668M)   : 0, 6667741
    master (6.793M)   : 0, 6792590
    benchmarks/2.30.0 (6.408M)   : 0, 6407736

    section Version Conflict
    master (6.075M)   : 0, 6075466
    benchmarks/2.30.0 (5.944M)   : 0, 5944257

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4180) (10.103M)   : 0, 10103032
    master (10.298M)   : 0, 10298366
    benchmarks/2.30.0 (10.769M)   : 0, 10768707
    benchmarks/2.9.0 (9.827M)   : 0, 9827121

    section Automatic
    This PR (4180) (7.242M)   : 0, 7242328
    master (7.463M)   : 0, 7462611
    benchmarks/2.30.0 (7.340M)   : 0, 7340012
    benchmarks/2.9.0 (7.246M)   : 0, 7246397

    section Trace stats
    master (7.340M)   : 0, 7340181
    benchmarks/2.30.0 (7.458M)   : 0, 7457655

    section Manual
    This PR (4180) (8.974M)   : 0, 8973948
    master (9.051M)   : 0, 9050829
    benchmarks/2.30.0 (9.281M)   : 0, 9280694

    section Manual + Automatic
    This PR (4180) (7.060M)   : 0, 7060401
    master (7.216M)   : 0, 7215668
    benchmarks/2.30.0 (7.373M)   : 0, 7372707

    section Version Conflict
    master (6.616M)   : 0, 6616140
    benchmarks/2.30.0 (6.376M)   : 0, 6375876

gantt
    title Throughput Linux x64 (ASM) (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4180) (7.548M)   : 0, 7548419
    master (7.502M)   : 0, 7502365
    benchmarks/2.30.0 (7.503M)   : 0, 7502766
    benchmarks/2.9.0 (7.748M)   : 0, 7748029

    section No attack
    This PR (4180) (2.429M)   : 0, 2429140
    master (2.415M)   : 0, 2415021
    benchmarks/2.30.0 (2.439M)   : 0, 2438736
    benchmarks/2.9.0 (3.274M)   : 0, 3273699

    section Attack
    This PR (4180) (2.042M)   : 0, 2041522
    master (2.055M)   : 0, 2055288
    benchmarks/2.30.0 (2.036M)   : 0, 2035591
    benchmarks/2.9.0 (2.598M)   : 0, 2597950

    section Blocking
    This PR (4180) (4.190M)   : 0, 4190222
    master (4.183M)   : 0, 4183416
    benchmarks/2.30.0 (4.044M)   : 0, 4044248

andrewlock added the area:telemetry label May 24, 2023

andrewlock requested a review from a team as a code owner May 24, 2023 15:23

This comment has been minimized.

Sign in to view

andrewlock force-pushed the andrew/telemetry/odds-and-ends branch from 8dbffc0 to 0e26e5c Compare May 24, 2023 16:14

This comment has been minimized.

Sign in to view

andrewlock force-pushed the andrew/telemetry/odds-and-ends branch from 0e26e5c to e7950ca Compare May 25, 2023 16:48

andrewlock added 5 commits May 25, 2023 17:58

Remove libVersion and libLanaguage from generate metrics (no longer r…

02bcbcf

…equired)

Switch metrics to use lists instead of arrays (as we need to mutate t…

dcbeb36

…hem during aggregation)

minor: no need to expose Telemetry properties

cdb9beb

Fix transport info for AgentlessTelemetryTransport

a6687b3

Add extensions to ConfigurationOptions to add ToStringFast

802b624

This comment has been minimized.

Sign in to view

kevingosse approved these changes May 26, 2023

View reviewed changes

andrewlock force-pushed the andrew/telemetry/odds-and-ends branch from e7950ca to 53e4821 Compare May 26, 2023 14:57

This was referenced May 26, 2023

More telemetry v2 preparation #4187

Merged

Add bulk of telemetry V2 implementation #4188

Merged

This comment has been minimized.

Sign in to view

pierotibou approved these changes May 30, 2023

View reviewed changes

Add support for disabling sending dependency

4c723fb

Add integration tests

andrewlock force-pushed the andrew/telemetry/odds-and-ends branch from 53e4821 to 4c723fb Compare May 30, 2023 08:56

andrewlock merged commit 489db70 into master May 30, 2023

andrewlock deleted the andrew/telemetry/odds-and-ends branch May 30, 2023 11:43

github-actions bot added this to the vNext milestone May 30, 2023

andrewlock mentioned this pull request May 30, 2023

Allow enabling v2 telemetry #4198

Merged

andrewlock mentioned this pull request Jun 13, 2023

Ensure dependency collector persists across telemetry controllers #4255

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Small updates to telemetry in preparation for V2 #4180

Small updates to telemetry in preparation for V2 #4180

andrewlock commented May 24, 2023

datadog-ddstaging bot commented May 24, 2023 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

pierotibou May 30, 2023

andrewlock May 30, 2023

andrewlock commented May 30, 2023

andrewlock commented May 30, 2023

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

andrewlock commented May 30, 2023

Small updates to telemetry in preparation for V2 #4180

Small updates to telemetry in preparation for V2 #4180

Conversation

andrewlock commented May 24, 2023

Summary of changes

Reason for change

Implementation details

Test coverage

datadog-ddstaging bot commented May 24, 2023 • edited Loading

Datadog Report

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

pierotibou May 30, 2023

Choose a reason for hiding this comment

andrewlock May 30, 2023

Choose a reason for hiding this comment

andrewlock commented May 30, 2023

Execution-Time Benchmarks Report ⏱️

andrewlock commented May 30, 2023

Benchmarks Report 🐌

Benchmark details

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

andrewlock commented May 30, 2023

Throughput/Crank Report:zap:

datadog-ddstaging bot commented May 24, 2023 •

edited

Loading