More telemetry v2 preparation #4187

andrewlock · 2023-05-26T15:06:20Z

Summary of changes

A bunch of minor changes, separated into a PR for easier reviewing

Add a setting for enabling v2
Add a setting for enabling metrics
Move some properties around for consistency

Reason for change

These are all bits and pieces I need as part of the v2 telemetry work. Extracted to a separate PR to make it easier to review both.

Implementation details

We will roll out v2 gradually, so will need a setting to be able to control whether it's enabled or not. Longer term, we will delete this setting along with the v1 implementation.

Similarly, we'll roll out metrics gradually (and it requires telemetry v2)

Moved the TelemetryFactoryV2.GetConfigInstance() and TelemetryMetrics.Instance calls to TelemetryFactory for consistency (and because the TelemetryFactory will need to manage the lifetime of these subsequently)

Test coverage

Some unit tests, but none of this is in use yet

Other details

Requires merging #4180 first

kevingosse · 2023-05-26T15:32:06Z

tracer/src/Datadog.Trace/Telemetry/TelemetrySettings.cs

+                                             return true;
+                                         }
+
+                                         configurationError = configurationError is null


I'm noticing it just now, but it should probably be a helper method (or declaring configurationErrors as a list).

Unrelated to this PR though.

Yeah, I agree 👍

datadog-ddstaging · 2023-05-26T16:06:07Z

Datadog Report

Branch report: andrew/telemetry/more-v2-prep
Commit report: 006155e

✅ dd-trace-dotnet: 0 Failed, 0 New Flaky, 281034 Passed, 1799 Skipped, 25m 32.04s Wall Time

tracer/src/Datadog.Trace/Configuration/ConfigurationKeys.cs

No sense in having a separate V2 factory, and we will need to manage the lifetime of these in TelemetryFactory anyway later, so this move makes sense I think

No sense in it living in a separate class given that we need to manage the lifetime of these in TelemetryFactory anyway later, so this move makes sense I think

andrewlock · 2023-05-30T12:36:58Z

Benchmarks Report 🐌

Benchmarks for #4187 compared to master:

1 benchmarks are faster, with geometric mean 1.115
All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	636μs	200ns	749ns	0	2.63 KB
master	`WriteAndFlushEnrichedTraces`	net472	800μs	208ns	805ns	0.401	3.22 KB
#4187	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	649μs	237ns	886ns	0	2.63 KB
#4187	`WriteAndFlushEnrichedTraces`	net472	813μs	288ns	1.04μs	0.406	3.22 KB

Benchmarks.Trace.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`AllCycleSimpleBody`	netcoreapp3.1	40.9μs	152ns	590ns	0.0205	0	1.63 KB
master	`AllCycleSimpleBody`	net472	41.8μs	37.5ns	145ns	0.249	0	1.69 KB
master	`AllCycleMoreComplexBody`	netcoreapp3.1	230μs	280ns	1.09μs	0.114	0	9.12 KB
master	`AllCycleMoreComplexBody`	net472	238μs	309ns	1.2μs	1.42	0	9.28 KB
master	`ObjectExtractorSimpleBody`	netcoreapp3.1	179ns	0.263ns	1.02ns	0.00377	0	272 B
master	`ObjectExtractorSimpleBody`	net472	145ns	0.0953ns	0.343ns	0.0446	0	281 B
master	`ObjectExtractorMoreComplexBody`	netcoreapp3.1	4.09μs	2.39ns	8.93ns	0.0513	0	3.78 KB
master	`ObjectExtractorMoreComplexBody`	net472	4.14μs	4.26ns	14.8ns	0.618	0.00618	3.89 KB
#4187	`AllCycleSimpleBody`	netcoreapp3.1	41.8μs	23.5ns	88ns	0.0202	0	1.63 KB
#4187	`AllCycleSimpleBody`	net472	42.4μs	57.4ns	222ns	0.249	0	1.69 KB
#4187	`AllCycleMoreComplexBody`	netcoreapp3.1	233μs	296ns	1.07μs	0.116	0	9.12 KB
#4187	`AllCycleMoreComplexBody`	net472	241μs	265ns	1.03μs	1.44	0	9.28 KB
#4187	`ObjectExtractorSimpleBody`	netcoreapp3.1	171ns	0.103ns	0.397ns	0.00378	0	272 B
#4187	`ObjectExtractorSimpleBody`	net472	153ns	0.263ns	1.02ns	0.0446	0	281 B
#4187	`ObjectExtractorMoreComplexBody`	netcoreapp3.1	4.12μs	3.36ns	12.1ns	0.0514	0	3.78 KB
#4187	`ObjectExtractorMoreComplexBody`	net472	4.19μs	6.05ns	22.6ns	0.618	0.00637	3.89 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	netcoreapp3.1	182μs	267ns	1.04μs	0.18	19.92 KB
master	`SendRequest`	net472	7.03E‑05ns	7.03E‑05ns	0.000253ns	0	0 b
#4187	`SendRequest`	netcoreapp3.1	182μs	214ns	828ns	0.181	19.92 KB
#4187	`SendRequest`	net472	0.00146ns	0.000339ns	0.00131ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	639μs	935ns	3.24μs	0.322	0	0	41.92 KB
master	`WriteAndFlushEnrichedTraces`	net472	780μs	2.55μs	9.54μs	8.28	2.64	0.377	53.21 KB
#4187	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	617μs	1.1μs	4.25μs	0.309	0	0	41.83 KB
#4187	`WriteAndFlushEnrichedTraces`	net472	785μs	3.57μs	13.8μs	8.25	2.36	0.393	53.22 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteNonQuery`	netcoreapp3.1	1.16μs	0.377ns	1.46ns	0.00999	0	728 B
master	`ExecuteNonQuery`	net472	1.37μs	0.284ns	1.02ns	0.11	0	690 B
#4187	`ExecuteNonQuery`	netcoreapp3.1	1.17μs	0.441ns	1.65ns	0.00989	0	728 B
#4187	`ExecuteNonQuery`	net472	1.35μs	0.447ns	1.73ns	0.109	0.000676	690 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`CallElasticsearch`	netcoreapp3.1	1.17μs	1.1ns	4.12ns	0.00992	0	752 B
master	`CallElasticsearch`	net472	1.94μs	0.382ns	1.43ns	0.12	0.000963	762 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.19μs	0.386ns	1.44ns	0.0107	0	800 B
master	`CallElasticsearchAsync`	net472	2.05μs	1.2ns	4.5ns	0.129	0.00102	819 B
#4187	`CallElasticsearch`	netcoreapp3.1	1.19μs	0.656ns	2.45ns	0.0102	0	752 B
#4187	`CallElasticsearch`	net472	1.97μs	0.637ns	2.47ns	0.121	0.000982	762 B
#4187	`CallElasticsearchAsync`	netcoreapp3.1	1.25μs	0.595ns	2.31ns	0.0106	0	800 B
#4187	`CallElasticsearchAsync`	net472	2.06μs	1.24ns	4.81ns	0.129	0.00103	819 B

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteAsync`	netcoreapp3.1	1.27μs	0.613ns	2.29ns	0.0122	0	920 B
master	`ExecuteAsync`	net472	1.54μs	0.509ns	1.97ns	0.14	0.000761	883 B
#4187	`ExecuteAsync`	netcoreapp3.1	1.38μs	0.389ns	1.45ns	0.0124	0	920 B
#4187	`ExecuteAsync`	net472	1.53μs	0.654ns	2.53ns	0.14	0	883 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	netcoreapp3.1	4.32μs	7.59ns	29.4ns	0.0299	2.26 KB
master	`SendAsync`	net472	6.67μs	1.78ns	6.66ns	0.448	2.82 KB
#4187	`SendAsync`	netcoreapp3.1	4.2μs	2.59ns	9.32ns	0.0293	2.26 KB
#4187	`SendAsync`	net472	6.63μs	2.55ns	9.88ns	0.447	2.82 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	netcoreapp3.1	1.79μs	0.82ns	3.07ns	0.0224	1.63 KB
master	`EnrichedLog`	net472	2.31μs	1.34ns	5.18ns	0.246	1.55 KB
#4187	`EnrichedLog`	netcoreapp3.1	1.88μs	0.94ns	3.64ns	0.0226	1.63 KB
#4187	`EnrichedLog`	net472	2.28μs	1.64ns	6.14ns	0.245	1.55 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	netcoreapp3.1	119μs	134ns	500ns	0	0	4.22 KB
master	`EnrichedLog`	net472	147μs	185ns	715ns	0.651	0.217	4.39 KB
#4187	`EnrichedLog`	netcoreapp3.1	117μs	135ns	504ns	0	0	4.22 KB
#4187	`EnrichedLog`	net472	146μs	138ns	517ns	0.651	0.217	4.39 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	netcoreapp3.1	3.6μs	1.36ns	5.08ns	0.0488	0	3.7 KB
master	`EnrichedLog`	net472	4.93μs	2.35ns	8.8ns	0.528	0.00243	3.32 KB
#4187	`EnrichedLog`	netcoreapp3.1	3.75μs	1.24ns	4.65ns	0.0488	0	3.7 KB
#4187	`EnrichedLog`	net472	4.83μs	1.2ns	4.66ns	0.527	0.00242	3.32 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`SendReceive`	netcoreapp3.1	1.54μs	0.99ns	3.84ns	0.0131	0	1.01 KB
master	`SendReceive`	net472	1.73μs	1.49ns	5.78ns	0.16	0	1.01 KB
#4187	`SendReceive`	netcoreapp3.1	1.4μs	0.621ns	2.32ns	0.0139	0	1.01 KB
#4187	`SendReceive`	net472	1.74μs	1.97ns	7.37ns	0.16	0.000866	1.01 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	netcoreapp3.1	3.56μs	1.07ns	3.85ns	0.0215	1.58 KB
master	`EnrichedLog`	net472	3.97μs	1.34ns	5ns	0.312	1.97 KB
#4187	`EnrichedLog`	netcoreapp3.1	3.48μs	1.09ns	4.23ns	0.0212	1.58 KB
#4187	`EnrichedLog`	net472	4.05μs	0.918ns	3.43ns	0.312	1.97 KB

Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #4187

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1	1.115	723.20	648.81

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	netcoreapp3.1	550ns	0.383ns	1.48ns	0.00718	544 B
master	`StartFinishSpan`	net472	646ns	0.36ns	1.35ns	0.0867	546 B
master	`StartFinishScope`	netcoreapp3.1	723ns	0.479ns	1.79ns	0.00902	664 B
master	`StartFinishScope`	net472	843ns	0.653ns	2.53ns	0.0994	626 B
#4187	`StartFinishSpan`	netcoreapp3.1	546ns	0.809ns	3.03ns	0.0073	544 B
#4187	`StartFinishSpan`	net472	648ns	0.58ns	2.25ns	0.0867	546 B
#4187	`StartFinishScope`	netcoreapp3.1	647ns	1.27ns	4.92ns	0.00897	664 B
#4187	`StartFinishScope`	net472	785ns	0.576ns	2.16ns	0.0993	626 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	netcoreapp3.1	755ns	0.323ns	1.21ns	0.00871	664 B
master	`RunOnMethodBegin`	net472	956ns	0.749ns	2.8ns	0.0991	626 B
#4187	`RunOnMethodBegin`	netcoreapp3.1	753ns	0.323ns	1.21ns	0.00902	664 B
#4187	`RunOnMethodBegin`	net472	954ns	0.976ns	3.65ns	0.0992	626 B

andrewlock · 2023-05-30T12:59:11Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4187) - mean (3,030ms)  : 2935, 3124
     .   : milestone, 3030,
    master - mean (3,049ms)  : 2983, 3115
     .   : milestone, 3049,

    section CallTarget+Inlining+NGEN
    This PR (4187) - mean (3,753ms)  : 3667, 3838
     .   : milestone, 3753,
    master - mean (3,769ms)  : 3678, 3860
     .   : milestone, 3769,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4187) - mean (3,140ms)  : 2969, 3310
     .   : milestone, 3140,
    master - mean (3,134ms)  : 3017, 3251
     .   : milestone, 3134,

    section CallTarget+Inlining+NGEN
    This PR (4187) - mean (3,597ms)  : 3528, 3665
     .   : milestone, 3597,
    master - mean (3,599ms)  : 3517, 3681
     .   : milestone, 3599,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4187) - mean (3,117ms)  : 2979, 3256
     .   : milestone, 3117,
    master - mean (3,138ms)  : 2990, 3286
     .   : milestone, 3138,

    section CallTarget+Inlining+NGEN
    This PR (4187) - mean (3,574ms)  : 3498, 3651
     .   : milestone, 3574,
    master - mean (3,568ms)  : 3497, 3639
     .   : milestone, 3568,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4187) - mean (188ms)  : 184, 193
     .   : milestone, 188,
    master - mean (187ms)  : 184, 190
     .   : milestone, 187,

    section CallTarget+Inlining+NGEN
    This PR (4187) - mean (1,025ms)  : 978, 1072
     .   : milestone, 1025,
    master - mean (1,035ms)  : 984, 1085
     .   : milestone, 1035,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4187) - mean (369ms)  : 363, 375
     .   : milestone, 369,

    section CallTarget+Inlining+NGEN
    This PR (4187) - mean (1,134ms)  : 1107, 1161
     .   : milestone, 1134,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4187) - mean (357ms)  : 349, 364
     .   : milestone, 357,
    master - mean (357ms)  : 352, 362
     .   : milestone, 357,

    section CallTarget+Inlining+NGEN
    This PR (4187) - mean (1,095ms)  : 1072, 1119
     .   : milestone, 1095,
    master - mean (1,088ms)  : 1062, 1114
     .   : milestone, 1088,

andrewlock · 2023-05-30T13:56:06Z

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4187) (11.444M)   : 0, 11443525
    master (11.553M)   : 0, 11552686
    benchmarks/2.30.0 (11.511M)   : 0, 11511353
    benchmarks/2.9.0 (11.162M)   : 0, 11161538

    section Automatic
    This PR (4187) (8.135M)   : 0, 8134909
    master (8.192M)   : 0, 8192371
    benchmarks/2.30.0 (8.079M)   : 0, 8079433
    benchmarks/2.9.0 (8.099M)   : 0, 8099075

    section Trace stats
    master (8.137M)   : 0, 8137204
    benchmarks/2.30.0 (8.064M)   : 0, 8064379

    section Manual
    This PR (4187) (10.140M)   : 0, 10140259
    master (10.349M)   : 0, 10348918
    benchmarks/2.30.0 (10.301M)   : 0, 10300812

    section Manual + Automatic
    This PR (4187) (7.868M)   : 0, 7868336
    master (7.764M)   : 0, 7764006
    benchmarks/2.30.0 (7.818M)   : 0, 7817667

    section Version Conflict
    master (6.121M)   : 0, 6120794
    benchmarks/2.30.0 (6.977M)   : 0, 6977174

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4187) (9.655M)   : 0, 9655174
    master (9.584M)   : 0, 9583834
    benchmarks/2.30.0 (9.717M)   : 0, 9717283
    benchmarks/2.9.0 (9.705M)   : 0, 9704781

    section Automatic
    This PR (4187) (6.846M)   : 0, 6845776
    master (6.891M)   : 0, 6890936
    benchmarks/2.30.0 (6.859M)   : 0, 6858691

    section Trace stats
    master (6.666M)   : 0, 6665745
    benchmarks/2.30.0 (6.632M)   : 0, 6631563

    section Manual
    This PR (4187) (8.347M)   : 0, 8346741
    master (8.534M)   : 0, 8534469
    benchmarks/2.30.0 (8.510M)   : 0, 8509554

    section Manual + Automatic
    This PR (4187) (6.632M)   : 0, 6631639
    master (6.576M)   : 0, 6575762
    benchmarks/2.30.0 (6.408M)   : 0, 6407736

    section Version Conflict
    master (6.041M)   : 0, 6040607
    benchmarks/2.30.0 (5.944M)   : 0, 5944257

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4187) (10.035M)   : 0, 10034610
    master (10.236M)   : 0, 10236043
    benchmarks/2.30.0 (10.769M)   : 0, 10768707
    benchmarks/2.9.0 (9.827M)   : 0, 9827121

    section Automatic
    This PR (4187) (7.165M)   : 0, 7164570
    master (7.394M)   : 0, 7393988
    benchmarks/2.30.0 (7.340M)   : 0, 7340012
    benchmarks/2.9.0 (7.246M)   : 0, 7246397

    section Trace stats
    master (7.325M)   : 0, 7324690
    benchmarks/2.30.0 (7.458M)   : 0, 7457655

    section Manual
    This PR (4187) (9.048M)   : 0, 9047700
    master (9.129M)   : 0, 9129334
    benchmarks/2.30.0 (9.281M)   : 0, 9280694

    section Manual + Automatic
    This PR (4187) (7.012M)   : 0, 7011873
    master (7.346M)   : 0, 7346206
    benchmarks/2.30.0 (7.373M)   : 0, 7372707

    section Version Conflict
    master (6.325M)   : 0, 6325378
    benchmarks/2.30.0 (6.376M)   : 0, 6375876

gantt
    title Throughput Linux x64 (ASM) (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4187) (7.552M)   : 0, 7552141
    master (7.600M)   : 0, 7599735
    benchmarks/2.30.0 (7.503M)   : 0, 7502766
    benchmarks/2.9.0 (7.748M)   : 0, 7748029

    section No attack
    This PR (4187) (2.400M)   : 0, 2399772
    master (2.446M)   : 0, 2445559
    benchmarks/2.30.0 (2.439M)   : 0, 2438736
    benchmarks/2.9.0 (3.274M)   : 0, 3273699

    section Attack
    This PR (4187) (2.041M)   : 0, 2040908
    master (2.040M)   : 0, 2040135
    benchmarks/2.30.0 (2.036M)   : 0, 2035591
    benchmarks/2.9.0 (2.598M)   : 0, 2597950

    section Blocking
    This PR (4187) (4.039M)   : 0, 4039082
    master (4.173M)   : 0, 4173103
    benchmarks/2.30.0 (4.044M)   : 0, 4044248

OmerRaviv

LGTM

andrewlock added the area:telemetry label May 26, 2023

andrewlock requested review from a team as code owners May 26, 2023 15:06

kevingosse approved these changes May 26, 2023

View reviewed changes

This comment has been minimized.

Sign in to view

pierotibou approved these changes May 30, 2023

View reviewed changes

tracer/src/Datadog.Trace/Configuration/ConfigurationKeys.cs Outdated Show resolved Hide resolved

andrewlock force-pushed the andrew/telemetry/odds-and-ends branch from 53e4821 to 4c723fb Compare May 30, 2023 08:56

andrewlock force-pushed the andrew/telemetry/more-v2-prep branch from 4d38c06 to f49cdda Compare May 30, 2023 08:58

This comment has been minimized.

Sign in to view

Base automatically changed from andrew/telemetry/odds-and-ends to master May 30, 2023 11:43

andrewlock added 4 commits May 30, 2023 12:45

Add a setting for v2 enabled (currently doesn't do anything)

225be6b

Add setting for enabling metrics (doesn't do anything yet)

46d0367

Move TelemetryFactoryV2.GetConfigInstance to TelemetryFactory.Config

81cf9da

No sense in having a separate V2 factory, and we will need to manage the lifetime of these in TelemetryFactory anyway later, so this move makes sense I think

Move TelemetryMetrics.Instance to TelemetryFactory.Metrics

006155e

No sense in it living in a separate class given that we need to manage the lifetime of these in TelemetryFactory anyway later, so this move makes sense I think

andrewlock force-pushed the andrew/telemetry/more-v2-prep branch from f49cdda to 006155e Compare May 30, 2023 11:45

anna-git approved these changes May 30, 2023

View reviewed changes

OmerRaviv approved these changes May 30, 2023

View reviewed changes

andrewlock mentioned this pull request May 30, 2023

Allow enabling v2 telemetry #4198

Merged

andrewlock merged commit ee5cb06 into master May 30, 2023

andrewlock deleted the andrew/telemetry/more-v2-prep branch May 30, 2023 15:26

github-actions bot added this to the vNext milestone May 30, 2023

andrewlock mentioned this pull request Jun 2, 2023

Add bulk of telemetry V2 implementation #4188

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

More telemetry v2 preparation #4187

More telemetry v2 preparation #4187

andrewlock commented May 26, 2023

kevingosse May 26, 2023

andrewlock May 30, 2023

datadog-ddstaging bot commented May 26, 2023 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

andrewlock commented May 30, 2023

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #4187

Raw results

Raw results

andrewlock commented May 30, 2023

andrewlock commented May 30, 2023

OmerRaviv left a comment

More telemetry v2 preparation #4187

More telemetry v2 preparation #4187

Conversation

andrewlock commented May 26, 2023

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

kevingosse May 26, 2023

Choose a reason for hiding this comment

andrewlock May 30, 2023

Choose a reason for hiding this comment

datadog-ddstaging bot commented May 26, 2023 • edited Loading

Datadog Report

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

andrewlock commented May 30, 2023

Benchmarks Report 🐌

Benchmark details

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #4187

Raw results

Raw results

andrewlock commented May 30, 2023

Execution-Time Benchmarks Report ⏱️

andrewlock commented May 30, 2023

Throughput/Crank Report:zap:

OmerRaviv left a comment

Choose a reason for hiding this comment

datadog-ddstaging bot commented May 26, 2023 •

edited

Loading