-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internal: implement new tag for trace source #3230
Conversation
add helper func to check trace-source string
…sm-standalone-billing-v2
Datadog ReportBranch report: ✅ 0 Failed, 5386 Passed, 72 Skipped, 2m 58.72s Total Time |
BenchmarksBenchmark execution time: 2025-02-28 13:46:47 Comparing candidate commit 176883a in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 2 unstable metrics. |
@@ -81,6 +81,8 @@ jobs: | |||
scenario: APPSEC_LOW_WAF_TIMEOUT | |||
- weblog-variant: net-http | |||
scenario: APPSEC_STANDALONE | |||
- weblog-variant: net-http | |||
scenario: APPSEC_STANDALONE_V2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
View all feedbacks in Devflow UI.
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
devflow unqueued this merge request: It did not become mergeable within the expected time |
/merge |
View all feedbacks in Devflow UI.
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
This pull request was merged directly. |
What does this PR do?
This PR implements the new RFC that adds support for new tag
_dd.p.ts
containing the "source" of a trace. This source represents the product that interacted with a trace.This tag is forwarded to downstream services that will decide wether to keep a trace or not based on their configuration plus the value of this tag.
The representation of this source is 2 character hexadecimal string of the bitmask. (eg:
02
when ASM interacts with a trace)The RFC also includes the renaming of the env var
DD_EXPERIMENTAL_APPSEC_STANDALONE_ENABLED
used to disable APM while keeping other product that use traces as their transport active.✅ System test successful run
Reviewer's Checklist
v2-dev
branch and reviewed by @DataDog/apm-go.