Standalone billing features, scenarios and tests reorg #4216
+60
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-romano-DD
requested review from
smola,
manuel-alvarez-alvarez and
zacharycmontoya
and removed request for
a team
jandro996
reviewed
Feb 28, 2025
utils/_features.py
Outdated
| @@ -2056,7 +2056,7 @@ def iast_standalone_v2(test_object): | |||
| return test_object | |||
|
|
|||
| @staticmethod | |||
| def sca_standalone(test_object): | |||
| def sca_standalone_experimental(test_object): | |||
| """SCA Standalone Billing | |||
There was a problem hiding this comment.
Suggested change
| """SCA Standalone Billing | |
| """Experimental SCA Standalone Billing |
jandro996
reviewed
Feb 28, 2025
| @@ -808,6 +808,7 @@ tests/: | |||
| '*': v1.45.0 | |||
| spring-boot-3-native: missing_feature (GraalVM. Tracing support only) | |||
| # SQLi was introduced in v1.38.0 (with RASP disabled by default, but was flaky) | |||
|
|
|||
There was a problem hiding this comment.
It's from the linter...
jandro996
reviewed
Feb 28, 2025
| @@ -201,6 +201,7 @@ tests/: | |||
| Test_Parametric_DDTrace_Current_Span: incomplete_test_app (current_span endpoint is not implemented) | |||
| Test_Parametric_DDTrace_Extract_Headers: v1.0.1.dev | |||
| # cpp tracer does not support the OpenTelemetry API, otel parametric endpoints are not implemented | |||
|
|
|||
There was a problem hiding this comment.
This one also (./format.sh)
jandro996
approved these changes
Feb 28, 2025
7 tasks
cbeauchesne
requested changes
Feb 28, 2025
| appsec_standalone_v2 = EndToEndScenario( | ||
| "APPSEC_STANDALONE_V2", | ||
| appsec_standalone_experimental = EndToEndScenario( | ||
| "APPSEC_STANDALONE_EXPERIMENTAL", |
There was a problem hiding this comment.
Renaming scenario is dangerous, you need to crawl all CI to verify that they do not refer to it, and update them if needed.
Two good enough solution for that issue :
- do not rename scenarios : it's just names
- rename, but handle in
run.shlegacy names , see line 378
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Standalone billing feature naming was confusing. the V2 is meant to be the official first release, while the previous V1 was an experimental feature.
Changes
Renamed original standalone billing as Experimental, and the new V2 as no suffix or prefix.
Workflow
codeownersfile quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>], double-check that only<language>is impacted by the changebuild-XXX-imagelabel is present