Remove filtering of `DD_SERVICE` and `DD_ENV` from the tracer #8176

mhlidd · 2025-01-09T22:48:43Z

What Does This Do

APMAPI-1003
Removes filtering of DD_SERVICE and DD_ENV from the tracer. Reverts #6636. Tested through system-tests and unit tests.

Motivation

With Adaptive Sampling, the Java tracer is rejecting remote sampling rules that use SSI when the tracer sees that the values of DD_ENV are empty. However, the env is automatically configured in the agent with SSI, so this PR removes all filtering of DD_SERVICE and DD_ENV in the tracer as it is already being done in remote config.

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: APMAPI-1004

pr-commenter · 2025-01-09T23:31:34Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mhlidd/remote_config_env
git_commit_date	1737468262	1737470507
git_commit_sha	`2b72cb5`	`6e487ae`
release_version	1.46.0-SNAPSHOT~2b72cb577a	1.46.0-SNAPSHOT~6e487aedb4

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1737472789	1737472789
ci_job_id	774124803	774124803
ci_pipeline_id	53558736	53558736
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 3 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.46.0-SNAPSHOT~6e487aedb4, baseline=1.46.0-SNAPSHOT~2b72cb577a

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.061 s) : 0, 1061487
Total [baseline] (8.666 s) : 0, 8665505
Agent [candidate] (1.056 s) : 0, 1055511
Total [candidate] (8.639 s) : 0, 8639420
section iast
Agent [baseline] (1.186 s) : 0, 1185765
Total [baseline] (9.198 s) : 0, 9197681
Agent [candidate] (1.184 s) : 0, 1183966
Total [candidate] (9.199 s) : 0, 9199295
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.185 s) : 0, 1184670
Total [baseline] (9.172 s) : 0, 9172218
Agent [candidate] (1.189 s) : 0, 1189259
Total [candidate] (9.201 s) : 0, 9201058
section iast_TELEMETRY_OFF
Agent [baseline] (1.181 s) : 0, 1180678
Total [baseline] (9.19 s) : 0, 9190264
Agent [candidate] (1.181 s) : 0, 1180525
Total [candidate] (9.222 s) : 0, 9222277

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.061 s	-
Agent	iast	1.186 s	124.278 ms (11.7%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.185 s	123.183 ms (11.6%)
Agent	iast_TELEMETRY_OFF	1.181 s	119.191 ms (11.2%)
Total	tracing	8.666 s	-
Total	iast	9.198 s	532.176 ms (6.1%)
Total	iast_HARDCODED_SECRET_DISABLED	9.172 s	506.713 ms (5.8%)
Total	iast_TELEMETRY_OFF	9.19 s	524.759 ms (6.1%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.056 s	-
Agent	iast	1.184 s	128.456 ms (12.2%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.189 s	133.748 ms (12.7%)
Agent	iast_TELEMETRY_OFF	1.181 s	125.014 ms (11.8%)
Total	tracing	8.639 s	-
Total	iast	9.199 s	559.875 ms (6.5%)
Total	iast_HARDCODED_SECRET_DISABLED	9.201 s	561.638 ms (6.5%)
Total	iast_TELEMETRY_OFF	9.222 s	582.857 ms (6.7%)

gantt
    title insecure-bank - break down per module: candidate=1.46.0-SNAPSHOT~6e487aedb4, baseline=1.46.0-SNAPSHOT~2b72cb577a

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (720.188 ms) : 0, 720188
BytebuddyAgent [candidate] (714.392 ms) : 0, 714392
GlobalTracer [baseline] (255.602 ms) : 0, 255602
GlobalTracer [candidate] (255.376 ms) : 0, 255376
AppSec [baseline] (55.575 ms) : 0, 55575
AppSec [candidate] (57.124 ms) : 0, 57124
Remote Config [baseline] (744.563 µs) : 0, 745
Remote Config [candidate] (730.761 µs) : 0, 731
Telemetry [baseline] (14.338 ms) : 0, 14338
Telemetry [candidate] (12.878 ms) : 0, 12878
section iast
BytebuddyAgent [baseline] (832.77 ms) : 0, 832770
BytebuddyAgent [candidate] (833.649 ms) : 0, 833649
GlobalTracer [baseline] (248.219 ms) : 0, 248219
GlobalTracer [candidate] (246.575 ms) : 0, 246575
AppSec [baseline] (58.64 ms) : 0, 58640
AppSec [candidate] (57.988 ms) : 0, 57988
IAST [baseline] (21.666 ms) : 0, 21666
IAST [candidate] (21.348 ms) : 0, 21348
Remote Config [baseline] (667.87 µs) : 0, 668
Remote Config [candidate] (666.288 µs) : 0, 666
Telemetry [baseline] (8.844 ms) : 0, 8844
Telemetry [candidate] (8.715 ms) : 0, 8715
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (832.273 ms) : 0, 832273
BytebuddyAgent [candidate] (835.341 ms) : 0, 835341
GlobalTracer [baseline] (247.492 ms) : 0, 247492
GlobalTracer [candidate] (248.51 ms) : 0, 248510
AppSec [baseline] (58.434 ms) : 0, 58434
AppSec [candidate] (58.673 ms) : 0, 58673
IAST [baseline] (21.835 ms) : 0, 21835
IAST [candidate] (21.879 ms) : 0, 21879
Remote Config [baseline] (690.667 µs) : 0, 691
Remote Config [candidate] (686.443 µs) : 0, 686
Telemetry [baseline] (8.883 ms) : 0, 8883
Telemetry [candidate] (9.019 ms) : 0, 9019
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (829.956 ms) : 0, 829956
BytebuddyAgent [candidate] (829.949 ms) : 0, 829949
GlobalTracer [baseline] (247.238 ms) : 0, 247238
GlobalTracer [candidate] (246.906 ms) : 0, 246906
AppSec [baseline] (58.088 ms) : 0, 58088
AppSec [candidate] (58.017 ms) : 0, 58017
IAST [baseline] (20.946 ms) : 0, 20946
IAST [candidate] (21.246 ms) : 0, 21246
Remote Config [baseline] (672.397 µs) : 0, 672
Remote Config [candidate] (667.961 µs) : 0, 668
Telemetry [baseline] (8.723 ms) : 0, 8723
Telemetry [candidate] (8.71 ms) : 0, 8710

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.46.0-SNAPSHOT~6e487aedb4, baseline=1.46.0-SNAPSHOT~2b72cb577a

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.055 s) : 0, 1055435
Total [baseline] (10.514 s) : 0, 10514009
Agent [candidate] (1.055 s) : 0, 1055394
Total [candidate] (10.42 s) : 0, 10420098
section appsec
Agent [baseline] (1.199 s) : 0, 1198534
Total [baseline] (10.749 s) : 0, 10749015
Agent [candidate] (1.19 s) : 0, 1189786
Total [candidate] (10.719 s) : 0, 10719301
section iast
Agent [baseline] (1.195 s) : 0, 1194917
Total [baseline] (10.999 s) : 0, 10998697
Agent [candidate] (1.19 s) : 0, 1190290
Total [candidate] (11.062 s) : 0, 11061803
section profiling
Agent [baseline] (1.264 s) : 0, 1264077
Total [baseline] (10.857 s) : 0, 10857468
Agent [candidate] (1.258 s) : 0, 1258160
Total [candidate] (10.818 s) : 0, 10818074

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.055 s	-
Agent	appsec	1.199 s	143.099 ms (13.6%)
Agent	iast	1.195 s	139.482 ms (13.2%)
Agent	profiling	1.264 s	208.642 ms (19.8%)
Total	tracing	10.514 s	-
Total	appsec	10.749 s	235.006 ms (2.2%)
Total	iast	10.999 s	484.688 ms (4.6%)
Total	profiling	10.857 s	343.459 ms (3.3%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.055 s	-
Agent	appsec	1.19 s	134.393 ms (12.7%)
Agent	iast	1.19 s	134.896 ms (12.8%)
Agent	profiling	1.258 s	202.766 ms (19.2%)
Total	tracing	10.42 s	-
Total	appsec	10.719 s	299.203 ms (2.9%)
Total	iast	11.062 s	641.705 ms (6.2%)
Total	profiling	10.818 s	397.976 ms (3.8%)

gantt
    title petclinic - break down per module: candidate=1.46.0-SNAPSHOT~6e487aedb4, baseline=1.46.0-SNAPSHOT~2b72cb577a

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (713.876 ms) : 0, 713876
BytebuddyAgent [candidate] (714.073 ms) : 0, 714073
GlobalTracer [baseline] (255.193 ms) : 0, 255193
GlobalTracer [candidate] (255.144 ms) : 0, 255144
AppSec [baseline] (56.346 ms) : 0, 56346
AppSec [candidate] (55.438 ms) : 0, 55438
Remote Config [baseline] (746.049 µs) : 0, 746
Remote Config [candidate] (732.321 µs) : 0, 732
Telemetry [baseline] (14.343 ms) : 0, 14343
Telemetry [candidate] (14.992 ms) : 0, 14992
section appsec
BytebuddyAgent [baseline] (738.495 ms) : 0, 738495
BytebuddyAgent [candidate] (731.536 ms) : 0, 731536
GlobalTracer [baseline] (254.784 ms) : 0, 254784
GlobalTracer [candidate] (253.42 ms) : 0, 253420
AppSec [baseline] (171.196 ms) : 0, 171196
AppSec [candidate] (170.824 ms) : 0, 170824
Remote Config [baseline] (666.973 µs) : 0, 667
Remote Config [candidate] (672.696 µs) : 0, 673
Telemetry [baseline] (8.612 ms) : 0, 8612
Telemetry [candidate] (8.673 ms) : 0, 8673
IAST [baseline] (19.293 ms) : 0, 19293
IAST [candidate] (19.344 ms) : 0, 19344
section iast
BytebuddyAgent [baseline] (840.569 ms) : 0, 840569
BytebuddyAgent [candidate] (837.769 ms) : 0, 837769
GlobalTracer [baseline] (248.905 ms) : 0, 248905
GlobalTracer [candidate] (247.743 ms) : 0, 247743
AppSec [baseline] (58.895 ms) : 0, 58895
AppSec [candidate] (58.413 ms) : 0, 58413
Remote Config [baseline] (676.244 µs) : 0, 676
Remote Config [candidate] (677.962 µs) : 0, 678
Telemetry [baseline] (8.936 ms) : 0, 8936
Telemetry [candidate] (8.853 ms) : 0, 8853
IAST [baseline] (21.794 ms) : 0, 21794
IAST [candidate] (21.728 ms) : 0, 21728
section profiling
ProfilingAgent [baseline] (96.21 ms) : 0, 96210
ProfilingAgent [candidate] (95.333 ms) : 0, 95333
BytebuddyAgent [baseline] (708.848 ms) : 0, 708848
BytebuddyAgent [candidate] (705.772 ms) : 0, 705772
GlobalTracer [baseline] (351.997 ms) : 0, 351997
GlobalTracer [candidate] (351.025 ms) : 0, 351025
AppSec [baseline] (55.253 ms) : 0, 55253
AppSec [candidate] (54.327 ms) : 0, 54327
Remote Config [baseline] (724.444 µs) : 0, 724
Remote Config [candidate] (727.034 µs) : 0, 727
Telemetry [baseline] (8.852 ms) : 0, 8852
Telemetry [candidate] (8.894 ms) : 0, 8894
Profiling [baseline] (96.234 ms) : 0, 96234
Profiling [candidate] (95.358 ms) : 0, 95358

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2025-01-21T14:49:47	2025-01-21T14:56:52
git_branch	master	mhlidd/remote_config_env
git_commit_date	1737468262	1737470507
git_commit_sha	`2b72cb5`	`6e487ae`
release_version	1.46.0-SNAPSHOT~2b72cb577a	1.46.0-SNAPSHOT~6e487aedb4
start_time	2025-01-21T14:49:33	2025-01-21T14:56:38

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1737471769	1737471769
ci_job_id	774124804	774124804
ci_pipeline_id	53558736	53558736
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~6e487aedb4, baseline=1.46.0-SNAPSHOT~2b72cb577a
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.353 ms) : 1333, 1372
.   : milestone, 1353,
appsec (1.756 ms) : 1732, 1780
.   : milestone, 1756,
appsec_no_iast (1.785 ms) : 1761, 1809
.   : milestone, 1785,
iast (1.53 ms) : 1505, 1554
.   : milestone, 1530,
profiling (1.509 ms) : 1486, 1533
.   : milestone, 1509,
tracing (1.506 ms) : 1482, 1531
.   : milestone, 1506,
section candidate
no_agent (1.362 ms) : 1343, 1381
.   : milestone, 1362,
appsec (1.743 ms) : 1718, 1767
.   : milestone, 1743,
appsec_no_iast (1.752 ms) : 1729, 1774
.   : milestone, 1752,
iast (1.508 ms) : 1484, 1532
.   : milestone, 1508,
profiling (1.51 ms) : 1487, 1533
.   : milestone, 1510,
tracing (1.508 ms) : 1484, 1533
.   : milestone, 1508,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.353 ms [1.333 ms, 1.372 ms]	-
appsec	1.756 ms [1.732 ms, 1.78 ms]	403.301 µs (29.8%)
appsec_no_iast	1.785 ms [1.761 ms, 1.809 ms]	432.425 µs (32.0%)
iast	1.53 ms [1.505 ms, 1.554 ms]	177.104 µs (13.1%)
profiling	1.509 ms [1.486 ms, 1.533 ms]	156.804 µs (11.6%)
tracing	1.506 ms [1.482 ms, 1.531 ms]	153.958 µs (11.4%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.362 ms [1.343 ms, 1.381 ms]	-
appsec	1.743 ms [1.718 ms, 1.767 ms]	380.843 µs (28.0%)
appsec_no_iast	1.752 ms [1.729 ms, 1.774 ms]	389.686 µs (28.6%)
iast	1.508 ms [1.484 ms, 1.532 ms]	146.073 µs (10.7%)
profiling	1.51 ms [1.487 ms, 1.533 ms]	147.956 µs (10.9%)
tracing	1.508 ms [1.484 ms, 1.533 ms]	146.558 µs (10.8%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~6e487aedb4, baseline=1.46.0-SNAPSHOT~2b72cb577a
    dateFormat X
    axisFormat %s
section baseline
no_agent (378.775 µs) : 358, 399
.   : milestone, 379,
iast (507.765 µs) : 486, 530
.   : milestone, 508,
iast_FULL (737.198 µs) : 715, 759
.   : milestone, 737,
iast_GLOBAL (551.162 µs) : 530, 573
.   : milestone, 551,
iast_HARDCODED_SECRET_DISABLED (502.33 µs) : 481, 524
.   : milestone, 502,
iast_INACTIVE (460.749 µs) : 439, 482
.   : milestone, 461,
iast_TELEMETRY_OFF (498.242 µs) : 476, 520
.   : milestone, 498,
tracing (451.249 µs) : 429, 474
.   : milestone, 451,
section candidate
no_agent (380.232 µs) : 361, 400
.   : milestone, 380,
iast (511.236 µs) : 489, 534
.   : milestone, 511,
iast_FULL (742.259 µs) : 720, 764
.   : milestone, 742,
iast_GLOBAL (556.597 µs) : 535, 578
.   : milestone, 557,
iast_HARDCODED_SECRET_DISABLED (508.455 µs) : 487, 530
.   : milestone, 508,
iast_INACTIVE (452.897 µs) : 432, 474
.   : milestone, 453,
iast_TELEMETRY_OFF (488.823 µs) : 467, 510
.   : milestone, 489,
tracing (455.309 µs) : 434, 476
.   : milestone, 455,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	378.775 µs [358.378 µs, 399.173 µs]	-
iast	507.765 µs [485.927 µs, 529.603 µs]	128.99 µs (34.1%)
iast_FULL	737.198 µs [715.352 µs, 759.043 µs]	358.422 µs (94.6%)
iast_GLOBAL	551.162 µs [529.528 µs, 572.795 µs]	172.387 µs (45.5%)
iast_HARDCODED_SECRET_DISABLED	502.33 µs [480.742 µs, 523.919 µs]	123.555 µs (32.6%)
iast_INACTIVE	460.749 µs [439.286 µs, 482.213 µs]	81.974 µs (21.6%)
iast_TELEMETRY_OFF	498.242 µs [476.131 µs, 520.354 µs]	119.467 µs (31.5%)
tracing	451.249 µs [428.857 µs, 473.641 µs]	72.473 µs (19.1%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	380.232 µs [360.86 µs, 399.604 µs]	-
iast	511.236 µs [488.569 µs, 533.903 µs]	131.004 µs (34.5%)
iast_FULL	742.259 µs [720.39 µs, 764.127 µs]	362.026 µs (95.2%)
iast_GLOBAL	556.597 µs [534.887 µs, 578.306 µs]	176.364 µs (46.4%)
iast_HARDCODED_SECRET_DISABLED	508.455 µs [486.756 µs, 530.153 µs]	128.222 µs (33.7%)
iast_INACTIVE	452.897 µs [431.989 µs, 473.804 µs]	72.664 µs (19.1%)
iast_TELEMETRY_OFF	488.823 µs [467.449 µs, 510.197 µs]	108.591 µs (28.6%)
tracing	455.309 µs [434.212 µs, 476.407 µs]	75.077 µs (19.7%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mhlidd/remote_config_env
git_commit_date	1737468262	1737470507
git_commit_sha	`2b72cb5`	`6e487ae`
release_version	1.46.0-SNAPSHOT~2b72cb577a	1.46.0-SNAPSHOT~6e487aedb4

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1737472358	1737472358
ci_job_id	774124805	774124805
ci_pipeline_id	53558736	53558736
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~6e487aedb4, baseline=1.46.0-SNAPSHOT~2b72cb577a
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.306 s) : 15306000, 15306000
.   : milestone, 15306000,
appsec (15.091 s) : 15091000, 15091000
.   : milestone, 15091000,
iast (19.154 s) : 19154000, 19154000
.   : milestone, 19154000,
iast_GLOBAL (18.254 s) : 18254000, 18254000
.   : milestone, 18254000,
profiling (15.141 s) : 15141000, 15141000
.   : milestone, 15141000,
tracing (14.94 s) : 14940000, 14940000
.   : milestone, 14940000,
section candidate
no_agent (14.994 s) : 14994000, 14994000
.   : milestone, 14994000,
appsec (15.253 s) : 15253000, 15253000
.   : milestone, 15253000,
iast (18.823 s) : 18823000, 18823000
.   : milestone, 18823000,
iast_GLOBAL (17.984 s) : 17984000, 17984000
.   : milestone, 17984000,
profiling (15.002 s) : 15002000, 15002000
.   : milestone, 15002000,
tracing (15.07 s) : 15070000, 15070000
.   : milestone, 15070000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.306 s [15.306 s, 15.306 s]	-
appsec	15.091 s [15.091 s, 15.091 s]	-215.0 ms (-1.4%)
iast	19.154 s [19.154 s, 19.154 s]	3.848 s (25.1%)
iast_GLOBAL	18.254 s [18.254 s, 18.254 s]	2.948 s (19.3%)
profiling	15.141 s [15.141 s, 15.141 s]	-165.0 ms (-1.1%)
tracing	14.94 s [14.94 s, 14.94 s]	-366.0 ms (-2.4%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.994 s [14.994 s, 14.994 s]	-
appsec	15.253 s [15.253 s, 15.253 s]	259.0 ms (1.7%)
iast	18.823 s [18.823 s, 18.823 s]	3.829 s (25.5%)
iast_GLOBAL	17.984 s [17.984 s, 17.984 s]	2.99 s (19.9%)
profiling	15.002 s [15.002 s, 15.002 s]	8.0 ms (0.1%)
tracing	15.07 s [15.07 s, 15.07 s]	76.0 ms (0.5%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~6e487aedb4, baseline=1.46.0-SNAPSHOT~2b72cb577a
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.472 ms) : 1461, 1484
.   : milestone, 1472,
appsec (2.367 ms) : 2324, 2410
.   : milestone, 2367,
iast (2.106 ms) : 2052, 2161
.   : milestone, 2106,
iast_GLOBAL (2.158 ms) : 2103, 2213
.   : milestone, 2158,
profiling (1.968 ms) : 1925, 2012
.   : milestone, 1968,
tracing (1.954 ms) : 1912, 1996
.   : milestone, 1954,
section candidate
no_agent (1.472 ms) : 1460, 1483
.   : milestone, 1472,
appsec (2.369 ms) : 2326, 2412
.   : milestone, 2369,
iast (2.111 ms) : 2056, 2166
.   : milestone, 2111,
iast_GLOBAL (2.153 ms) : 2099, 2208
.   : milestone, 2153,
profiling (1.962 ms) : 1918, 2005
.   : milestone, 1962,
tracing (1.943 ms) : 1901, 1985
.   : milestone, 1943,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.472 ms [1.461 ms, 1.484 ms]	-
appsec	2.367 ms [2.324 ms, 2.41 ms]	895.203 µs (60.8%)
iast	2.106 ms [2.052 ms, 2.161 ms]	634.12 µs (43.1%)
iast_GLOBAL	2.158 ms [2.103 ms, 2.213 ms]	685.453 µs (46.6%)
profiling	1.968 ms [1.925 ms, 2.012 ms]	496.332 µs (33.7%)
tracing	1.954 ms [1.912 ms, 1.996 ms]	481.647 µs (32.7%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.472 ms [1.46 ms, 1.483 ms]	-
appsec	2.369 ms [2.326 ms, 2.412 ms]	897.339 µs (61.0%)
iast	2.111 ms [2.056 ms, 2.166 ms]	638.978 µs (43.4%)
iast_GLOBAL	2.153 ms [2.099 ms, 2.208 ms]	681.761 µs (46.3%)
profiling	1.962 ms [1.918 ms, 2.005 ms]	489.927 µs (33.3%)
tracing	1.943 ms [1.901 ms, 1.985 ms]	471.13 µs (32.0%)

dd-trace-core/src/test/groovy/datadog/trace/core/CoreTracerTest.groovy

github-actions · 2025-01-17T18:23:12Z

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

lucaspimentel

LGTM (but I'm not a dd-trace-java expert). Thanks!

mhlidd · 2025-01-21T15:30:04Z

Failing parametric test was disabled in this PR. Will XFAIL when system-test commit is updated in dd-trace-java

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-datastore](https://github.com/googleapis/java-datastore) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.25.4` -> `2.26.0` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.45.2` -> `1.46.0` | | [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.45.2` -> `1.46.0` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | --- ### Release Notes <details> <summary>googleapis/java-datastore (com.google.cloud:google-cloud-datastore)</summary> ### [`v2.26.0`](https://github.com/googleapis/java-datastore/blob/HEAD/CHANGELOG.md#2260-2025-01-29) ##### Features - Add firestoreInDatastoreMode for datastore emulator ([#1698](googleapis/java-datastore#1698)) ([50f106d](googleapis/java-datastore@50f106d)) ##### Dependencies - Update dependency com.google.cloud:sdk-platform-java-config to v3.42.0 ([#1725](googleapis/java-datastore#1725)) ([1cbaf22](googleapis/java-datastore@1cbaf22)) </details> <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.46.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.46.0): 1.46.0 ##### Breaking Changes > \[!WARNING] > jnr-unixsocket is now an external dependency of dd-trace-ot and must be included when deploying dd-trace-ot. > \[!NOTE] > The API `TracerScope.setAsync(boolean)`, used to manually control asynchronous span propagation, does no more apply to the scope instance but to the active span scope. ##### Components ##### Application Security Management (IAST) - 🐛 Fix String.replace instrumentation for IAST ([#8281](DataDog/dd-trace-java#8281) - [@Mariovido](https://github.com/Mariovido)) - ✨ Apply the standard nomenclature to the stacktrace configs ([#8244](DataDog/dd-trace-java#8244) - [@jandro996](https://github.com/jandro996)) - 🐛 Exclude false positive weak randomness ([#8232](DataDog/dd-trace-java#8232) - [@jandro996](https://github.com/jandro996)) - ✨ Propagation of translateEscapes of String class ([#8186](DataDog/dd-trace-java#8186) - [@sezen-datadog](https://github.com/sezen-datadog)) - ✨ Add security control metrics ([#8175](DataDog/dd-trace-java#8175) - [@jandro996](https://github.com/jandro996)) - ✨ Increase IAST propagation to StringBuffer setLength ([#8128](DataDog/dd-trace-java#8128) - [@Mariovido](https://github.com/Mariovido)) - ✨ Add IAST taint tracking for DB values ([#8072](DataDog/dd-trace-java#8072) - [@Mariovido](https://github.com/Mariovido)) ##### Application Security Management (WAF) - 🐛 Prevents a NPE when there is no subscriber for user events ([#8258](DataDog/dd-trace-java#8258) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Apply the standard nomenclature to the stacktrace configs ([#8244](DataDog/dd-trace-java#8244) - [@jandro996](https://github.com/jandro996)) - 🐛 Ensure cached subscriptions are cleared on reconfiguration via RC ([#8229](DataDog/dd-trace-java#8229) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Add support for session tracking in Vertx ([#8167](DataDog/dd-trace-java#8167) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Create span tag: \_dd.appsec.rasp.timeout ([#8269](DataDog/dd-trace-java#8269) - [@Mariovido](https://github.com/Mariovido)) ##### Build & Tooling - 🐛 Ensure shaded helpers have unique names when injected into class-loaders ([#8192](DataDog/dd-trace-java#8192) - [@mcculls](https://github.com/mcculls)) ##### Configuration at Runtime - 🐛 Remove filtering of `DD_SERVICE` and `DD_ENV` from the tracer ([#8176](DataDog/dd-trace-java#8176) - [@mhlidd](https://github.com/mhlidd)) ##### Continuous Integration Visibility - 🧹 Generalize TestRetryPolicy to TestExecutionPolicy ([#8302](DataDog/dd-trace-java#8302) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Parallelize CI Visibility settings requests ([#8299](DataDog/dd-trace-java#8299) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Generalize test retry logic ([#8289](DataDog/dd-trace-java#8289) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Generalize tests skipping logic ([#8288](DataDog/dd-trace-java#8288) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Remove skip and shouldBeSkipped methods from TestEventsHandler in favor of isSkippable ([#8286](DataDog/dd-trace-java#8286) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨⚡ Optimize Git repository information computation ([#8270](DataDog/dd-trace-java#8270) - [@dougqh](https://github.com/dougqh)) - ✨ Always request known tests from the backend ([#8268](DataDog/dd-trace-java#8268) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Fix NPE when trying to get retry analyzer in Test NG ([#8253](DataDog/dd-trace-java#8253) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Set test framework and test framework version tags atomically ([#8252](DataDog/dd-trace-java#8252) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add debug logging to Android Gradle module layout logic ([#8251](DataDog/dd-trace-java#8251) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix source and destination folders computation for Android Gradle projects ([#8190](DataDog/dd-trace-java#8190) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add basic Scala Weaver sbt support ([#8189](DataDog/dd-trace-java#8189) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Implement impacted tests detection ([#8188](DataDog/dd-trace-java#8188) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) ##### Data Streams Monitoring - ✨ Change hash computation for protobuf to better represent impacting changes + save proto number in schema ([#8201](DataDog/dd-trace-java#8201) - [@vandonr](https://github.com/vandonr)) ##### Database Monitoring - Add peer service tag in dbm sql commenter ([#7913](DataDog/dd-trace-java#7913) - [@jordan-wong](https://github.com/jordan-wong)) ##### Dynamic Instrumentation - ✨ Add support for SymDB to scan directories ([#8306](DataDog/dd-trace-java#8306) - [@jpbempel](https://github.com/jpbempel)) - ✨ Add SymDB report for any jar scanning failures ([#8300](DataDog/dd-trace-java#8300) - [@jpbempel](https://github.com/jpbempel)) - ✨ Use two budgets depending on type ([#8283](DataDog/dd-trace-java#8283) - [@evanchooly](https://github.com/evanchooly)) - ✨ Institute a 10 snapshot per probe per trace budget ([#8277](DataDog/dd-trace-java#8277) - [@evanchooly](https://github.com/evanchooly)) - 🐛 Avoid double snapshots for Exception Replay ([#8273](DataDog/dd-trace-java#8273) - [@jpbempel](https://github.com/jpbempel)) - ✨ Simplify code origins. Separate out snapshot generation. ([#8263](DataDog/dd-trace-java#8263) - [@evanchooly](https://github.com/evanchooly)) - ✨ Add Exception probe custom instrumentation ([#8230](DataDog/dd-trace-java#8230) - [@jpbempel](https://github.com/jpbempel)) - ✨ Enhance log probes to honor debug session tags ([#8215](DataDog/dd-trace-java#8215) - [@evanchooly](https://github.com/evanchooly)) - 🐛 Don't redact env tokens from debugger probe snapshots ([#8211](DataDog/dd-trace-java#8211) - [@watson](https://github.com/watson)) - ✨⚡ Move Trace/SpanId capture at commit time ([#8184](DataDog/dd-trace-java#8184) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Capture values at entry for method probe ([#8169](DataDog/dd-trace-java#8169) - [@jpbempel](https://github.com/jpbempel)) ##### JMX fetch - 🐛 Mute JMXFetch Shutdown in progress error ([#8068](DataDog/dd-trace-java#8068) - [@ygree](https://github.com/ygree)) ##### OpenTracing - ⚠️🧹 Make jnr-unixsocket an explicit dependency of dd-trace-ot ([#8307](DataDog/dd-trace-java#8307) - [@mcculls](https://github.com/mcculls)) ##### Profiling - 🐛 Avoid unsupported API call for creating folders on windows ([#8304](DataDog/dd-trace-java#8304) - [@jbachorik](https://github.com/jbachorik)) - ✨ Tag profiles for serverless ([#8279](DataDog/dd-trace-java#8279) - [@jbachorik](https://github.com/jbachorik)) - ✨ add queue type and length to queue events ([#8242](DataDog/dd-trace-java#8242) - [@richardstartin](https://github.com/richardstartin)) - 🐛 TempLocationManager Fixes and Improvements ([#8191](DataDog/dd-trace-java#8191) - [@jbachorik](https://github.com/jbachorik)) - ✨ Bump ddprof to 1.18.0 ([#8173](DataDog/dd-trace-java#8173) - [@jbachorik](https://github.com/jbachorik)) - ✨ Report profiler initialization and configuration errors to telemetry ([#8171](DataDog/dd-trace-java#8171) - [@jbachorik](https://github.com/jbachorik)) ##### Telemetry - ✨ Add pending traces report in tracer flares ([#8053](DataDog/dd-trace-java#8053) - [@mhlidd](https://github.com/mhlidd)) ##### Testing - ✨ Test http server requests in parallel ([#8222](DataDog/dd-trace-java#8222) - [@amarziali](https://github.com/amarziali)) ##### Trace context propagation - ✨ Add non default propagator registration ([#8310](DataDog/dd-trace-java#8310) - [@PerfectSlayer](https://github.com/PerfectSlayer)) ##### Tracer core - ✨ Probe for existence of IBMSASL or ACCP security providers ([#8276](DataDog/dd-trace-java#8276) - [@mcculls](https://github.com/mcculls)) - ✨⚡ Overhead improvement to agent feedback based sampling ([#8265](DataDog/dd-trace-java#8265) - [@dougqh](https://github.com/dougqh)) - 🧹 Move async propagation API from scope to tracer ([#8231](DataDog/dd-trace-java#8231) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨ Introduce context propagation API ([#8161](DataDog/dd-trace-java#8161) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨🧪 Use env-entry to add tags per webapp deployment ([#8138](DataDog/dd-trace-java#8138) - [@amarziali](https://github.com/amarziali)) - ✨ Introduce context helpers API ([#8134](DataDog/dd-trace-java#8134) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨ Support IPv6 values for `DD_AGENT_HOST` and `DD_TRACE_AGENT_URL` ([#7984](DataDog/dd-trace-java#7984) - [@mhlidd](https://github.com/mhlidd)) ##### Instrumentations ##### Apache HttpComponents - 🐛 Properly finish spans and support latest apache httpclient5 ([#8272](DataDog/dd-trace-java#8272) - [@amarziali](https://github.com/amarziali)) ##### AWS Lambda instrumentation - 🐛 Properly capture lambda payloads for all handler types. ([#8264](DataDog/dd-trace-java#8264) - [@purple4reina](https://github.com/purple4reina)) ##### AWS S3 instrumentation - 💡 Create S3 instrumentation + add span pointers ([#8075](DataDog/dd-trace-java#8075) - [@nhulston](https://github.com/nhulston)) ##### AWS SDK instrumentation - 🐛 Revert "Add avoid double instrumenting lambda non-streaming handlers." ([#8247](DataDog/dd-trace-java#8247) - [@nhulston](https://github.com/nhulston)) ##### Cassandra - ✨ Allow extracting keyspace from statement result ([#8239](DataDog/dd-trace-java#8239) - [@amarziali](https://github.com/amarziali)) ##### Core Java language instrumentation - ✨ Propagation of translateEscapes of String class ([#8186](DataDog/dd-trace-java#8186) - [@sezen-datadog](https://github.com/sezen-datadog)) ##### Eclipse Vert.x instrumentation - 🐛 Fix vertx worker propagation and error handling ([#8237](DataDog/dd-trace-java#8237) - [@amarziali](https://github.com/amarziali)) - ✨ Support vertx 5 ([#8220](DataDog/dd-trace-java#8220) - [@amarziali](https://github.com/amarziali)) - ✨ Add support for session tracking in Vertx ([#8167](DataDog/dd-trace-java#8167) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) ##### Kafka instrumentation - 🐛 Prevent possible NPE calculating Kafka record header size ([#8292](DataDog/dd-trace-java#8292) - [@ygree](https://github.com/ygree)) ##### Mule instrumentation - 🐛 Fix crash using Mule with JPMS ([#8187](DataDog/dd-trace-java#8187) - [@amarziali](https://github.com/amarziali)) ##### Protocol Buffer instrumentation - ✨ Change hash computation for protobuf to better represent impacting changes + save proto number in schema ([#8201](DataDog/dd-trace-java#8201) - [@vandonr](https://github.com/vandonr)) ##### Spring instrumentation - 🐛 Preserve getQualifier from spring scheduling runnables ([#8293](DataDog/dd-trace-java#8293) - [@amarziali](https://github.com/amarziali)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: bb09d47e4eed77a003f630273b4d0a84003eb899

reverting env/service filtering in tracingconfigpoller

014bc0e

mhlidd changed the title ~~reverting env/service filtering in tracingconfigpoller~~ Remove filtering of DD_SERVICE and DD_ENV from the tracer Jan 10, 2025

mhlidd requested a review from lucaspimentel January 10, 2025 23:01

mhlidd mentioned this pull request Jan 14, 2025

[Java] Disable remote-config tests for setting DD_ENV and DD_SERVICE DataDog/system-tests#3818

Merged

7 tasks

lucaspimentel reviewed Jan 15, 2025

View reviewed changes

dd-trace-core/src/test/groovy/datadog/trace/core/CoreTracerTest.groovy Show resolved Hide resolved

mhlidd added 2 commits January 17, 2025 13:20

adding a unit test to verify filtering doesn't exist

bf5da72

updating test name

b07e2ea

mhlidd marked this pull request as ready for review January 17, 2025 18:22

mhlidd requested a review from a team as a code owner January 17, 2025 18:22

mhlidd requested review from nayeem-kamal and lucaspimentel January 17, 2025 18:22

mhlidd added type: bug comp: core Tracer core comp: remote config Configuration at Runtime and removed comp: core Tracer core labels Jan 17, 2025

lucaspimentel approved these changes Jan 17, 2025

View reviewed changes

Merge branch 'master' into mhlidd/remote_config_env

6e487ae

nayeem-kamal added type: bug and removed type: bug labels Jan 22, 2025

nayeem-kamal approved these changes Jan 22, 2025

View reviewed changes

mhlidd merged commit c527f13 into master Jan 22, 2025
172 of 175 checks passed

mhlidd deleted the mhlidd/remote_config_env branch January 22, 2025 18:35

github-actions bot added this to the 1.46.0 milestone Jan 22, 2025

mhlidd mentioned this pull request Jan 23, 2025

[Java] Updating Manifest for Remote Config Tests DataDog/system-tests#3886

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove filtering of `DD_SERVICE` and `DD_ENV` from the tracer #8176

Remove filtering of `DD_SERVICE` and `DD_ENV` from the tracer #8176

mhlidd commented Jan 9, 2025 •

edited by lucaspimentel

Loading

pr-commenter bot commented Jan 9, 2025 •

edited

Loading

github-actions bot commented Jan 17, 2025 •

edited

Loading

lucaspimentel left a comment

mhlidd commented Jan 21, 2025

Remove filtering of DD_SERVICE and DD_ENV from the tracer #8176

Remove filtering of DD_SERVICE and DD_ENV from the tracer #8176

Conversation

mhlidd commented Jan 9, 2025 • edited by lucaspimentel Loading

What Does This Do

Motivation

Additional Notes

Contributor Checklist

pr-commenter bot commented Jan 9, 2025 • edited Loading

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

github-actions bot commented Jan 17, 2025 • edited Loading

lucaspimentel left a comment

Choose a reason for hiding this comment

mhlidd commented Jan 21, 2025

Remove filtering of `DD_SERVICE` and `DD_ENV` from the tracer #8176

Remove filtering of `DD_SERVICE` and `DD_ENV` from the tracer #8176

mhlidd commented Jan 9, 2025 •

edited by lucaspimentel

Loading

pr-commenter bot commented Jan 9, 2025 •

edited

Loading

github-actions bot commented Jan 17, 2025 •

edited

Loading