Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] Disable remote-config tests for setting DD_ENV and DD_SERVICE #3818

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

mhlidd
Copy link
Contributor

@mhlidd mhlidd commented Jan 14, 2025

Motivation

This dd-trace-java PR reverts filtering of DD_SERVICE and DD_ENV. In order for the PR to continue, the tests expecting the removed behavior must be first disabled.

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@mhlidd mhlidd marked this pull request as ready for review January 15, 2025 15:23
@mhlidd mhlidd requested review from mabdinur and a team as code owners January 15, 2025 15:23
@mhlidd mhlidd requested a review from lucaspimentel January 15, 2025 15:23
@mhlidd mhlidd merged commit 8b05076 into main Jan 16, 2025
52 checks passed
@mhlidd mhlidd deleted the mhlidd/disable_remote_config_tests branch January 16, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants