Skip to content

add waiting hook in HttpServerTest to try to solve Pekko's flakiness #9493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vandonr merged 2 commits into from
Sep 10, 2025
Merged

add waiting hook in HttpServerTest to try to solve Pekko's flakiness #9493

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3bf9182
add waiting hook in HttpServerTest to try to solve Pekko's flakiness
vandonr Sep 8, 2025
776f779
Merge remote-tracking branch 'origin/master' into vandonr/fix2
vandonr Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions ...strumentation-testing/src/main/groovy/datadog/trace/agent/test/base/HttpServerTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,15 @@ abstract class HttpServerTest<SERVER> extends WithHttpServer<SERVER> {
}
}

/**
* Hook method to allow subclasses to wait for request processing to complete.
* This is particularly useful for asynchronous HTTP server implementations
* where spans may still not be closed after the HTTP response is sent.
*/
protected void waitForRequestToComplete() {
// Default implementation does nothing - override in subclasses as needed
}

// used in blocking tests to check if the handler was skipped
volatile boolean handlerRan

Expand Down Expand Up @@ -1195,6 +1204,8 @@ abstract class HttpServerTest<SERVER> extends WithHttpServer<SERVER> {
TEST_DATA_STREAMS_WRITER.waitForGroups(1)
}

waitForRequestToComplete()

expect:
response.code() == EXCEPTION.status
if (testExceptionBody()) {
Expand Down
15 changes: 15 additions & 0 deletions ...trumentation/pekko-http-1.0/src/baseTest/groovy/PekkoHttpServerInstrumentationTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,21 @@ abstract class PekkoHttpServerInstrumentationTest extends HttpServerTest<PekkoHt
true
}

@Override
protected void waitForRequestToComplete() {
// Pekko HTTP is asynchronous, and spans may not be completed
// immediately after the HTTP response is sent. Wait for the trace
// to be written to avoid race conditions in trace assertions.
try {
// Wait up to 1 sec for the trace to be written
TEST_WRITER.waitForTracesMax(1, 1)
} catch (InterruptedException e) {
Thread.currentThread().interrupt()
// If interrupted, proceed anyway - test may still pass
}
}


//@Ignore("https://github.com/DataDog/dd-trace-java/pull/5213")
@Override
boolean testBadUrl() {
Expand Down