-
Notifications
You must be signed in to change notification settings - Fork 324
add waiting hook in HttpServerTest to try to solve Pekko's flakiness #9493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🎯 Code Coverage 🔗 Commit SHA: 776f779 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 11 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~776f7796a3, baseline=1.54.0-SNAPSHOT~52c71a734d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.051 s) : 0, 1050516
Total [baseline] (8.685 s) : 0, 8685337
Agent [candidate] (1.05 s) : 0, 1050443
Total [candidate] (8.64 s) : 0, 8639858
section iast
Agent [baseline] (1.197 s) : 0, 1196934
Total [baseline] (9.463 s) : 0, 9463153
Agent [candidate] (1.185 s) : 0, 1185320
Total [candidate] (9.375 s) : 0, 9375220
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~776f7796a3, baseline=1.54.0-SNAPSHOT~52c71a734d
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.471 ms) : 0, 1471
crashtracking [candidate] (1.475 ms) : 0, 1475
BytebuddyAgent [baseline] (735.323 ms) : 0, 735323
BytebuddyAgent [candidate] (734.995 ms) : 0, 734995
GlobalTracer [baseline] (242.786 ms) : 0, 242786
GlobalTracer [candidate] (243.272 ms) : 0, 243272
AppSec [baseline] (30.296 ms) : 0, 30296
AppSec [candidate] (30.105 ms) : 0, 30105
Debugger [baseline] (6.467 ms) : 0, 6467
Debugger [candidate] (6.465 ms) : 0, 6465
Remote Config [baseline] (679.938 µs) : 0, 680
Remote Config [candidate] (676.346 µs) : 0, 676
Telemetry [baseline] (12.349 ms) : 0, 12349
Telemetry [candidate] (12.384 ms) : 0, 12384
section iast
crashtracking [baseline] (1.473 ms) : 0, 1473
crashtracking [candidate] (1.455 ms) : 0, 1455
BytebuddyAgent [baseline] (865.709 ms) : 0, 865709
BytebuddyAgent [candidate] (855.164 ms) : 0, 855164
GlobalTracer [baseline] (234.807 ms) : 0, 234807
GlobalTracer [candidate] (234.05 ms) : 0, 234050
AppSec [baseline] (26.888 ms) : 0, 26888
AppSec [candidate] (26.254 ms) : 0, 26254
Debugger [baseline] (7.083 ms) : 0, 7083
Debugger [candidate] (7.081 ms) : 0, 7081
Remote Config [baseline] (621.325 µs) : 0, 621
Remote Config [candidate] (627.616 µs) : 0, 628
Telemetry [baseline] (8.321 ms) : 0, 8321
Telemetry [candidate] (8.213 ms) : 0, 8213
IAST [baseline] (30.804 ms) : 0, 30804
IAST [candidate] (31.361 ms) : 0, 31361
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~776f7796a3, baseline=1.54.0-SNAPSHOT~52c71a734d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.044 s) : 0, 1043765
Total [baseline] (10.684 s) : 0, 10683974
Agent [candidate] (1.047 s) : 0, 1046862
Total [candidate] (10.779 s) : 0, 10779412
section appsec
Agent [baseline] (1.225 s) : 0, 1225112
Total [baseline] (10.849 s) : 0, 10848730
Agent [candidate] (1.225 s) : 0, 1225027
Total [candidate] (10.959 s) : 0, 10958693
section iast
Agent [baseline] (1.182 s) : 0, 1182300
Total [baseline] (10.969 s) : 0, 10969232
Agent [candidate] (1.18 s) : 0, 1180431
Total [candidate] (10.97 s) : 0, 10969850
section profiling
Agent [baseline] (1.203 s) : 0, 1203035
Total [baseline] (10.979 s) : 0, 10978965
Agent [candidate] (1.198 s) : 0, 1198448
Total [candidate] (10.865 s) : 0, 10865219
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~776f7796a3, baseline=1.54.0-SNAPSHOT~52c71a734d
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.442 ms) : 0, 1442
crashtracking [candidate] (1.451 ms) : 0, 1451
BytebuddyAgent [baseline] (731.557 ms) : 0, 731557
BytebuddyAgent [candidate] (732.34 ms) : 0, 732340
GlobalTracer [baseline] (242.454 ms) : 0, 242454
GlobalTracer [candidate] (242.426 ms) : 0, 242426
AppSec [baseline] (30.006 ms) : 0, 30006
AppSec [candidate] (30.136 ms) : 0, 30136
Debugger [baseline] (6.43 ms) : 0, 6430
Debugger [candidate] (6.411 ms) : 0, 6411
Remote Config [baseline] (678.22 µs) : 0, 678
Remote Config [candidate] (673.52 µs) : 0, 674
Telemetry [baseline] (10.106 ms) : 0, 10106
Telemetry [candidate] (12.218 ms) : 0, 12218
section appsec
crashtracking [baseline] (1.449 ms) : 0, 1449
crashtracking [candidate] (1.451 ms) : 0, 1451
BytebuddyAgent [baseline] (756.239 ms) : 0, 756239
BytebuddyAgent [candidate] (756.115 ms) : 0, 756115
GlobalTracer [baseline] (235.767 ms) : 0, 235767
GlobalTracer [candidate] (235.474 ms) : 0, 235474
IAST [baseline] (23.511 ms) : 0, 23511
IAST [candidate] (23.709 ms) : 0, 23709
AppSec [baseline] (170.296 ms) : 0, 170296
AppSec [candidate] (168.834 ms) : 0, 168834
Debugger [baseline] (6.781 ms) : 0, 6781
Debugger [candidate] (9.175 ms) : 0, 9175
Remote Config [baseline] (626.328 µs) : 0, 626
Remote Config [candidate] (624.108 µs) : 0, 624
Telemetry [baseline] (9.332 ms) : 0, 9332
Telemetry [candidate] (8.584 ms) : 0, 8584
section iast
crashtracking [baseline] (1.457 ms) : 0, 1457
crashtracking [candidate] (1.476 ms) : 0, 1476
BytebuddyAgent [baseline] (853.594 ms) : 0, 853594
BytebuddyAgent [candidate] (851.708 ms) : 0, 851708
GlobalTracer [baseline] (233.408 ms) : 0, 233408
GlobalTracer [candidate] (233.066 ms) : 0, 233066
IAST [baseline] (30.927 ms) : 0, 30927
IAST [candidate] (33.447 ms) : 0, 33447
AppSec [baseline] (25.956 ms) : 0, 25956
AppSec [candidate] (24.531 ms) : 0, 24531
Debugger [baseline] (7.029 ms) : 0, 7029
Debugger [candidate] (6.18 ms) : 0, 6180
Remote Config [baseline] (615.085 µs) : 0, 615
Remote Config [candidate] (617.741 µs) : 0, 618
Telemetry [baseline] (8.228 ms) : 0, 8228
Telemetry [candidate] (8.298 ms) : 0, 8298
section profiling
crashtracking [baseline] (1.426 ms) : 0, 1426
crashtracking [candidate] (1.435 ms) : 0, 1435
BytebuddyAgent [baseline] (764.403 ms) : 0, 764403
BytebuddyAgent [candidate] (761.578 ms) : 0, 761578
GlobalTracer [baseline] (224.347 ms) : 0, 224347
GlobalTracer [candidate] (222.725 ms) : 0, 222725
AppSec [baseline] (30.455 ms) : 0, 30455
AppSec [candidate] (30.589 ms) : 0, 30589
Debugger [baseline] (6.685 ms) : 0, 6685
Debugger [candidate] (6.604 ms) : 0, 6604
Remote Config [baseline] (715.349 µs) : 0, 715
Remote Config [candidate] (687.194 µs) : 0, 687
Telemetry [baseline] (16.524 ms) : 0, 16524
Telemetry [candidate] (16.2 ms) : 0, 16200
ProfilingAgent [baseline] (107.709 ms) : 0, 107709
ProfilingAgent [candidate] (107.936 ms) : 0, 107936
Profiling [baseline] (108.408 ms) : 0, 108408
Profiling [candidate] (108.633 ms) : 0, 108633
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 1 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~776f7796a3, baseline=1.54.0-SNAPSHOT~52c71a734d
dateFormat X
axisFormat %s
section baseline
no_agent (4.35 ms) : 4300, 4399
. : milestone, 4350,
iast (9.408 ms) : 9243, 9573
. : milestone, 9408,
iast_FULL (14.745 ms) : 14450, 15040
. : milestone, 14745,
iast_GLOBAL (10.305 ms) : 10122, 10487
. : milestone, 10305,
profiling (9.139 ms) : 8997, 9280
. : milestone, 9139,
tracing (8.082 ms) : 7955, 8208
. : milestone, 8082,
section candidate
no_agent (4.581 ms) : 4527, 4635
. : milestone, 4581,
iast (9.185 ms) : 9033, 9337
. : milestone, 9185,
iast_FULL (14.077 ms) : 13793, 14361
. : milestone, 14077,
iast_GLOBAL (10.467 ms) : 10282, 10651
. : milestone, 10467,
profiling (9.008 ms) : 8848, 9168
. : milestone, 9008,
tracing (7.659 ms) : 7549, 7768
. : milestone, 7659,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~776f7796a3, baseline=1.54.0-SNAPSHOT~52c71a734d
dateFormat X
axisFormat %s
section baseline
no_agent (35.796 ms) : 35500, 36092
. : milestone, 35796,
appsec (48.689 ms) : 48242, 49137
. : milestone, 48689,
code_origins (44.341 ms) : 43961, 44721
. : milestone, 44341,
iast (42.955 ms) : 42593, 43317
. : milestone, 42955,
profiling (48.818 ms) : 48340, 49296
. : milestone, 48818,
tracing (44.536 ms) : 44158, 44915
. : milestone, 44536,
section candidate
no_agent (35.841 ms) : 35545, 36136
. : milestone, 35841,
appsec (48.989 ms) : 48540, 49438
. : milestone, 48989,
code_origins (45.203 ms) : 44824, 45582
. : milestone, 45203,
iast (43.7 ms) : 43329, 44072
. : milestone, 43700,
profiling (48.904 ms) : 48463, 49345
. : milestone, 48904,
tracing (43.764 ms) : 43386, 44141
. : milestone, 43764,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~776f7796a3, baseline=1.54.0-SNAPSHOT~52c71a734d
dateFormat X
axisFormat %s
section baseline
no_agent (1.48 ms) : 1468, 1491
. : milestone, 1480,
appsec (3.678 ms) : 3459, 3897
. : milestone, 3678,
iast (2.204 ms) : 2141, 2267
. : milestone, 2204,
iast_GLOBAL (2.244 ms) : 2181, 2308
. : milestone, 2244,
profiling (2.051 ms) : 2000, 2102
. : milestone, 2051,
tracing (2.027 ms) : 1978, 2076
. : milestone, 2027,
section candidate
no_agent (1.481 ms) : 1469, 1493
. : milestone, 1481,
appsec (3.681 ms) : 3463, 3899
. : milestone, 3681,
iast (2.21 ms) : 2147, 2272
. : milestone, 2210,
iast_GLOBAL (2.255 ms) : 2191, 2319
. : milestone, 2255,
profiling (2.501 ms) : 2331, 2670
. : milestone, 2501,
tracing (2.022 ms) : 1973, 2071
. : milestone, 2022,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~776f7796a3, baseline=1.54.0-SNAPSHOT~52c71a734d
dateFormat X
axisFormat %s
section baseline
no_agent (15.224 s) : 15224000, 15224000
. : milestone, 15224000,
appsec (15.048 s) : 15048000, 15048000
. : milestone, 15048000,
iast (18.765 s) : 18765000, 18765000
. : milestone, 18765000,
iast_GLOBAL (17.873 s) : 17873000, 17873000
. : milestone, 17873000,
profiling (15.89 s) : 15890000, 15890000
. : milestone, 15890000,
tracing (14.972 s) : 14972000, 14972000
. : milestone, 14972000,
section candidate
no_agent (14.792 s) : 14792000, 14792000
. : milestone, 14792000,
appsec (14.955 s) : 14955000, 14955000
. : milestone, 14955000,
iast (18.663 s) : 18663000, 18663000
. : milestone, 18663000,
iast_GLOBAL (17.914 s) : 17914000, 17914000
. : milestone, 17914000,
profiling (15.305 s) : 15305000, 15305000
. : milestone, 15305000,
tracing (15.283 s) : 15283000, 15283000
. : milestone, 15283000,
|
What Does This Do
Pekko's tests are a big source of flakiness. One of the classes is marked as flaky, but this affects more this one. This is an attempt at fixing the flakiness by adding a hook to the base HTTP test.
Motivation
Additional Notes
relates to #9396
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]