Fixing pekko test: revert previous change and fix test server #9530

vandonr · 2025-09-15T09:56:37Z

What Does This Do

revert add waiting hook in HttpServerTest to try to solve Pekko's flakiness #9493
close span in the exception handling code in the test server

Motivation

honestly this is a bit beyond my comprehension, and AI helped me find this, but it seems there is a race condition in which handler gets to treat the exception, if it's the instrumentation handler things work fin, but if it's the test server handler, then the span is not finished. At least that's how I understand it.

Additional Notes

Pekko's instrumentation was submitted by an external contributor 2 years ago.

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, move, or deletion
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

…akiness (#9493)" This reverts commit 4644198.

datadog-official · 2025-09-15T10:04:43Z

🎯 Code Coverage
• Patch Coverage: 100.00%
• Total Coverage: 60.13% (-0.02%)

View detailed report

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: fc8d09b | Docs | Was this helpful? Give us feedback!}

pr-commenter · 2025-09-15T10:16:18Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	vandonr/fix
git_commit_date	1757929778	1757928618
git_commit_sha	1cdab0f050	`fc8d09b`
release_version	1.54.0-SNAPSHOT~81cdab0f050	1.54.0-SNAPSHOT~fc8d09bc7a

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1757931046	1757931046
ci_job_id	1128532351	1128532351
ci_pipeline_id	76449243	76449243
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-7dp7aqm7 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-7dp7aqm7 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 11 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~fc8d09bc7a, baseline=1.54.0-SNAPSHOT~81cdab0f050

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.063 s) : 0, 1062548
Total [baseline] (10.685 s) : 0, 10684724
Agent [candidate] (1.063 s) : 0, 1063320
Total [candidate] (10.67 s) : 0, 10669954
section appsec
Agent [baseline] (1.238 s) : 0, 1237710
Total [baseline] (10.974 s) : 0, 10973927
Agent [candidate] (1.237 s) : 0, 1237162
Total [candidate] (10.938 s) : 0, 10938222
section iast
Agent [baseline] (1.2 s) : 0, 1199616
Total [baseline] (11.087 s) : 0, 11087137
Agent [candidate] (1.202 s) : 0, 1202186
Total [candidate] (11.125 s) : 0, 11124778
section profiling
Agent [baseline] (1.219 s) : 0, 1219026
Total [baseline] (11.094 s) : 0, 11094139
Agent [candidate] (1.218 s) : 0, 1218388
Total [candidate] (11.043 s) : 0, 11043033

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.063 s	-
Agent	appsec	1.238 s	175.162 ms (16.5%)
Agent	iast	1.2 s	137.068 ms (12.9%)
Agent	profiling	1.219 s	156.478 ms (14.7%)
Total	tracing	10.685 s	-
Total	appsec	10.974 s	289.203 ms (2.7%)
Total	iast	11.087 s	402.413 ms (3.8%)
Total	profiling	11.094 s	409.415 ms (3.8%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.063 s	-
Agent	appsec	1.237 s	173.842 ms (16.3%)
Agent	iast	1.202 s	138.866 ms (13.1%)
Agent	profiling	1.218 s	155.068 ms (14.6%)
Total	tracing	10.67 s	-
Total	appsec	10.938 s	268.268 ms (2.5%)
Total	iast	11.125 s	454.824 ms (4.3%)
Total	profiling	11.043 s	373.079 ms (3.5%)

gantt
    title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~fc8d09bc7a, baseline=1.54.0-SNAPSHOT~81cdab0f050

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.458 ms) : 0, 1458
crashtracking [candidate] (1.455 ms) : 0, 1455
BytebuddyAgent [baseline] (733.183 ms) : 0, 733183
BytebuddyAgent [candidate] (733.522 ms) : 0, 733522
GlobalTracer [baseline] (252.736 ms) : 0, 252736
GlobalTracer [candidate] (252.992 ms) : 0, 252992
AppSec [baseline] (30.549 ms) : 0, 30549
AppSec [candidate] (30.638 ms) : 0, 30638
Debugger [baseline] (6.411 ms) : 0, 6411
Debugger [candidate] (6.353 ms) : 0, 6353
Remote Config [baseline] (702.284 µs) : 0, 702
Remote Config [candidate] (695.307 µs) : 0, 695
Telemetry [baseline] (16.4 ms) : 0, 16400
Telemetry [candidate] (16.418 ms) : 0, 16418
section appsec
crashtracking [baseline] (1.466 ms) : 0, 1466
crashtracking [candidate] (1.456 ms) : 0, 1456
BytebuddyAgent [baseline] (757.681 ms) : 0, 757681
BytebuddyAgent [candidate] (757.272 ms) : 0, 757272
GlobalTracer [baseline] (246.266 ms) : 0, 246266
GlobalTracer [candidate] (246.283 ms) : 0, 246283
AppSec [baseline] (170.408 ms) : 0, 170408
AppSec [candidate] (171.981 ms) : 0, 171981
Debugger [baseline] (6.832 ms) : 0, 6832
Debugger [candidate] (5.992 ms) : 0, 5992
Remote Config [baseline] (639.214 µs) : 0, 639
Remote Config [candidate] (635.031 µs) : 0, 635
Telemetry [baseline] (9.196 ms) : 0, 9196
Telemetry [candidate] (8.442 ms) : 0, 8442
IAST [baseline] (23.868 ms) : 0, 23868
IAST [candidate] (23.839 ms) : 0, 23839
section iast
crashtracking [baseline] (1.476 ms) : 0, 1476
crashtracking [candidate] (1.485 ms) : 0, 1485
BytebuddyAgent [baseline] (859.104 ms) : 0, 859104
BytebuddyAgent [candidate] (861.475 ms) : 0, 861475
GlobalTracer [baseline] (248.056 ms) : 0, 248056
GlobalTracer [candidate] (248.788 ms) : 0, 248788
AppSec [baseline] (25.745 ms) : 0, 25745
AppSec [candidate] (26.596 ms) : 0, 26596
Debugger [baseline] (6.11 ms) : 0, 6110
Debugger [candidate] (6.086 ms) : 0, 6086
Remote Config [baseline] (605.939 µs) : 0, 606
Remote Config [candidate] (617.126 µs) : 0, 617
Telemetry [baseline] (8.281 ms) : 0, 8281
Telemetry [candidate] (8.357 ms) : 0, 8357
IAST [baseline] (29.043 ms) : 0, 29043
IAST [candidate] (27.532 ms) : 0, 27532
section profiling
ProfilingAgent [baseline] (107.863 ms) : 0, 107863
ProfilingAgent [candidate] (109.413 ms) : 0, 109413
crashtracking [baseline] (1.447 ms) : 0, 1447
crashtracking [candidate] (1.472 ms) : 0, 1472
BytebuddyAgent [baseline] (768.227 ms) : 0, 768227
BytebuddyAgent [candidate] (767.56 ms) : 0, 767560
GlobalTracer [baseline] (235.345 ms) : 0, 235345
GlobalTracer [candidate] (234.285 ms) : 0, 234285
AppSec [baseline] (30.628 ms) : 0, 30628
AppSec [candidate] (31.131 ms) : 0, 31131
Debugger [baseline] (7.485 ms) : 0, 7485
Debugger [candidate] (7.484 ms) : 0, 7484
Remote Config [baseline] (746.023 µs) : 0, 746
Remote Config [candidate] (719.69 µs) : 0, 720
Telemetry [baseline] (15.848 ms) : 0, 15848
Telemetry [candidate] (14.898 ms) : 0, 14898
Profiling [baseline] (108.528 ms) : 0, 108528
Profiling [candidate] (110.077 ms) : 0, 110077

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~fc8d09bc7a, baseline=1.54.0-SNAPSHOT~81cdab0f050

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.059 s) : 0, 1059430
Total [baseline] (8.652 s) : 0, 8652281
Agent [candidate] (1.063 s) : 0, 1062824
Total [candidate] (8.663 s) : 0, 8662672
section iast
Agent [baseline] (1.195 s) : 0, 1195178
Total [baseline] (9.307 s) : 0, 9307195
Agent [candidate] (1.193 s) : 0, 1192739
Total [candidate] (9.357 s) : 0, 9357165

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.059 s	-
Agent	iast	1.195 s	135.748 ms (12.8%)
Total	tracing	8.652 s	-
Total	iast	9.307 s	654.914 ms (7.6%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.063 s	-
Agent	iast	1.193 s	129.915 ms (12.2%)
Total	tracing	8.663 s	-
Total	iast	9.357 s	694.492 ms (8.0%)

gantt
    title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~fc8d09bc7a, baseline=1.54.0-SNAPSHOT~81cdab0f050

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.457 ms) : 0, 1457
crashtracking [candidate] (1.449 ms) : 0, 1449
BytebuddyAgent [baseline] (731.339 ms) : 0, 731339
BytebuddyAgent [candidate] (733.86 ms) : 0, 733860
GlobalTracer [baseline] (251.922 ms) : 0, 251922
GlobalTracer [candidate] (252.898 ms) : 0, 252898
AppSec [baseline] (30.523 ms) : 0, 30523
AppSec [candidate] (30.549 ms) : 0, 30549
Debugger [baseline] (6.414 ms) : 0, 6414
Debugger [candidate] (6.391 ms) : 0, 6391
Remote Config [baseline] (697.265 µs) : 0, 697
Remote Config [candidate] (687.351 µs) : 0, 687
Telemetry [baseline] (16.05 ms) : 0, 16050
Telemetry [candidate] (15.948 ms) : 0, 15948
section iast
crashtracking [baseline] (1.47 ms) : 0, 1470
crashtracking [candidate] (1.456 ms) : 0, 1456
BytebuddyAgent [baseline] (855.39 ms) : 0, 855390
BytebuddyAgent [candidate] (852.108 ms) : 0, 852108
GlobalTracer [baseline] (245.106 ms) : 0, 245106
GlobalTracer [candidate] (246.229 ms) : 0, 246229
AppSec [baseline] (26.547 ms) : 0, 26547
AppSec [candidate] (27.692 ms) : 0, 27692
Debugger [baseline] (6.119 ms) : 0, 6119
Debugger [candidate] (6.95 ms) : 0, 6950
Remote Config [baseline] (613.032 µs) : 0, 613
Remote Config [candidate] (603.378 µs) : 0, 603
Telemetry [baseline] (8.224 ms) : 0, 8224
Telemetry [candidate] (8.282 ms) : 0, 8282
IAST [baseline] (30.657 ms) : 0, 30657
IAST [candidate] (28.401 ms) : 0, 28401

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	vandonr/fix
git_commit_date	1757929856	1757928618
git_commit_sha	1cdab0f050	`fc8d09b`
release_version	1.54.0-SNAPSHOT~81cdab0f050	1.54.0-SNAPSHOT~fc8d09bc7a

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1757930785	1757930785
ci_job_id	1128532352	1128532352
ci_pipeline_id	76449243	76449243
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-1-nuzhzpx5 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-1-nuzhzpx5 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 2 performance improvements and 2 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:insecure-bank:no_agent:high_load	worse [+165.347µs; +277.648µs] or [+3.874%; +6.504%]	unstable [-177.062op/s; +73.374op/s] or [-16.476%; +6.828%]	4.490ms	1022.812op/s	4.269ms	1074.656op/s
scenario:load:insecure-bank:iast_GLOBAL:high_load	better [-659.577µs; -243.804µs] or [-6.152%; -2.274%]	unstable [-36.539op/s; +74.602op/s] or [-8.429%; +17.209%]	10.270ms	452.531op/s	10.722ms	433.500op/s
scenario:load:insecure-bank:iast_FULL:high_load	better [-934.174µs; -319.478µs] or [-6.408%; -2.192%]	unstable [-25.193op/s; +53.505op/s] or [-7.878%; +16.732%]	13.951ms	333.938op/s	14.578ms	319.781op/s
scenario:load:petclinic:appsec:high_load	worse [+1.743ms; +2.682ms] or [+3.600%; +5.541%]	unstable [-11.265op/s; +2.840op/s] or [-11.648%; +2.937%]	50.618ms	92.500op/s	48.405ms	96.713op/s

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~fc8d09bc7a, baseline=1.54.0-SNAPSHOT~81cdab0f050
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.269 ms) : 4221, 4316
.   : milestone, 4269,
iast (9.533 ms) : 9377, 9690
.   : milestone, 9533,
iast_FULL (14.578 ms) : 14288, 14868
.   : milestone, 14578,
iast_GLOBAL (10.722 ms) : 10518, 10925
.   : milestone, 10722,
profiling (8.977 ms) : 8826, 9128
.   : milestone, 8977,
tracing (7.547 ms) : 7439, 7655
.   : milestone, 7547,
section candidate
no_agent (4.49 ms) : 4434, 4547
.   : milestone, 4490,
iast (9.757 ms) : 9588, 9925
.   : milestone, 9757,
iast_FULL (13.951 ms) : 13670, 14232
.   : milestone, 13951,
iast_GLOBAL (10.27 ms) : 10088, 10452
.   : milestone, 10270,
profiling (8.817 ms) : 8672, 8962
.   : milestone, 8817,
tracing (7.574 ms) : 7466, 7681
.   : milestone, 7574,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.269 ms [4.221 ms, 4.316 ms]	-
iast	9.533 ms [9.377 ms, 9.69 ms]	5.265 ms (123.3%)
iast_FULL	14.578 ms [14.288 ms, 14.868 ms]	10.309 ms (241.5%)
iast_GLOBAL	10.722 ms [10.518 ms, 10.925 ms]	6.453 ms (151.2%)
profiling	8.977 ms [8.826 ms, 9.128 ms]	4.708 ms (110.3%)
tracing	7.547 ms [7.439 ms, 7.655 ms]	3.278 ms (76.8%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.49 ms [4.434 ms, 4.547 ms]	-
iast	9.757 ms [9.588 ms, 9.925 ms]	5.266 ms (117.3%)
iast_FULL	13.951 ms [13.67 ms, 14.232 ms]	9.461 ms (210.7%)
iast_GLOBAL	10.27 ms [10.088 ms, 10.452 ms]	5.78 ms (128.7%)
profiling	8.817 ms [8.672 ms, 8.962 ms]	4.327 ms (96.4%)
tracing	7.574 ms [7.466 ms, 7.681 ms]	3.084 ms (68.7%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~fc8d09bc7a, baseline=1.54.0-SNAPSHOT~81cdab0f050
    dateFormat X
    axisFormat %s
section baseline
no_agent (36.799 ms) : 36503, 37095
.   : milestone, 36799,
appsec (48.405 ms) : 47972, 48839
.   : milestone, 48405,
code_origins (45.108 ms) : 44720, 45496
.   : milestone, 45108,
iast (43.359 ms) : 42986, 43732
.   : milestone, 43359,
profiling (48.119 ms) : 47641, 48596
.   : milestone, 48119,
tracing (42.99 ms) : 42626, 43354
.   : milestone, 42990,
section candidate
no_agent (37.73 ms) : 37422, 38038
.   : milestone, 37730,
appsec (50.618 ms) : 50178, 51058
.   : milestone, 50618,
code_origins (45.605 ms) : 45224, 45985
.   : milestone, 45605,
iast (43.223 ms) : 42864, 43582
.   : milestone, 43223,
profiling (47.334 ms) : 46898, 47769
.   : milestone, 47334,
tracing (43.792 ms) : 43418, 44167
.   : milestone, 43792,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	36.799 ms [36.503 ms, 37.095 ms]	-
appsec	48.405 ms [47.972 ms, 48.839 ms]	11.606 ms (31.5%)
code_origins	45.108 ms [44.72 ms, 45.496 ms]	8.309 ms (22.6%)
iast	43.359 ms [42.986 ms, 43.732 ms]	6.56 ms (17.8%)
profiling	48.119 ms [47.641 ms, 48.596 ms]	11.32 ms (30.8%)
tracing	42.99 ms [42.626 ms, 43.354 ms]	6.191 ms (16.8%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	37.73 ms [37.422 ms, 38.038 ms]	-
appsec	50.618 ms [50.178 ms, 51.058 ms]	12.888 ms (34.2%)
code_origins	45.605 ms [45.224 ms, 45.985 ms]	7.875 ms (20.9%)
iast	43.223 ms [42.864 ms, 43.582 ms]	5.493 ms (14.6%)
profiling	47.334 ms [46.898 ms, 47.769 ms]	9.604 ms (25.5%)
tracing	43.792 ms [43.418 ms, 44.167 ms]	6.062 ms (16.1%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	vandonr/fix
git_commit_date	1757929854	1757928618
git_commit_sha	1cdab0f050	`fc8d09b`
release_version	1.54.0-SNAPSHOT~81cdab0f050	1.54.0-SNAPSHOT~fc8d09bc7a

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1757931280	1757931280
ci_job_id	1128532353	1128532353
ci_pipeline_id	76449243	76449243
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-2-d4d903fq 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-2-d4d903fq 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~fc8d09bc7a, baseline=1.54.0-SNAPSHOT~81cdab0f050
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.414 s) : 15414000, 15414000
.   : milestone, 15414000,
appsec (15.009 s) : 15009000, 15009000
.   : milestone, 15009000,
iast (18.513 s) : 18513000, 18513000
.   : milestone, 18513000,
iast_GLOBAL (18.218 s) : 18218000, 18218000
.   : milestone, 18218000,
profiling (16.034 s) : 16034000, 16034000
.   : milestone, 16034000,
tracing (15.12 s) : 15120000, 15120000
.   : milestone, 15120000,
section candidate
no_agent (15.295 s) : 15295000, 15295000
.   : milestone, 15295000,
appsec (15.031 s) : 15031000, 15031000
.   : milestone, 15031000,
iast (18.212 s) : 18212000, 18212000
.   : milestone, 18212000,
iast_GLOBAL (18.055 s) : 18055000, 18055000
.   : milestone, 18055000,
profiling (15.244 s) : 15244000, 15244000
.   : milestone, 15244000,
tracing (15.001 s) : 15001000, 15001000
.   : milestone, 15001000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.414 s [15.414 s, 15.414 s]	-
appsec	15.009 s [15.009 s, 15.009 s]	-405.0 ms (-2.6%)
iast	18.513 s [18.513 s, 18.513 s]	3.099 s (20.1%)
iast_GLOBAL	18.218 s [18.218 s, 18.218 s]	2.804 s (18.2%)
profiling	16.034 s [16.034 s, 16.034 s]	620.0 ms (4.0%)
tracing	15.12 s [15.12 s, 15.12 s]	-294.0 ms (-1.9%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.295 s [15.295 s, 15.295 s]	-
appsec	15.031 s [15.031 s, 15.031 s]	-264.0 ms (-1.7%)
iast	18.212 s [18.212 s, 18.212 s]	2.917 s (19.1%)
iast_GLOBAL	18.055 s [18.055 s, 18.055 s]	2.76 s (18.0%)
profiling	15.244 s [15.244 s, 15.244 s]	-51.0 ms (-0.3%)
tracing	15.001 s [15.001 s, 15.001 s]	-294.0 ms (-1.9%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~fc8d09bc7a, baseline=1.54.0-SNAPSHOT~81cdab0f050
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.483 ms) : 1471, 1494
.   : milestone, 1483,
appsec (3.741 ms) : 3517, 3965
.   : milestone, 3741,
iast (2.205 ms) : 2142, 2268
.   : milestone, 2205,
iast_GLOBAL (2.253 ms) : 2190, 2317
.   : milestone, 2253,
profiling (2.074 ms) : 2022, 2126
.   : milestone, 2074,
tracing (2.031 ms) : 1982, 2080
.   : milestone, 2031,
section candidate
no_agent (1.486 ms) : 1474, 1497
.   : milestone, 1486,
appsec (3.719 ms) : 3500, 3938
.   : milestone, 3719,
iast (2.211 ms) : 2147, 2274
.   : milestone, 2211,
iast_GLOBAL (2.262 ms) : 2199, 2325
.   : milestone, 2262,
profiling (2.036 ms) : 1986, 2087
.   : milestone, 2036,
tracing (2.038 ms) : 1989, 2088
.   : milestone, 2038,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.483 ms [1.471 ms, 1.494 ms]	-
appsec	3.741 ms [3.517 ms, 3.965 ms]	2.258 ms (152.3%)
iast	2.205 ms [2.142 ms, 2.268 ms]	722.529 µs (48.7%)
iast_GLOBAL	2.253 ms [2.19 ms, 2.317 ms]	770.57 µs (52.0%)
profiling	2.074 ms [2.022 ms, 2.126 ms]	590.965 µs (39.9%)
tracing	2.031 ms [1.982 ms, 2.08 ms]	548.328 µs (37.0%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.486 ms [1.474 ms, 1.497 ms]	-
appsec	3.719 ms [3.5 ms, 3.938 ms]	2.233 ms (150.3%)
iast	2.211 ms [2.147 ms, 2.274 ms]	724.943 µs (48.8%)
iast_GLOBAL	2.262 ms [2.199 ms, 2.325 ms]	776.423 µs (52.3%)
profiling	2.036 ms [1.986 ms, 2.087 ms]	550.909 µs (37.1%)
tracing	2.038 ms [1.989 ms, 2.088 ms]	552.664 µs (37.2%)

manuel-alvarez-alvarez

LGTM

vandonr added 2 commits September 15, 2025 11:29

Revert "add waiting hook in HttpServerTest to try to solve Pekko's fl…

e541864

…akiness (#9493)" This reverts commit 4644198.

close span on exception handling in pekko test server

fc8d09b

vandonr requested review from a team as code owners September 15, 2025 09:56

vandonr added comp: testing Testing tag: no release notes Changes to exclude from release notes labels Sep 15, 2025

vandonr requested a review from manuel-alvarez-alvarez September 15, 2025 09:56

vandonr added the type: refactoring label Sep 15, 2025

manuel-alvarez-alvarez approved these changes Sep 19, 2025

View reviewed changes

vandonr merged commit abb87ab into master Sep 19, 2025
501 checks passed

vandonr deleted the vandonr/fix branch September 19, 2025 12:53

github-actions bot added this to the 1.54.0 milestone Sep 19, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fixing pekko test: revert previous change and fix test server #9530

Fixing pekko test: revert previous change and fix test server #9530

Uh oh!

vandonr commented Sep 15, 2025

Uh oh!

datadog-official bot commented Sep 15, 2025 •

edited

Loading

Uh oh!

pr-commenter bot commented Sep 15, 2025

Uh oh!

manuel-alvarez-alvarez left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Fixing pekko test: revert previous change and fix test server #9530

Fixing pekko test: revert previous change and fix test server #9530

Uh oh!

Conversation

vandonr commented Sep 15, 2025

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

datadog-official bot commented Sep 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pr-commenter bot commented Sep 15, 2025

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

manuel-alvarez-alvarez left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

datadog-official bot commented Sep 15, 2025 •

edited

Loading