Set up CI with Azure Pipelines #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![azure-pipelines[bot]](https://avatars.githubusercontent.com/in/9426?s=60&v=4){kind=small}
rochdev
force-pushed
the
azure-pipelines
branch
from
3bbb18e
to
ef328bf
Compare
Closed
brettlangdon
previously approved these changes
Nov 15, 2018
| - build-node-6 | ||
| - build-node-8 | ||
| - build-node-latest | ||
| - node-leaks |
There was a problem hiding this comment.
What we did in Python:
jobs:
- lint
- node-leaks
requires:
lintIt kind of sucks to setup, but is nice since we don't run all the parallelized jobs until linting passes.
Doesn't happen often though, so... probably didn't save much compute effort.
There was a problem hiding this comment.
It's an optimization that I'm thinking of doing mostly if the cost becomes to great. Otherwise it would slow down the entire build since this job would run in sequence.
src/instrumenter.js
Outdated
| @@ -77,10 +78,16 @@ class Instrumenter { | |||
| } | |||
|
|
|||
| hookModule (moduleExports, moduleName, moduleBaseDir) { | |||
| moduleName = moduleName.replace(new RegExp(`\\${path.sep}`, 'g'), '/') | |||
There was a problem hiding this comment.
Would you gain any benefits from defining this RegExp once globally?
| @@ -7,6 +7,8 @@ const shimmer = require('shimmer') | |||
| const uniq = require('lodash.uniq') | |||
| const log = require('./log') | |||
|
|
|||
| const pathSepExpr = new RegExp(`\\${path.sep}`, 'g') | |||
brettlangdon
approved these changes
Nov 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Windows and splits plugin tests in multiple jobs. It also addresses a lot of technical debt related to the build in general.
Fixes #354