Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry span metrics #5298

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Telemetry span metrics #5298

wants to merge 7 commits into from

Conversation

IlyasShabi
Copy link
Contributor

@IlyasShabi IlyasShabi commented Feb 19, 2025

What does this PR do?

  • Split telemetry folder into multiple files (rasp, waf, user)

Motivation

APPSEC-56393

Plugin Checklist

Additional Notes

Copy link

github-actions bot commented Feb 19, 2025

Overall package size

Self size: 8.76 MB
Deduped: 94.97 MB
No deduping: 95.49 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.5.0 | 19.26 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 835.4 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Feb 19, 2025

Datadog Report

Branch report: telemetry-span-metrics
Commit report: 76ac497
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 669 Passed, 0 Skipped, 16m 29.56s Total Time

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 47.96380% with 115 lines in your changes missing coverage. Please review.

Project coverage is 76.48%. Comparing base (be5ecaf) to head (28ca64d).

Files with missing lines Patch % Lines
packages/dd-trace/src/appsec/telemetry/waf.js 26.98% 46 Missing ⚠️
packages/dd-trace/src/appsec/telemetry/rasp.js 29.03% 22 Missing ⚠️
packages/dd-trace/src/appsec/telemetry/index.js 65.11% 15 Missing ⚠️
packages/dd-trace/src/appsec/blocking.js 52.63% 9 Missing ⚠️
packages/dd-trace/src/appsec/reporter.js 56.25% 7 Missing ⚠️
...ges/dd-trace/src/appsec/waf/waf_context_wrapper.js 77.41% 7 Missing ⚠️
packages/dd-trace/src/appsec/waf/waf_manager.js 33.33% 6 Missing ⚠️
packages/dd-trace/src/appsec/telemetry/user.js 60.00% 2 Missing ⚠️
packages/dd-trace/src/appsec/telemetry/common.js 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5298      +/-   ##
==========================================
- Coverage   80.91%   76.48%   -4.44%     
==========================================
  Files         488      492       +4     
  Lines       21817    21932     +115     
==========================================
- Hits        17654    16775     -879     
- Misses       4163     5157     +994     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Feb 19, 2025

Benchmarks

Benchmark execution time: 2025-02-19 16:16:08

Comparing candidate commit 28ca64d in PR branch telemetry-span-metrics with baseline commit be5ecaf in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 914 metrics, 19 unstable metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant