fix(appsec): ddtrace.ext.SpanTypes not an Enum (#3220)

Update from #3192 given new code added by #3027.
DataDog · Feb 10, 2022 · a8f2fa8 · a8f2fa8
1 parent 545ffc7
commit a8f2fa8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/ddtrace/appsec/processor.py b/ddtrace/appsec/processor.py
@@ -74,7 +74,7 @@ def on_span_start(self, span):
 
  def on_span_finish(self, span):
  # type: (Span) -> None
- if span.span_type != SpanTypes.WEB.value:
+ if span.span_type != SpanTypes.WEB:
  return
  span.set_metric("_dd.appsec.enabled", 1.0)
  span._set_str_tag("_dd.runtime_family", "python")

diff --git a/tests/appsec/test_processor.py b/tests/appsec/test_processor.py
@@ -18,7 +18,7 @@
 
 def test_enable(tracer):
  tracer._initialize_span_processors(appsec_enabled=True)
- with tracer.trace("test", span_type=SpanTypes.WEB.value) as span:
+ with tracer.trace("test", span_type=SpanTypes.WEB) as span:
  span.set_tag("http.url", "http://example.com/.git")
  span.set_tag("http.status_code", "404")
 
@@ -48,7 +48,7 @@ def test_enable_bad_rules(rule, exc, tracer):
 def test_retain_traces(tracer):
  tracer._initialize_span_processors(appsec_enabled=True)
 
- with tracer.trace("test", span_type=SpanTypes.WEB.value) as span:
+ with tracer.trace("test", span_type=SpanTypes.WEB) as span:
  span.set_tag("http.url", "http://example.com/.git")
  span.set_tag("http.status_code", "404")
 
@@ -58,7 +58,7 @@ def test_retain_traces(tracer):
 def test_valid_json(tracer):
  tracer._initialize_span_processors(appsec_enabled=True)
 
- with tracer.trace("test", span_type=SpanTypes.WEB.value) as span:
+ with tracer.trace("test", span_type=SpanTypes.WEB) as span:
  span.set_tag("http.url", "http://example.com/.git")
  span.set_tag("http.status_code", "404")