feat(appsec): ddwaf extension #3027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nizox
force-pushed
the
nicolas.vivet/external-shared-lib-ddwaf
branch
from
bdfb834
to
87a0b14
Compare
This reverts commit 021ad0e.
|
@nizox this pull request is now in conflict 😩 |
…b-ddwaf' into nicolas.vivet/external-shared-lib-ddwaf
brettlangdon
approved these changes
Feb 1, 2022
Kyle-Verhoog
approved these changes
Feb 1, 2022
|
Thanks a lot for the reviews @brettlangdon and @Kyle-Verhoog ! Is there anything else I need to fix? |
Nope! As long as CI passes, this will automerge. If we have a flaky test we can rerun the failed tests, but otherwise nothing else needed from me. |
|
@brettlangdon seems we did not sign all commits :( do you prefer we amend them with signatures or do you think you could admin-merge this? |
|
@Mergifyio refresh |
✅ Pull request refreshed |
brettlangdon
changed the title
brettlangdon
changed the title
mabdinur
pushed a commit
that referenced
this pull request
Feb 4, 2022
This PR adds an extension for [libddwaf](https://github.com/DataDog/libddwaf) and a minimal AppSec module. ddwaf is a C++ extension built using cython and linked statically with the libddwaf library that is itself built with cmake. As a result, a C++ compiler, cmake, ninja and git are now required to build ddtrace from source. We except most users to install ddtrace using binary wheels, so they should not notice this change. However, any errors during the compilation of this extension is ignored for now in order to avoid installation failures. The AppSec module is disabled by default and can be enabled using the `DD_APPSEC_ENABLED` environment variable. It consists of a single processor subscribing to web spans and detecting common web scanners on 404 HTTP responses.
brettlangdon
pushed a commit
that referenced
this pull request
Feb 8, 2022
brettlangdon
pushed a commit
that referenced
this pull request
Feb 9, 2022
majorgreys
added a commit
that referenced
this pull request
Feb 10, 2022
majorgreys
added a commit
that referenced
this pull request
Feb 10, 2022
majorgreys
added a commit
that referenced
this pull request
Feb 15, 2022
majorgreys
added a commit
that referenced
this pull request
Feb 16, 2022
majorgreys
added a commit
that referenced
this pull request
Feb 17, 2022
majorgreys
added a commit
that referenced
this pull request
Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an extension for libddwaf and a minimal AppSec module.
ddwaf is a C++ extension built using cython and linked statically with the libddwaf library that is itself built with cmake. As a result, a C++ compiler, cmake, ninja and git are now required to build ddtrace from source. We except most users to install ddtrace using binary wheels, so they should not notice this change.
The AppSec module is disabled by default and can be enabled using the
DD_APPSEC_ENABLEDenvironment variable. It consists of a single processor subscribing to web spans and detecting common web scanners on 404 HTTP responses.