fix(docs): use pip to build the readthedocs #3225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettlangdon
reviewed
Feb 4, 2022
this is why it's still in draft, going to test it and confirm |
|
Seems to have worked! https://readthedocs.org/projects/dd-trace-py-test/builds/15990961/ |
Kyle-Verhoog
added
the
changelog/no-changelog
P403n1x87
approved these changes
Feb 7, 2022
majorgreys
approved these changes
Feb 7, 2022
Codecov Report
@@ Coverage Diff @@
## master #3225 +/- ##
=======================================
Coverage 78.85% 78.85%
=======================================
Files 647 647
Lines 46945 46945
=======================================
Hits 37018 37018
Misses 9927 9927 Continue to review full report at Codecov.
|
|
Looks like we're good
|
mabdinur
pushed a commit
that referenced
this pull request
Feb 8, 2022
Co-authored-by: Gabriele N. Tornetta <P403n1x87@users.noreply.github.com> Co-authored-by: Tahir H. Butt <tahir.butt@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs build was broken in #3027 due to needing additional dependencies like
ninjaandcmakeand readthedocs not supporting custom build runners.Particularly the
python setup.py build --forcecommand fails (which also does for me locally).