Skip to content

chore: add traceback info to the failed to send message [backport 3.10] #14353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2025
Merged

chore: add traceback info to the failed to send message [backport 3.10] #14353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ddtrace/internal/writer/writer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,6 +406,7 @@ def _flush_queue_with_client(self, client: WriterClientBase, raise_exc: bool = F
n_traces,
self._intake_endpoint(client),
self.RETRY_ATTEMPTS,
exc_info=True,
)
finally:
self._metrics_dist("http.sent.bytes", len(encoded))
Expand Down
2 changes: 2 additions & 0 deletions tests/integration/test_integration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ def test_uds_wrong_socket_path():
1,
"unix:///tmp/ddagent/nosockethere/{}/traces".format(encoding if encoding else "v0.5"),
3,
exc_info=True,
)
]
log.error.assert_has_calls(calls)
Expand Down Expand Up @@ -356,6 +357,7 @@ def test_trace_generates_error_logs_when_trace_agent_url_invalid():
1,
"http://localhost:8125/{}/traces".format(encoding if encoding else "v0.5"),
3,
exc_info=True,
)
]
log.error.assert_has_calls(calls)
Expand Down
Loading