Skip to content

Conversation

@juanjux
Copy link
Collaborator

@juanjux juanjux commented Aug 19, 2025

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

- [X] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
(cherry picked from commit b4088d7)
@juanjux juanjux requested a review from a team as a code owner August 19, 2025 14:00
@juanjux juanjux requested a review from emmettbutler August 19, 2025 14:00
@juanjux juanjux changed the title fix(llmobs): fix span linking for langgraph nodes [backport 3.10] chore: add traceback info to the failed to send message [backport 3.10] Aug 19, 2025
@github-actions
Copy link
Contributor

CODEOWNERS have been resolved as:

ddtrace/internal/writer/writer.py                                       @DataDog/apm-core-python
tests/integration/test_integration.py                                   @DataDog/apm-core-python

@juanjux juanjux added the changelog/no-changelog A changelog entry is not required for this PR. label Aug 19, 2025
@juanjux juanjux self-assigned this Aug 19, 2025
@juanjux juanjux requested a review from brettlangdon August 19, 2025 14:10
@github-actions
Copy link
Contributor

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 278 ± 3 ms.

The average import time from base is: 279 ± 3 ms.

The import time difference between this PR and base is: -1.4 ± 0.1 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 1.897 ms (0.68%)
ddtrace.bootstrap.sitecustomize 1.223 ms (0.44%)
ddtrace.bootstrap.preload 1.223 ms (0.44%)
ddtrace.internal.remoteconfig.client 0.631 ms (0.23%)
ddtrace 0.674 ms (0.24%)
ddtrace.internal._unpatched 0.030 ms (0.01%)
json 0.030 ms (0.01%)
json.decoder 0.030 ms (0.01%)
re 0.030 ms (0.01%)
enum 0.030 ms (0.01%)
types 0.030 ms (0.01%)

@pr-commenter
Copy link

pr-commenter bot commented Aug 19, 2025

Benchmarks

Benchmark execution time: 2025-08-19 15:14:27

Comparing candidate commit 64d727d in PR branch backport-14299-to-3.10 with baseline commit e5b0b64 in branch 3.10.

Found 0 performance improvements and 4 performance regressions! Performance is the same for 544 metrics, 2 unstable metrics.

scenario:iastaspectsospath-ospathjoin_aspect

  • 🟥 execution_time [+773.707ns; +931.246ns] or [+13.038%; +15.692%]

scenario:iastaspectsospath-ospathsplit_aspect

  • 🟥 execution_time [+844.747ns; +1103.095ns] or [+18.402%; +24.030%]

scenario:iastaspectsospath-ospathsplitdrive_aspect

  • 🟥 execution_time [+532.208ns; +612.509ns] or [+14.998%; +17.261%]

scenario:iastaspectsospath-ospathsplitext_aspect

  • 🟥 execution_time [+678.546ns; +792.744ns] or [+15.373%; +17.960%]

@juanjux juanjux merged commit 47b9f8e into 3.10 Aug 19, 2025
925 of 929 checks passed
@juanjux juanjux deleted the backport-14299-to-3.10 branch August 19, 2025 15:41
juanjux pushed a commit that referenced this pull request Aug 20, 2025
Multiple PRs experienced `tests/smoke_test.py` failing on
build_base_venv jobs, blocking merging those PRs, examples include

- #14310
- #14353

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [ ] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog A changelog entry is not required for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants