-
Notifications
You must be signed in to change notification settings - Fork 469
feat(aiokafka): add APM support for aiokafka #15111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
Co-authored-by: Pieter Van Isacker <pieter.vanisacker@lightspeedhq.com>
22d3b51 to
a4bf535
Compare
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 251 ± 3 ms. The average import time from base is: 259 ± 4 ms. The import time difference between this PR and base is: -7.8 ± 0.2 ms. Import time breakdownThe following import paths have appeared:
|
Performance SLOsComparing candidate dubloom/aiokafka-apm (19f672d) with baseline main (30d88d9) 🟡 Near SLO Breach (3 suites)🟡 otelspan - 22/22✅ add-eventTime: ✅ 38.469ms (SLO: <47.150ms 📉 -18.4%) vs baseline: +0.1% Memory: ✅ 38.997MB (SLO: <47.000MB 📉 -17.0%) vs baseline: +4.9% ✅ add-metricsTime: ✅ 256.694ms (SLO: <344.800ms 📉 -25.6%) vs baseline: -0.3% Memory: ✅ 43.255MB (SLO: <47.500MB -8.9%) vs baseline: +4.6% ✅ add-tagsTime: ✅ 314.672ms (SLO: <321.000ms 🟡 -2.0%) vs baseline: -0.7% Memory: ✅ 43.256MB (SLO: <47.500MB -8.9%) vs baseline: +4.8% ✅ get-contextTime: ✅ 78.604ms (SLO: <92.350ms 📉 -14.9%) vs baseline: +0.4% Memory: ✅ 39.318MB (SLO: <46.500MB 📉 -15.4%) vs baseline: +4.6% ✅ is-recordingTime: ✅ 35.913ms (SLO: <44.500ms 📉 -19.3%) vs baseline: -0.2% Memory: ✅ 38.798MB (SLO: <47.500MB 📉 -18.3%) vs baseline: +5.2% ✅ record-exceptionTime: ✅ 56.948ms (SLO: <67.650ms 📉 -15.8%) vs baseline: -0.4% Memory: ✅ 39.515MB (SLO: <47.000MB 📉 -15.9%) vs baseline: +5.1% ✅ set-statusTime: ✅ 42.300ms (SLO: <50.400ms 📉 -16.1%) vs baseline: -0.5% Memory: ✅ 38.798MB (SLO: <47.000MB 📉 -17.5%) vs baseline: +4.8% ✅ startTime: ✅ 35.466ms (SLO: <43.450ms 📉 -18.4%) vs baseline: +0.4% Memory: ✅ 38.710MB (SLO: <47.000MB 📉 -17.6%) vs baseline: +4.6% ✅ start-finishTime: ✅ 81.908ms (SLO: <88.000ms -6.9%) vs baseline: +0.3% Memory: ✅ 36.628MB (SLO: <46.500MB 📉 -21.2%) vs baseline: +4.8% ✅ start-finish-telemetryTime: ✅ 83.284ms (SLO: <89.000ms -6.4%) vs baseline: +0.1% Memory: ✅ 36.667MB (SLO: <46.500MB 📉 -21.1%) vs baseline: +4.9% ✅ update-nameTime: ✅ 36.956ms (SLO: <45.150ms 📉 -18.1%) vs baseline: -0.3% Memory: ✅ 38.944MB (SLO: <47.000MB 📉 -17.1%) vs baseline: +4.9% 🟡 span - 26/26✅ add-eventTime: ✅ 17.400ms (SLO: <22.500ms 📉 -22.7%) vs baseline: +0.6% Memory: ✅ 36.450MB (SLO: <53.000MB 📉 -31.2%) vs baseline: +4.9% ✅ add-metricsTime: ✅ 87.228ms (SLO: <93.500ms -6.7%) vs baseline: +1.2% Memory: ✅ 40.825MB (SLO: <53.000MB 📉 -23.0%) vs baseline: +5.4% ✅ add-tagsTime: ✅ 139.145ms (SLO: <155.000ms 📉 -10.2%) vs baseline: ~same Memory: ✅ 40.462MB (SLO: <53.000MB 📉 -23.7%) vs baseline: +4.8% ✅ get-contextTime: ✅ 16.143ms (SLO: <20.500ms 📉 -21.3%) vs baseline: +1.0% Memory: ✅ 36.211MB (SLO: <53.000MB 📉 -31.7%) vs baseline: +5.0% ✅ is-recordingTime: ✅ 16.400ms (SLO: <20.500ms 📉 -20.0%) vs baseline: +0.9% Memory: ✅ 36.170MB (SLO: <53.000MB 📉 -31.8%) vs baseline: +4.6% ✅ record-exceptionTime: ✅ 35.284ms (SLO: <40.000ms 📉 -11.8%) vs baseline: -0.2% Memory: ✅ 36.924MB (SLO: <53.000MB 📉 -30.3%) vs baseline: +4.7% ✅ set-statusTime: ✅ 17.687ms (SLO: <22.000ms 📉 -19.6%) vs baseline: -0.3% Memory: ✅ 36.211MB (SLO: <53.000MB 📉 -31.7%) vs baseline: +4.9% ✅ startTime: ✅ 16.138ms (SLO: <20.500ms 📉 -21.3%) vs baseline: +1.2% Memory: ✅ 36.193MB (SLO: <53.000MB 📉 -31.7%) vs baseline: +4.7% ✅ start-finishTime: ✅ 51.550ms (SLO: <52.500ms 🟡 -1.8%) vs baseline: +1.6% Memory: ✅ 34.642MB (SLO: <35.500MB -2.4%) vs baseline: +5.2% ✅ start-finish-telemetryTime: ✅ 52.725ms (SLO: <54.500ms -3.3%) vs baseline: +1.4% Memory: ✅ 34.583MB (SLO: <35.500MB -2.6%) vs baseline: +4.9% ✅ start-finish-traceid128Time: ✅ 53.769ms (SLO: <57.000ms -5.7%) vs baseline: -0.2% Memory: ✅ 34.544MB (SLO: <35.500MB -2.7%) vs baseline: +4.9% ✅ start-traceid128Time: ✅ 16.441ms (SLO: <22.500ms 📉 -26.9%) vs baseline: +1.2% Memory: ✅ 36.226MB (SLO: <53.000MB 📉 -31.6%) vs baseline: +4.8% ✅ update-nameTime: ✅ 16.528ms (SLO: <22.000ms 📉 -24.9%) vs baseline: +0.8% Memory: ✅ 36.427MB (SLO: <53.000MB 📉 -31.3%) vs baseline: +4.9% 🟡 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 2.946µs (SLO: <20.000µs 📉 -85.3%) vs baseline: -0.2% Memory: ✅ 34.505MB (SLO: <35.500MB -2.8%) vs baseline: +4.8% ✅ 1-count-metrics-100-timesTime: ✅ 198.062µs (SLO: <220.000µs -10.0%) vs baseline: -1.9% Memory: ✅ 34.564MB (SLO: <35.500MB -2.6%) vs baseline: +5.2% ✅ 1-distribution-metric-1-timesTime: ✅ 3.360µs (SLO: <20.000µs 📉 -83.2%) vs baseline: +0.9% Memory: ✅ 34.446MB (SLO: <35.500MB -3.0%) vs baseline: +4.7% ✅ 1-distribution-metrics-100-timesTime: ✅ 215.642µs (SLO: <220.000µs 🟡 -2.0%) vs baseline: -0.7% Memory: ✅ 34.524MB (SLO: <35.500MB -2.7%) vs baseline: +4.6% ✅ 1-gauge-metric-1-timesTime: ✅ 2.184µs (SLO: <20.000µs 📉 -89.1%) vs baseline: +0.5% Memory: ✅ 34.583MB (SLO: <35.500MB -2.6%) vs baseline: +4.9% ✅ 1-gauge-metrics-100-timesTime: ✅ 138.042µs (SLO: <150.000µs -8.0%) vs baseline: +0.7% Memory: ✅ 34.564MB (SLO: <35.500MB -2.6%) vs baseline: +5.0% ✅ 1-rate-metric-1-timesTime: ✅ 3.124µs (SLO: <20.000µs 📉 -84.4%) vs baseline: +0.3% Memory: ✅ 34.465MB (SLO: <35.500MB -2.9%) vs baseline: +4.9% ✅ 1-rate-metrics-100-timesTime: ✅ 212.326µs (SLO: <250.000µs 📉 -15.1%) vs baseline: -0.9% Memory: ✅ 34.485MB (SLO: <35.500MB -2.9%) vs baseline: +4.9% ✅ 100-count-metrics-100-timesTime: ✅ 19.943ms (SLO: <22.000ms -9.3%) vs baseline: +0.2% Memory: ✅ 34.544MB (SLO: <35.500MB -2.7%) vs baseline: +5.2% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.262ms (SLO: <2.300ms 🟡 -1.6%) vs baseline: -1.7% Memory: ✅ 34.524MB (SLO: <35.500MB -2.7%) vs baseline: +4.9% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.419ms (SLO: <1.550ms -8.4%) vs baseline: +0.9% Memory: ✅ 34.583MB (SLO: <35.500MB -2.6%) vs baseline: +5.0% ✅ 100-rate-metrics-100-timesTime: ✅ 2.191ms (SLO: <2.550ms 📉 -14.1%) vs baseline: +0.5% Memory: ✅ 34.505MB (SLO: <35.500MB -2.8%) vs baseline: +4.8% ✅ flush-1-metricTime: ✅ 4.682µs (SLO: <20.000µs 📉 -76.6%) vs baseline: +1.9% Memory: ✅ 34.485MB (SLO: <35.500MB -2.9%) vs baseline: +5.0% ✅ flush-100-metricsTime: ✅ 174.366µs (SLO: <250.000µs 📉 -30.3%) vs baseline: ~same Memory: ✅ 34.564MB (SLO: <35.500MB -2.6%) vs baseline: +5.0% ✅ flush-1000-metricsTime: ✅ 2.113ms (SLO: <2.500ms 📉 -15.5%) vs baseline: -0.1% Memory: ✅ 35.311MB (SLO: <36.500MB -3.3%) vs baseline: +4.9%
|
wantsui
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This integration is looking really good! 👏
I have some comments about the output of a few span tags returning a different output than the other kafka integrations we have:
- kafka.partition
- kafka.partitions.*
- messaging.kafka.bootstrap.servers
- kafka.message_key
I can take another look once these comments are addressed.
...ots/tests.contrib.aiokafka.test_aiokafka.test_getmany_multiple_messages_multiple_topics.json
Outdated
Show resolved
Hide resolved
...ots/tests.contrib.aiokafka.test_aiokafka.test_getmany_multiple_messages_multiple_topics.json
Show resolved
Hide resolved
...a.test_aiokafka.test_getmany_multiple_messages_multiple_topics_with_distributed_tracing.json
Show resolved
Hide resolved
...snapshots/tests.contrib.aiokafka.test_aiokafka.test_send_and_wait_value[hueh_hueh_hueh].json
Outdated
Show resolved
Hide resolved
323222c to
cb803bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! Thanks for the changes!
I am approving it from an integrations perspective since my comment on messaging.kafka.bootstrap.servers isn't a blocker since they are both strings. The other span attributes are currently consistent with the other kafka integrations so 👍 .
mabdinur
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trace handler changes look good to me
Description
AIOKafkaProducer.send,AIOKafkaConsumer.getone/getmany, andcommit.DD_KAFKA_PROPAGATION_ENABLED=true.DSM support will be added in a follow-up PR.
Testing
Added snapshot tests in
test_aiokafka.pyThis is a follow up of #10068
Thanks for your initial initial contribution @ls-pieter-vanisacker