Skip to content

chore(tracing): remove Span.finished setter and Span.finish_with_ancestors #15212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 11, 2025
Merged

chore(tracing): remove Span.finished setter and Span.finish_with_ancestors #15212

merged 2 commits into from
Nov 11, 2025

Conversation

@brettlangdon
Copy link
Member

@brettlangdon brettlangdon commented Nov 11, 2025

Description

Deprecated in 3.x, now removed in 4.0

Testing

Risks

Additional Notes

@brettlangdon brettlangdon requested review from a team as code owners November 11, 2025 16:08
@brettlangdon brettlangdon enabled auto-merge (squash) November 11, 2025 16:09
@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2025

CODEOWNERS have been resolved as:

releasenotes/notes/remove-span-finished-finish-with-ancestors-fb2d11b874206f59.yaml  @DataDog/apm-python
ddtrace/_trace/span.py                                                  @DataDog/apm-sdk-capabilities-python

@emmettbutler emmettbutler added changelog/no-changelog A changelog entry is not required for this PR. and removed changelog/no-changelog A changelog entry is not required for this PR. labels Nov 11, 2025
@emmettbutler emmettbutler merged commit 1c95d17 into 4.0-breaking-changes Nov 11, 2025
33 of 42 checks passed
@emmettbutler emmettbutler deleted the brettlangdon/remove.span.deprecations branch November 11, 2025 16:37
@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 242 ± 4 ms.

The average import time from base is: 243 ± 4 ms.

The import time difference between this PR and base is: -0.6 ± 0.2 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 1.890 ms (0.78%)
ddtrace.bootstrap.sitecustomize 1.211 ms (0.50%)
ddtrace.bootstrap.preload 1.211 ms (0.50%)
ddtrace.internal.remoteconfig.client 0.600 ms (0.25%)
ddtrace 0.679 ms (0.28%)
ddtrace.internal._unpatched 0.027 ms (0.01%)
json 0.027 ms (0.01%)
json.decoder 0.027 ms (0.01%)
re 0.027 ms (0.01%)
enum 0.027 ms (0.01%)
types 0.027 ms (0.01%)

@taegyunkim taegyunkim mentioned this pull request Nov 11, 2025
Merged
taegyunkim added a commit that referenced this pull request Nov 12, 2025
@taegyunkim
chore(tracing): remove test_span_finish_with_ancestors test (#15215)
82cf8a4 
## Description

The API was deleted in #15212

## Testing

<!-- Describe your testing strategy or note what tests are included -->

## Risks

<!-- Note any risks associated with this change, or "None" if no risks
-->

## Additional Notes

<!-- Any other information that would be helpful for reviewers -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emmettbutler emmettbutler emmettbutler approved these changes

@rachelyangdog rachelyangdog rachelyangdog approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@brettlangdon @emmettbutler @rachelyangdog