-
Notifications
You must be signed in to change notification settings - Fork 468
chore(tracing): update test_span_finish_with_ancestors test #15215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
brettlangdon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually, this should be updated to use _finish_with_ancestors() since the feature still exists, it is just internal
|
btw how do I test this locally?
|
|
Needs #15214 apparently :/ |
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 200 ± 2 ms. The average import time from base is: 203 ± 2 ms. The import time difference between this PR and base is: -2.71 ± 0.08 ms. Import time breakdownThe following import paths have shrunk:
|
|
@brettlangdon the test is failing with Looks like the test is invoking |
Performance SLOsComparing candidate taegyunkim/remove-test (76021e0) with baseline 4.0-breaking-changes (75d837c) 🟡 Near SLO Breach (5 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 20.410ms (SLO: <22.300ms -8.5%) vs baseline: ~same Memory: ✅ 66.039MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +4.9% ✅ exception-replay-enabledTime: ✅ 1.338ms (SLO: <1.450ms -7.7%) vs baseline: -0.2% Memory: ✅ 64.065MB (SLO: <67.000MB -4.4%) vs baseline: +4.8% ✅ iastTime: ✅ 20.347ms (SLO: <22.250ms -8.6%) vs baseline: -0.5% Memory: ✅ 65.989MB (SLO: <67.000MB 🟡 -1.5%) vs baseline: +4.7% ✅ profilerTime: ✅ 15.433ms (SLO: <16.550ms -6.7%) vs baseline: +0.4% Memory: ✅ 53.741MB (SLO: <54.500MB 🟡 -1.4%) vs baseline: +4.7% ✅ resource-renamingTime: ✅ 20.512ms (SLO: <21.750ms -5.7%) vs baseline: ~same Memory: ✅ 65.974MB (SLO: <67.000MB 🟡 -1.5%) vs baseline: +4.9% ✅ span-code-originTime: ✅ 25.354ms (SLO: <28.200ms 📉 -10.1%) vs baseline: -0.5% Memory: ✅ 67.321MB (SLO: <69.500MB -3.1%) vs baseline: +4.9% ✅ tracerTime: ✅ 20.404ms (SLO: <21.750ms -6.2%) vs baseline: -0.2% Memory: ✅ 65.986MB (SLO: <67.000MB 🟡 -1.5%) vs baseline: +4.8% ✅ tracer-and-profilerTime: ✅ 22.442ms (SLO: <23.500ms -4.5%) vs baseline: -0.2% Memory: ✅ 67.905MB (SLO: <68.000MB 🟡 -0.1%) vs baseline: +5.2% ✅ tracer-dont-create-db-spansTime: ✅ 19.249ms (SLO: <21.500ms 📉 -10.5%) vs baseline: -0.4% Memory: ✅ 65.869MB (SLO: <67.000MB 🟡 -1.7%) vs baseline: +4.7% ✅ tracer-minimalTime: ✅ 16.678ms (SLO: <17.500ms -4.7%) vs baseline: +0.2% Memory: ✅ 66.002MB (SLO: <67.000MB 🟡 -1.5%) vs baseline: +4.9% ✅ tracer-nativeTime: ✅ 20.425ms (SLO: <21.750ms -6.1%) vs baseline: ~same Memory: ✅ 67.535MB (SLO: <72.500MB -6.8%) vs baseline: +4.8% ✅ tracer-no-cachesTime: ✅ 18.427ms (SLO: <19.650ms -6.2%) vs baseline: -0.6% Memory: ✅ 65.863MB (SLO: <67.000MB 🟡 -1.7%) vs baseline: +4.7% ✅ tracer-no-databasesTime: ✅ 18.729ms (SLO: <20.100ms -6.8%) vs baseline: ~same Memory: ✅ 66.021MB (SLO: <67.000MB 🟡 -1.5%) vs baseline: +4.9% ✅ tracer-no-middlewareTime: ✅ 20.153ms (SLO: <21.500ms -6.3%) vs baseline: -0.3% Memory: ✅ 65.999MB (SLO: <67.000MB 🟡 -1.5%) vs baseline: +4.9% ✅ tracer-no-templatesTime: ✅ 20.255ms (SLO: <22.000ms -7.9%) vs baseline: +0.4% Memory: ✅ 65.935MB (SLO: <67.000MB 🟡 -1.6%) vs baseline: +4.7% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 18.008ms (SLO: <19.850ms -9.3%) vs baseline: ~same Memory: ✅ 65.903MB (SLO: <66.500MB 🟡 -0.9%) vs baseline: +4.6% ✅ errortracking-enabled-userTime: ✅ 18.124ms (SLO: <19.400ms -6.6%) vs baseline: +0.4% Memory: ✅ 65.785MB (SLO: <66.500MB 🟡 -1.1%) vs baseline: +4.6% ✅ tracer-enabledTime: ✅ 18.071ms (SLO: <19.450ms -7.1%) vs baseline: ~same Memory: ✅ 65.784MB (SLO: <66.500MB 🟡 -1.1%) vs baseline: +4.7% 🟡 errortrackingflasksqli - 6/6✅ errortracking-enabled-allTime: ✅ 2.074ms (SLO: <2.300ms -9.8%) vs baseline: +0.5% Memory: ✅ 52.453MB (SLO: <53.500MB 🟡 -2.0%) vs baseline: +4.5% ✅ errortracking-enabled-userTime: ✅ 2.090ms (SLO: <2.250ms -7.1%) vs baseline: +1.2% Memory: ✅ 52.509MB (SLO: <53.500MB 🟡 -1.9%) vs baseline: +4.6% ✅ tracer-enabledTime: ✅ 2.076ms (SLO: <2.300ms -9.7%) vs baseline: +0.6% Memory: ✅ 52.550MB (SLO: <53.500MB 🟡 -1.8%) vs baseline: +4.9% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.586ms (SLO: <4.750ms -3.5%) vs baseline: -0.4% Memory: ✅ 61.958MB (SLO: <65.000MB -4.7%) vs baseline: +4.6% ✅ appsec-postTime: ✅ 6.608ms (SLO: <6.750ms -2.1%) vs baseline: -0.1% Memory: ✅ 62.155MB (SLO: <65.000MB -4.4%) vs baseline: +4.8% ✅ appsec-telemetryTime: ✅ 4.579ms (SLO: <4.750ms -3.6%) vs baseline: -0.5% Memory: ✅ 61.951MB (SLO: <65.000MB -4.7%) vs baseline: +4.6% ✅ debuggerTime: ✅ 1.853ms (SLO: <2.000ms -7.3%) vs baseline: -0.3% Memory: ✅ 45.161MB (SLO: <47.000MB -3.9%) vs baseline: +4.8% ✅ iast-getTime: ✅ 1.853ms (SLO: <2.000ms -7.3%) vs baseline: -0.5% Memory: ✅ 42.109MB (SLO: <49.000MB 📉 -14.1%) vs baseline: +4.7% ✅ profilerTime: ✅ 1.912ms (SLO: <2.100ms -8.9%) vs baseline: +0.2% Memory: ✅ 46.423MB (SLO: <47.000MB 🟡 -1.2%) vs baseline: +5.0% ✅ resource-renamingTime: ✅ 3.364ms (SLO: <3.650ms -7.8%) vs baseline: -0.3% Memory: ✅ 52.696MB (SLO: <53.500MB 🟡 -1.5%) vs baseline: +5.5% ✅ tracerTime: ✅ 3.351ms (SLO: <3.650ms -8.2%) vs baseline: -0.5% Memory: ✅ 52.415MB (SLO: <53.500MB -2.0%) vs baseline: +5.0% ✅ tracer-nativeTime: ✅ 3.354ms (SLO: <3.650ms -8.1%) vs baseline: ~same Memory: ✅ 54.038MB (SLO: <60.000MB -9.9%) vs baseline: +5.0% 🟡 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.157µs (SLO: <20.000µs 📉 -84.2%) vs baseline: +2.9% Memory: ✅ 31.556MB (SLO: <34.000MB -7.2%) vs baseline: +4.7% ✅ 1-count-metrics-100-timesTime: ✅ 205.480µs (SLO: <220.000µs -6.6%) vs baseline: -0.4% Memory: ✅ 31.516MB (SLO: <34.000MB -7.3%) vs baseline: +4.7% ✅ 1-distribution-metric-1-timesTime: ✅ 3.432µs (SLO: <20.000µs 📉 -82.8%) vs baseline: ~same Memory: ✅ 31.575MB (SLO: <34.000MB -7.1%) vs baseline: +5.2% ✅ 1-distribution-metrics-100-timesTime: ✅ 218.534µs (SLO: <220.000µs 🟡 -0.7%) vs baseline: +0.3% Memory: ✅ 31.516MB (SLO: <34.000MB -7.3%) vs baseline: +4.9% ✅ 1-gauge-metric-1-timesTime: ✅ 2.257µs (SLO: <20.000µs 📉 -88.7%) vs baseline: +0.9% Memory: ✅ 31.615MB (SLO: <34.000MB -7.0%) vs baseline: +5.1% ✅ 1-gauge-metrics-100-timesTime: ✅ 137.472µs (SLO: <150.000µs -8.4%) vs baseline: +0.6% Memory: ✅ 31.556MB (SLO: <34.000MB -7.2%) vs baseline: +5.0% ✅ 1-rate-metric-1-timesTime: ✅ 3.292µs (SLO: <20.000µs 📉 -83.5%) vs baseline: +3.8% Memory: ✅ 31.477MB (SLO: <34.000MB -7.4%) vs baseline: +4.5% ✅ 1-rate-metrics-100-timesTime: ✅ 221.254µs (SLO: <250.000µs 📉 -11.5%) vs baseline: +1.4% Memory: ✅ 31.536MB (SLO: <34.000MB -7.2%) vs baseline: +4.9% ✅ 100-count-metrics-100-timesTime: ✅ 20.799ms (SLO: <22.000ms -5.5%) vs baseline: +0.9% Memory: ✅ 31.575MB (SLO: <34.000MB -7.1%) vs baseline: +5.1% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.301ms (SLO: <2.300ms ~same) vs baseline: -0.9% Memory: ✅ 31.536MB (SLO: <34.000MB -7.2%) vs baseline: +4.9% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.411ms (SLO: <1.550ms -9.0%) vs baseline: -0.4% Memory: ✅ 31.516MB (SLO: <34.000MB -7.3%) vs baseline: +4.8% ✅ 100-rate-metrics-100-timesTime: ✅ 2.228ms (SLO: <2.550ms 📉 -12.6%) vs baseline: -0.4% Memory: ✅ 31.634MB (SLO: <34.000MB -7.0%) vs baseline: +5.1% ✅ flush-1-metricTime: ✅ 4.623µs (SLO: <20.000µs 📉 -76.9%) vs baseline: +0.1% Memory: ✅ 31.556MB (SLO: <34.000MB -7.2%) vs baseline: +3.6% ✅ flush-100-metricsTime: ✅ 174.409µs (SLO: <250.000µs 📉 -30.2%) vs baseline: -0.2% Memory: ✅ 31.929MB (SLO: <34.000MB -6.1%) vs baseline: +5.0% ✅ flush-1000-metricsTime: ✅ 2.146ms (SLO: <2.500ms 📉 -14.2%) vs baseline: ~same Memory: ✅ 32.794MB (SLO: <34.500MB -4.9%) vs baseline: +5.1%
|
Description
The API was deleted in #15212 and use internal api
_finish_with_ancestors()Testing
Risks
Additional Notes