-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rails Runner instrumentation #2509
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcotc
force-pushed
the
rails-runner
branch
2 times, most recently
from
May 31, 2024 21:05
61c130a
to
d4f3678
Compare
aliciascott
approved these changes
May 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good for docs
marcotc
force-pushed
the
rails-runner
branch
3 times, most recently
from
May 31, 2024 21:56
2827a33
to
0702f08
Compare
Signed-off-by: Marco Costa <marco.costa@datadoghq.com>
TonyCTHsu
reviewed
Jun 20, 2024
Signed-off-by: Marco Costa <marco.costa@datadoghq.com>
TonyCTHsu
approved these changes
Jun 24, 2024
p-datadog
reviewed
Jun 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I read the diff and it LGTM.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1219
Instrument the Rails application entry-point
bin/rails runner
.This entry-point is used to execute a single Ruby command or script in the context of the Rails application.
How to test the change?
All changes are covered by tests.