Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails Runner instrumentation #2509

Merged
merged 3 commits into from
Jun 26, 2024
Merged

Rails Runner instrumentation #2509

merged 3 commits into from
Jun 26, 2024

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Dec 28, 2022

Fixes #1219

Instrument the Rails application entry-point bin/rails runner.

This entry-point is used to execute a single Ruby command or script in the context of the Rails application.

How to test the change?

All changes are covered by tests.

@github-actions github-actions bot added integrations Involves tracing integrations tracing labels Dec 28, 2022
@marcotc marcotc force-pushed the rails-runner branch 2 times, most recently from 61c130a to d4f3678 Compare May 31, 2024 21:05
@marcotc marcotc marked this pull request as ready for review May 31, 2024 21:06
@marcotc marcotc requested review from a team as code owners May 31, 2024 21:06
Copy link

@aliciascott aliciascott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good for docs

@marcotc marcotc force-pushed the rails-runner branch 3 times, most recently from 2827a33 to 0702f08 Compare May 31, 2024 21:56
Signed-off-by: Marco Costa <marco.costa@datadoghq.com>
Signed-off-by: Marco Costa <marco.costa@datadoghq.com>
@marcotc marcotc requested a review from TonyCTHsu June 21, 2024 19:22
Copy link
Member

@p-datadog p-datadog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read the diff and it LGTM.

@marcotc marcotc enabled auto-merge June 26, 2024 18:52
@marcotc marcotc merged commit 3e515da into master Jun 26, 2024
164 of 165 checks passed
@marcotc marcotc deleted the rails-runner branch June 26, 2024 19:13
@github-actions github-actions bot added this to the 2.2.0 milestone Jun 26, 2024
@TonyCTHsu TonyCTHsu mentioned this pull request Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrations Involves tracing integrations tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rails Runner Instrumentation
4 participants