Gracefully handle Rails runner patching whenever spans aren't instrumented #3996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerwillingham
force-pushed
the
twilling/rails-runner-spanless-bug
branch
2 times, most recently
from
b4a743c to
f2031a0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3996 +/- ##
=======================================
Coverage 97.86% 97.86%
=======================================
Files 1314 1314
Lines 78651 78654 +3
Branches 3909 3909
=======================================
+ Hits 76970 76975 +5
+ Misses 1681 1679 -2 ☔ View full report in Codecov by Sentry. |
tylerwillingham
force-pushed
the
twilling/rails-runner-spanless-bug
branch
from
f2031a0 to
1430cbc
Compare
marcotc
approved these changes
Oct 15, 2024
|
Thank you so much, @tylerwillingham! The changes are clean and correct 👍 |
|
@marcotc happy to contribute 👍 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
datadog2.2 #3995Motivation:
This avoids an
undefined methoderror onnilClasswhenever when attemptingspan.name=. The spec correctly captures the scenario we're seeing during deploys in our Rails app.Additional Notes:
How to test the change?
Unsure? Have a question? Request a review!