Update rubocop and rubocop_todo configuration for Naming/FileName #3187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3187 +/- ##
==========================================
- Coverage 98.21% 98.19% -0.02%
==========================================
Files 1247 1250 +3
Lines 71664 71894 +230
Branches 3329 3353 +24
==========================================
+ Hits 70382 70598 +216
- Misses 1282 1296 +14
... and 18 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
anmarchenko
approved these changes
Oct 5, 2023
There was a problem hiding this comment.
these files were added recently:
#3026
They do not seem to be used anywhere else.
@GustavoCaso do you think we need to rename modules in .rbs files too?
GustavoCaso
force-pushed
the
fix-file-name-constant-missmatch
branch
from
1048d8f to
7032a97
Compare
GustavoCaso
changed the title
anmarchenko
approved these changes
Oct 5, 2023
GustavoCaso
force-pushed
the
fix-file-name-constant-missmatch
branch
from
7032a97 to
9385fff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update rubocop and rubocop_todo configuration for Naming/FileName
Motivation:
Additional Notes:
How to test the change?
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!