Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Ruby 3.3 integration due to protobuf compilation error (#3211) #3232

Merged

Conversation

ekump
Copy link
Contributor

@ekump ekump commented Oct 26, 2023

What does this PR do?
Backports #3211: Disable integration test for Ruby 3.3. that cannot install its gemfiles until protocolbuffers/protobuf#14509 is addressed.

Motivation:
CI is breaking for 1.x-stable

Additional Notes:

How to test the change?

For Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles
    credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@ekump ekump requested a review from a team as a code owner October 26, 2023 20:05
@github-actions github-actions bot added the dev/ci Involves CircleCI, GitHub Actions, or GitLab label Oct 26, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3232 (4193ea4) into 1.x-stable (856b825) will increase coverage by 0.65%.
Report is 3657 commits behind head on 1.x-stable.
The diff coverage is 100.00%.

@@              Coverage Diff               @@
##           1.x-stable    #3232      +/-   ##
==============================================
+ Coverage       97.56%   98.21%   +0.65%     
==============================================
  Files            1080     1252     +172     
  Lines           56438    71945   +15507     
  Branches            0     3333    +3333     
==============================================
+ Hits            55062    70663   +15601     
+ Misses           1376     1282      -94     
Files Coverage Δ
...iling_native_extension/native_extension_helpers.rb 96.73% <100.00%> (+0.58%) ⬆️

... and 1313 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ekump ekump merged commit 204d507 into 1.x-stable Oct 26, 2023
164 checks passed
@ekump ekump deleted the ekump/backport-disable-build-and-test-integration-3.3 branch October 26, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/ci Involves CircleCI, GitHub Actions, or GitLab
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants