Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable Ruby 3.3 integration due to protobuf compilation error #3211

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Disable Ruby 3.3 integration due to protobuf compilation error #3211

merged 2 commits into from
Oct 24, 2023

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Oct 23, 2023

Disable integration test for Ruby 3.3. that cannot install its gemfiles until protocolbuffers/protobuf#14509 is addressed.

@marcotc marcotc requested a review from a team as a code owner October 23, 2023 20:39
@github-actions github-actions bot added the dev/ci Involves CircleCI, GitHub Actions, or GitLab label Oct 23, 2023
ivoanjo
ivoanjo approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 We should probably keep an eye out for the fix, timeline-wise.

E.g. if by the beginning of December this isn't fixed, we I think we should consider other solutions, so that we have test coverage by the time Ruby 3.3 stable gets released.

@marcotc marcotc merged commit e67840f into master Oct 24, 2023
177 checks passed
@marcotc marcotc deleted the disable-protobuf-3.3-int branch October 24, 2023 21:13
@marcotc marcotc added this to the 1.16.0 milestone Oct 25, 2023
ekump pushed a commit that referenced this pull request Oct 26, 2023
@marcotc @ekump
Disable Ruby 3.3 integration due to protobuf compilation error (#3211)
4193ea4
@ekump ekump mentioned this pull request Oct 26, 2023
Merged
2 tasks
ekump added a commit that referenced this pull request Oct 26, 2023
@ekump @marcotc
Disable Ruby 3.3 integration due to protobuf compilation error (#3211) (
204d507 
#3232)

Co-authored-by: Marco Costa <marco.costa@datadoghq.com>
@ivoanjo ivoanjo mentioned this pull request Nov 27, 2023
Merged
2 tasks
pull bot pushed a commit to astradot/dd-trace-rb that referenced this pull request Nov 28, 2023
@ivoanjo
Revert "Disable Ruby 3.3 integration due to protobuf compilation error"
88b3f73 
**What does this PR do?**

This reverts commit f9ebce9.

**Motivation:**

In DataDog#3211 we disabled our CI integration testing on Ruby 3.3 because
one of the dependencies (protobuf) had an incompatibility at the
time (see protocolbuffers/protobuf#14509 for details).

Upstream has since fixed the issue, so we're good to go.

**Additional Notes:**

N/A

**How to test the change?**

Check that CircleCI is now also running the
`build_and_test_integration-3.3` test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivoanjo ivoanjo ivoanjo approved these changes

@anmarchenko anmarchenko anmarchenko approved these changes

Assignees
No one assigned
Labels
dev/ci Involves CircleCI, GitHub Actions, or GitLab
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.
3 participants
@marcotc @anmarchenko @ivoanjo