Skip to content

Commit

Permalink
Revert "Disable Ruby 3.3 integration due to protobuf compilation error"
Browse files Browse the repository at this point in the history
**What does this PR do?**

This reverts commit f9ebce9.

**Motivation:**

In DataDog#3211 we disabled our CI integration testing on Ruby 3.3 because
one of the dependencies (protobuf) had an incompatibility at the
time (see protocolbuffers/protobuf#14509 for details).

Upstream has since fixed the issue, so we're good to go.

**Additional Notes:**

N/A

**How to test the change?**

Check that CircleCI is now also running the
`build_and_test_integration-3.3` test.
  • Loading branch information
ivoanjo committed Nov 27, 2023
1 parent 2631add commit 88b3f73
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -606,12 +606,11 @@ workflows:
integration_apps: 'rack rails-six rails-seven sinatra2-classic sinatra2-modular'
ruby_version: '3.2'
<<: *filters_all_branches_and_tags
# # Disabled until https://github.com/protocolbuffers/protobuf/issues/14509 is fixed.
# - orb/build_and_test_integration:
# name: build_and_test_integration-3.3
# integration_apps: 'rack rails-six rails-seven sinatra2-classic sinatra2-modular'
# ruby_version: '3.3'
# <<: *filters_all_branches_and_tags
- orb/build_and_test_integration:
name: build_and_test_integration-3.3
integration_apps: 'rack rails-six rails-seven sinatra2-classic sinatra2-modular'
ruby_version: '3.3'
<<: *filters_all_branches_and_tags
# ⬆️ **Note**: If add/remove test apps above, remember to also copy-paste the changes to the "edge" workflow further down the file.
#
# ADD NEW RUBIES HERE
Expand Down

0 comments on commit 88b3f73

Please sign in to comment.