[PROF-9368] Revert Ruby 2.1/2.2/2.3 CI images to older Debian to support mysql gem #3542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ort mysql gem **What does this PR do?** This PR is a slightly tweaked revert of #3534 . TL;DR after updating our Ruby 2.1/2.2/2.3 images to a newer debian, we discovered that some of our CI testing requires the `mysql` gem, which breaks on newer Debian versions (due to a newer libmysqlclient/libmariadb). With these reverts, I was able to locally rebuild the images and install both mysql and nokogiri: ``` $ docker run -ti -v `pwd`:/working ivoanjo/docker-library:ddtrace_rb_2_3_8_testing_t6 /bin/bash root@255fe2dc2374:/app# ruby -v ruby 2.3.8p459 (2018-10-18 revision 65136) [x86_64-linux] root@255fe2dc2374:/app# docker-compose -v docker-compose version 1.8.0, build unknown root@255fe2dc2374:/app# bundle -v Bundler version 1.17.3 root@255fe2dc2374:/app# gem install mysql Fetching mysql-2.9.1.gem Building native extensions. This could take a while... Successfully installed mysql-2.9.1 1 gem installed root@255fe2dc2374:/app# gem install nokogiri -v '= 1.10.10' Fetching nokogiri-1.10.10.gem Fetching mini_portile2-2.4.0.gem Successfully installed mini_portile2-2.4.0 Building native extensions. This could take a while... Successfully installed nokogiri-1.10.10 2 gems installed ``` I was able to reproduce similar successful output on 2.1 and 2.2 as well (using nokogiri 1.9.1; 1.10.10 requires 2.3). **Motivation:** **Additional Notes:** In the `Dockerfile` that #3534 initially changed there was a comment stating that we were installing `docker-compose 1.21` from stretch-backports, which confused me initially, since I couldn't install that version from backports. I checked an image build log from 2 months ago (https://github.com/DataDog/dd-trace-rb/actions/runs/7386478002/job/20093153619) and copied its image sha `ghcr.io/datadog/dd-trace-rb/ruby:2.3.8-dd@sha256:b940776f41a5993e728f813c92734eaa82070ba74626ad8d2768a0242de269b3` and got the same `docker-compose 1.8.0` I'm getting now: ``` $ docker run -ti -v `pwd`:/working ghcr.io/datadog/dd-trace-rb/ruby:2.3.8-dd@sha256:b940776f41a5993e728f813c92734eaa82070ba74626ad8d2768a0242de269b3 /bin/bash root@23481c358c5b:/app# docker-compose -v docker-compose version 1.8.0, build unknown ``` Unless I'm doing something wrong, either this comment was never correct OR somehow the package we were using got purged. Either way, it seems to me that this indicates we can still use this version, so let's move forward (and hope to really stop supporting these Rubies soon). **How to test the change?** Check CI builds for the images and/or build locally. Note that our overall CI is a bit undisposed with incorrect images, so I'm expecting red unrelated CI jobs that will only be fixed after we publish these new images.
ivoanjo
force-pushed
the
ivoanjo/revert-ci-images-to-debian-stretch
branch
from
cae8d8d
to
2119ba1
Compare
AlexJF
approved these changes
Mar 20, 2024
|
Image builds worked, going ahead and merging this (ignore other CI failures, see notes for why). |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR is a slightly tweaked revert of
#3534 .
TL;DR after updating our Ruby 2.1/2.2/2.3 images to a newer debian, we discovered that some of our CI testing requires the
mysqlgem, which breaks on newer Debian versions (due to a newer libmysqlclient/libmariadb).With these reverts, I was able to locally rebuild the images and install both mysql and nokogiri:
I was able to reproduce similar successful output on 2.1 and 2.2 as well (using nokogiri 1.9.1; 1.10.10 requires 2.3).
Additional Notes:
In the
Dockerfilethat #3534 initially changed there was a comment stating that we were installingdocker-compose 1.21from stretch-backports, which confused me initially, since I couldn't install that version from backports.I checked an image build log from 2 months ago
(https://github.com/DataDog/dd-trace-rb/actions/runs/7386478002/job/20093153619) and copied its image sha
ghcr.io/datadog/dd-trace-rb/ruby:2.3.8-dd@sha256:b940776f41a5993e728f813c92734eaa82070ba74626ad8d2768a0242de269b3and got the samedocker-compose 1.8.0I'm getting now:Unless I'm doing something wrong, either this comment was never correct OR somehow the package we were using got purged.
Either way, it seems to me that this indicates we can still use this version, so let's move forward (and hope to really stop supporting these Rubies soon).
How to test the change?
Check CI builds for the images and/or build locally. Note that our overall CI is a bit undisposed with incorrect images, so I'm expecting red unrelated CI jobs that will only be fixed after we publish these new images.
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.