Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove version tag if dd_service is not applied #4027

Merged
merged 4 commits into from
Oct 25, 2024

Conversation

mabdinur
Copy link
Contributor

@mabdinur mabdinur commented Oct 24, 2024

What does this PR do?

  • Ensures the trace level version tag is only applied to spans that use the global/default service name. This will keep DD_SERVICE and DD_VERSION insync

Motivation:

  • Parity with other tracing clients

Failing system-test: https://github.com/DataDog/system-tests/blob/5e90616079fc11656348026f5f771aea8bafa748/tests/parametric/test_config_consistency.py#L92

Change log entry

Additional Notes:

How to test the change?

@mabdinur mabdinur marked this pull request as ready for review October 24, 2024 19:47
@mabdinur mabdinur requested a review from a team as a code owner October 24, 2024 19:47
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.85%. Comparing base (91d883f) to head (a8025b1).

Files with missing lines Patch % Lines
lib/datadog/tracing/tracer.rb 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4027      +/-   ##
==========================================
- Coverage   97.86%   97.85%   -0.01%     
==========================================
  Files        1321     1321              
  Lines       79326    79336      +10     
  Branches     3934     3936       +2     
==========================================
+ Hits        77631    77636       +5     
- Misses       1695     1700       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Oct 24, 2024

Benchmarks

Benchmark execution time: 2024-10-24 20:25:28

Comparing candidate commit a8025b1 in PR branch munir/remove-version-tag-in-some-scenarios with baseline commit 91d883f in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 23 metrics, 2 unstable metrics.

scenario:profiler - sample timeline=false

  • 🟩 throughput [+0.451op/s; +0.465op/s] or [+7.231%; +7.450%]

@marcotc marcotc merged commit 96294fa into master Oct 25, 2024
268 of 270 checks passed
@marcotc marcotc deleted the munir/remove-version-tag-in-some-scenarios branch October 25, 2024 17:31
@github-actions github-actions bot added this to the 2.5.0 milestone Oct 25, 2024
@Strech Strech mentioned this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants