Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Apply DD_VERSION on all spans that use the default or global service name #4075

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

mabdinur
Copy link
Contributor

@mabdinur mabdinur commented Nov 5, 2024

What does this PR do?

Addresses a broken edge case introduced by: #4027.

Edge Case: When a global service name and a global version are set (for example via DD_SERVICE and DD_VERSION) and a span is initialized without a service name, the global version MUST be set on the span. As of v2.5.0 this is no longer the case.

Motivation:

This bug was detected when v2.5.0 was released and the following system failed: Test_Config_UnifiedServiceTagging::test_specific_version.

Change log entry

Fix

  • Tracing: Ensure the global version tag is set on spans that have the global service name.

Additional Notes:

How to test the change?

@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.73%. Comparing base (dedb0bb) to head (f909bd2).
Report is 169 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4075      +/-   ##
==========================================
+ Coverage   97.72%   97.73%   +0.01%     
==========================================
  Files        1338     1338              
  Lines       80248    80265      +17     
  Branches     4016     4016              
==========================================
+ Hits        78420    78448      +28     
+ Misses       1828     1817      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@pr-commenter
Copy link

pr-commenter bot commented Nov 5, 2024

Benchmarks

Benchmark execution time: 2024-11-05 21:26:15

Comparing candidate commit f909bd2 in PR branch munir/fix-version-tagging with baseline commit dedb0bb in branch master.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 28 metrics, 2 unstable metrics.

scenario:tracing - Propagation - Datadog

  • 🟥 throughput [-2516.167op/s; -2418.738op/s] or [-7.662%; -7.366%]

@mabdinur mabdinur marked this pull request as ready for review November 6, 2024 01:44
@mabdinur mabdinur requested a review from a team as a code owner November 6, 2024 01:44
@mabdinur mabdinur requested a review from marcotc November 7, 2024 01:16
@marcotc marcotc merged commit 2b8486e into master Nov 13, 2024
274 checks passed
@marcotc marcotc deleted the munir/fix-version-tagging branch November 13, 2024 17:19
@github-actions github-actions bot added this to the 2.8.0 milestone Nov 13, 2024
TonyCTHsu pushed a commit that referenced this pull request Nov 28, 2024
fix: Apply DD_VERSION on all spans that use the default or global service name
@TonyCTHsu TonyCTHsu modified the milestones: 2.8.0, 2.7.1 Nov 28, 2024
@TonyCTHsu TonyCTHsu mentioned this pull request Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants