fix: Apply DD_VERSION on all spans that use the default or global service name #4075
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Addresses a broken edge case introduced by: #4027.
Edge Case: When a global service name and a global version are set (for example via DD_SERVICE and DD_VERSION) and a span is initialized without a service name, the global version MUST be set on the span. As of v2.5.0 this is no longer the case.
Motivation:
This bug was detected when v2.5.0 was released and the following system failed: Test_Config_UnifiedServiceTagging::test_specific_version.
Change log entry
Fix
Additional Notes:
How to test the change?