DEBUG-3182 move Rails utils to core #4261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
p-datadog
force-pushed
the
rails-utils-core
branch
from
5e08393 to
d632d59
Compare
Datadog ReportBranch report: ✅ 0 Failed, 22125 Passed, 1475 Skipped, 5m 31.98s Total Time |
BenchmarksBenchmark execution time: 2025-01-07 22:21:20 Comparing candidate commit 5179713 in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 30 metrics, 2 unstable metrics. scenario:profiler - sample timeline=false
|
y9v
approved these changes
Jan 7, 2025
p-datadog
force-pushed
the
rails-utils-core
branch
from
2bd0872 to
7bf4169
Compare
This reverts commit 7bf4169.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4261 +/- ##
=======================================
Coverage 97.74% 97.75%
=======================================
Files 1353 1352 -1
Lines 82392 82378 -14
Branches 4224 4224
=======================================
- Hits 80536 80526 -10
+ Misses 1856 1852 -4 ☔ View full report in Codecov by Sentry. |
marcotc
approved these changes
Jan 8, 2025
p-datadog
pushed a commit
to p-datadog/dd-trace-rb
that referenced
this pull request
Jan 9, 2025
* master: DEBUG-3210 DI: change logging to be appropriate for customer inspection (DataDog#4266) Report timing information if try_wait_until times out (DataDog#4265) Move simplecov patch to an overlay in our tree instead of using a forked simplecov repo (DataDog#4263) DEBUG-3251 dependency inject logger into DI component (DataDog#4262) DEBUG-3182 move Rails utils to core (DataDog#4261) add supported versions workflow (DataDog#4210) DEBUG-3305 remove dependency on benchmark (DataDog#4259) Fix case & grammar in issue template (DataDog#4244) [🤖] Update Latest Dependency: https://github.com/DataDog/dd-trace-rb/actions/runs/12614773826
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Moves Tracing::Contrib::Rails::Utils to Core
Motivation:
DI requires a similar loading logic for contribs as Tracing (currently we have one DI contrib which is ActiveRecord). I am working on having a DI railtie that would load the DI AR contrib late in application bootstrap, like tracing is doing with its contribs. To detect whether Railtie functionality is available, I need the Contrib::Rails::Utils methods.
Change log entry
None
Additional Notes:
How to test the change?