Convert jmx to in-app types for replay_check_run #7275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
AlexandreYang
commented
Aug 4, 2020
| ignite.threads.tasks,count,10,task,,Approximate total number of tasks that have been scheduled for execution.,0,ignite, | ||
| ignite.threads.completed_tasks,count,10,task,,Approximate total number of tasks that have completed execution.,0,ignite, | ||
| ignite.threads.tasks,rate,10,task,,Approximate total number of tasks that have been scheduled for execution.,0,ignite, | ||
| ignite.threads.completed_tasks,rate,10,task,,Approximate total number of tasks that have completed execution.,0,ignite, |
There was a problem hiding this comment.
Fixing metadata.csv: JMX monotonic_count -> DSD count -> in-app rate
There was a problem hiding this comment.
but wasnt this causing an override?
There was a problem hiding this comment.
Before this change, we were trying to compare monotonic_count (from Agent check) to count (from metadata.csv)
Now with this change, we are trying to compare monotonic_count (from Agent check) converted to rate to rate (from metadata.csv)
FlorianVeaux
reviewed
Aug 4, 2020
AlexandreYang
force-pushed
the
alex/jmx_assert_metrics_using_metadata
branch
from
9714b9a to
4fa3337
Compare
hithwen
reviewed
Aug 4, 2020
FlorianVeaux
approved these changes
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Convert jmx to in-app types
See test results here: #7277
Motivation
replay_check_run should return in-app types
Additional info
There was an attempt to harmonise the metrics on
jmxfetchside, but the PR has been finalised closed to avoid adding complexity in jmxfetch: DataDog/jmxfetch#281