Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix service check name for Console and Json Reporters #281

Closed
wants to merge 3 commits into from

Conversation

AlexandreYang
Copy link
Member

What this PR does

Build service check name earlier so all reporters will have the right service check name.

Motiviation

Currently, reporters other than StatsdReporter.java will report a wrong service check name (Service check name without .can_connect suffix).

    "service_checks" : [ {
      "check" : "activemq",
      "message" : null,
      "host_name" : "default",
      "timestamp" : 1583840340,
      "status" : "OK",
      "tags" : [ "jmx_server:localhost", "instance:activemq-localhost-1616" ]
    } ]

should be

    "service_checks" : [ {
      "check" : "activemq.can_connect",
      "message" : null,
      "host_name" : "default",
      "timestamp" : 1583840340,
      "status" : "OK",
      "tags" : [ "jmx_server:localhost", "instance:activemq-localhost-1616" ]
    } ]

@AlexandreYang AlexandreYang changed the title Fix service check name Fix service check name for Console and Json Reporters Mar 10, 2020
@AlexandreYang
Copy link
Member Author

Closing in favor of #281

@ofek
Copy link
Contributor

ofek commented Mar 10, 2020

#278

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants