Fix service checks in the JSON reporter #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses the wrong service check name and doesn't produce the proper value compared to the statsd reporter.
truthbk
reviewed
Mar 3, 2020
| @@ -38,14 +40,25 @@ protected void sendMetricPoint( | |||
| metrics.add(metric); | |||
| } | |||
|
|
|||
| private ServiceCheck.Status statusToServiceCheckStatus(String status) { | |||
There was a problem hiding this comment.
I know this is definitely not your fault, but to avoid inconsistencies like these down the line, I think I'd rather avoid duping code. Maybe this statusToServiceCheckStatus could be a static method in org.datadog.jmxfetch.Status.
There was a problem hiding this comment.
I moved it to the reporter class, does that sound fine?
AlexandreYang
approved these changes
Mar 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the wrong service check name and doesn't produce the proper
value compared to the statsd reporter.