Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update procfs to 0.17 #1119

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Update procfs to 0.17 #1119

merged 1 commit into from
Dec 3, 2024

Conversation

blt
Copy link
Collaborator

@blt blt commented Dec 2, 2024

What does this PR do?

This commit updates procfs dependency to 0.17. #1096 is now redundant.

Copy link
Collaborator Author

blt commented Dec 2, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@blt blt added the no-changelog label Dec 2, 2024 — with Graphite App
@blt blt marked this pull request as ready for review December 2, 2024 23:49
@blt blt requested a review from a team as a code owner December 2, 2024 23:49
Copy link
Contributor

@GeorgeHahn GeorgeHahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the switch to signed PIDs? This LGTM but that change is surprising; do we ever want a negative value in those places?

@blt
Copy link
Collaborator Author

blt commented Dec 3, 2024

Why the switch to signed PIDs? This LGTM but that change is surprising; do we ever want a negative value in those places?

That's the type they are in the crate. I guess back in the day I just felt, hey, who can have a negative pid? There's less coercion happening now at least, although we still don't allow users to specify a negative pid in the interface.

This commit updates procfs dependency to 0.17. #1096 is now redundant.

Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
@blt blt force-pushed the blt/update_procfs_to_0.17 branch from 63f1ce0 to 3f145ec Compare December 3, 2024 17:35
@blt blt merged commit de62f34 into main Dec 3, 2024
18 checks passed
@blt blt deleted the blt/update_procfs_to_0.17 branch December 3, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants