Read all cgroup v2 metrics that can be read #1120
Open
+828
−657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merged
blt
force-pushed
the
blt/update_procfs_to_0.17
branch
from
63f1ce0
to
3f145ec
Compare
blt
force-pushed
the
blt/read_all_cgroup_v2_metrics_that_can_be_read
branch
from
b4b6486
to
2a32d9b
Compare
scottopell
requested changes
Dec 3, 2024
scottopell
reviewed
Dec 3, 2024
| mem_stat.stat.total_inactive_file | ||
| }; | ||
| let usage = mem_stat.usage_in_bytes; | ||
| let working_set = if usage < inactive_file { |
There was a problem hiding this comment.
Can we preserve working_set calculation as well?
There was a problem hiding this comment.
Oh hmm. So in the new cgroup sampler we never actually inspect any of the data being read, just immediately rip it out to metrics. I think we could calculate this easily enough in-platform or we could make a special read to preserve this.
Happy to move forward with either, but you're right. working_set won't be present in the new telemetry stream.
This commit removes any arbitration of the cgroup v2 heirarchy for a given process. We instead read anything that can be read, looping over all cgroup files present but not following the heirarchy down. Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
This commit splits the Sampler so that cgroup collection is in a separate implementation from procfs, which has gotten sprawling. I have maintained the existing Sampler interface and hidden the two new implementations inside of it, although we might choose to expose them at some point in the future. Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
blt
force-pushed
the
blt/read_all_cgroup_v2_metrics_that_can_be_read
branch
from
8adc60d
to
6b05a98
Compare
Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This commit removes any arbitration of the cgroup v2 heirarchy for a
given process. We instead read anything that can be read, looping over
all cgroup files present but not following the hierarchy down.
Metric names will change but they will now reflect underlying system reality.