Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI failure: update libdatadog_profiling.so SONAME #624

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

gleocadie
Copy link
Contributor

@gleocadie gleocadie commented Sep 12, 2024

What does this PR do?

Update the SONAME in the libdatadog_profiling.so file.

Motivation

Fix CI.

Cargo produces the libdatadog_profiling_ffi.so then late renames it into libdatadog_profiling.so. But the SONAME in libdatadog_profiling.so is libdatadog_profiling_ffi.so (same as the original).
So when building the symbolizer (for example) and linking against libdatadog_profiling.so, the linker will register libdatadog_profiling_ffi.so as NEEDED

image

But it's not its name anymore, so we have to patch libdatadog_profiling.so to change its SONAME into libdatadog_profiling.so.

@pr-commenter
Copy link

pr-commenter bot commented Sep 12, 2024

Benchmarks

Comparison

Benchmark execution time: 2024-09-12 17:35:58

Comparing candidate commit 22c0362 in PR branch gleocadie/fix-symbolizer-in-ci with baseline commit 30b7bc4 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 22c0362 1726157777 gleocadie/fix-symbolizer-in-ci
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 72.827µs 73.098µs ± 0.112µs 73.077µs ± 0.029µs 73.112µs 73.214µs 73.512µs 74.166µs 1.49% 5.802 47.530 0.15% 0.008µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [73.082µs; 73.113µs] or [-0.021%; +0.021%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 22c0362 1726157777 gleocadie/fix-symbolizer-in-ci
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 280.485µs 281.106µs ± 0.397µs 281.064µs ± 0.130µs 281.193µs 281.539µs 282.266µs 284.572µs 1.25% 4.949 36.639 0.14% 0.028µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 3514051.723op/s 3557382.565op/s ± 4984.027op/s 3557914.630op/s ± 1645.439op/s 3559540.168op/s 3561911.536op/s 3564467.221op/s 3565256.989op/s 0.21% -4.890 35.978 0.14% 352.424op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 27.394µs 27.489µs ± 0.052µs 27.482µs ± 0.030µs 27.514µs 27.577µs 27.626µs 27.756µs 1.00% 1.135 3.056 0.19% 0.004µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 36028148.180op/s 36378079.137op/s ± 68375.394op/s 36388053.186op/s ± 40035.276op/s 36427096.365op/s 36473109.528op/s 36494157.130op/s 36504721.162op/s 0.32% -1.114 2.951 0.19% 4834.870op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 16.845µs 16.875µs ± 0.040µs 16.854µs ± 0.005µs 16.891µs 16.951µs 17.021µs 17.078µs 1.32% 1.980 4.289 0.24% 0.003µs 1 200
normalization/normalize_name/normalize_name/good throughput 58555989.613op/s 59258581.655op/s ± 139582.582op/s 59331350.636op/s ± 16422.326op/s 59343718.318op/s 59354140.168op/s 59361320.085op/s 59365359.365op/s 0.06% -1.964 4.178 0.23% 9869.979op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [281.051µs; 281.161µs] or [-0.020%; +0.020%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [3556691.826op/s; 3558073.303op/s] or [-0.019%; +0.019%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [27.482µs; 27.496µs] or [-0.026%; +0.026%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [36368602.965op/s; 36387555.309op/s] or [-0.026%; +0.026%] None None None
normalization/normalize_name/normalize_name/good execution_time [16.870µs; 16.881µs] or [-0.033%; +0.033%] None None None
normalization/normalize_name/normalize_name/good throughput [59239236.852op/s; 59277926.459op/s] or [-0.033%; +0.033%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 22c0362 1726157777 gleocadie/fix-symbolizer-in-ci
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.713µs 24.177µs ± 10.654µs 19.405µs ± 0.280µs 20.167µs 43.596µs 46.334µs 101.370µs 422.39% 3.511 18.396 43.96% 0.753µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [22.701µs; 25.654µs] or [-6.107%; +6.107%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 22c0362 1726157777 gleocadie/fix-symbolizer-in-ci
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 35.956µs 36.404µs ± 0.788µs 36.042µs ± 0.050µs 36.124µs 38.066µs 38.099µs 39.471µs 9.51% 1.776 1.481 2.16% 0.056µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [36.295µs; 36.514µs] or [-0.300%; +0.300%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 22c0362 1726157777 gleocadie/fix-symbolizer-in-ci
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 291.629ns 301.215ns ± 12.843ns 294.559ns ± 1.733ns 305.254ns 333.603ns 338.025ns 338.742ns 15.00% 1.615 1.395 4.25% 0.908ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [299.435ns; 302.995ns] or [-0.591%; +0.591%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 22c0362 1726157777 gleocadie/fix-symbolizer-in-ci
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 1.169µs 1.339µs ± 0.055µs 1.357µs ± 0.030µs 1.382µs 1.408µs 1.428µs 1.429µs 5.28% -0.724 0.155 4.08% 0.004µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [1.331µs; 1.346µs] or [-0.567%; +0.567%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 22c0362 1726157777 gleocadie/fix-symbolizer-in-ci
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.681µs 2.727µs ± 0.015µs 2.729µs ± 0.006µs 2.733µs 2.748µs 2.757µs 2.761µs 1.18% -1.057 2.013 0.54% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.725µs; 2.729µs] or [-0.075%; +0.075%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 22c0362 1726157777 gleocadie/fix-symbolizer-in-ci
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 8.884ms 8.923ms ± 0.013ms 8.923ms ± 0.008ms 8.930ms 8.945ms 8.953ms 8.958ms 0.39% -0.106 0.050 0.15% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [8.921ms; 8.925ms] or [-0.021%; +0.021%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 22c0362 1726157777 gleocadie/fix-symbolizer-in-ci
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 142.816µs 143.868µs ± 0.427µs 143.827µs ± 0.180µs 144.006µs 144.417µs 145.555µs 146.395µs 1.78% 2.089 9.101 0.30% 0.030µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [143.809µs; 143.927µs] or [-0.041%; +0.041%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 22c0362 1726157777 gleocadie/fix-symbolizer-in-ci
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.345µs 3.218µs ± 1.579µs 3.059µs ± 0.023µs 3.082µs 3.163µs 13.917µs 18.355µs 500.10% 8.025 65.444 48.94% 0.112µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [2.999µs; 3.436µs] or [-6.800%; +6.800%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 22c0362 1726157777 gleocadie/fix-symbolizer-in-ci
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 1.212µs 1.214µs ± 0.001µs 1.213µs ± 0.001µs 1.214µs 1.216µs 1.217µs 1.221µs 0.65% 1.595 4.198 0.11% 0.000µs 1 200
credit_card/is_card_number/ throughput 819036055.273op/s 824053814.718op/s ± 913768.852op/s 824378110.038op/s ± 499469.243op/s 824687396.905op/s 824993576.227op/s 825156997.511op/s 825387117.372op/s 0.12% -1.583 4.119 0.11% 64613.215op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 108.063µs 109.375µs ± 0.863µs 109.160µs ± 0.524µs 109.854µs 110.880µs 112.119µs 112.653µs 3.20% 1.112 1.148 0.79% 0.061µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 8876845.540op/s 9143444.902op/s ± 71561.508op/s 9160831.588op/s ± 44013.392op/s 9197848.394op/s 9228851.583op/s 9240699.066op/s 9253877.928op/s 1.02% -1.068 0.998 0.78% 5060.163op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 102.101µs 103.016µs ± 0.734µs 102.800µs ± 0.337µs 103.239µs 104.365µs 104.884µs 106.839µs 3.93% 1.548 3.135 0.71% 0.052µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 9359919.963op/s 9707681.406op/s ± 68420.016op/s 9727642.874op/s ± 32033.735op/s 9754789.235op/s 9779663.826op/s 9793171.124op/s 9794198.896op/s 0.68% -1.492 2.791 0.70% 4838.026op/s 1 200
credit_card/is_card_number/37828224631 execution_time 1.211µs 1.213µs ± 0.001µs 1.213µs ± 0.001µs 1.214µs 1.216µs 1.217µs 1.221µs 0.69% 1.904 5.791 0.12% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 818766668.282op/s 824164007.372op/s ± 978091.467op/s 824414962.273op/s ± 473119.211op/s 824863084.108op/s 825087974.588op/s 825378724.611op/s 825447365.942op/s 0.13% -1.889 5.690 0.12% 69161.511op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 98.054µs 99.190µs ± 0.638µs 98.996µs ± 0.295µs 99.428µs 100.376µs 101.562µs 102.320µs 3.36% 1.962 5.329 0.64% 0.045µs 1 200
credit_card/is_card_number/378282246310005 throughput 9773245.228op/s 10082046.004op/s ± 64093.084op/s 10101376.314op/s ± 30148.437op/s 10127480.159op/s 10142688.246op/s 10155226.809op/s 10198431.178op/s 0.96% -1.896 4.969 0.63% 4532.065op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 100.040µs 100.552µs ± 0.370µs 100.444µs ± 0.184µs 100.721µs 101.276µs 101.685µs 102.465µs 2.01% 1.616 3.710 0.37% 0.026µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 9759444.336op/s 9945236.525op/s ± 36358.310op/s 9955814.611op/s ± 18285.644op/s 9968496.312op/s 9987200.161op/s 9989563.314op/s 9995984.613op/s 0.40% -1.582 3.518 0.36% 2570.921op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 19.234µs 19.402µs ± 0.131µs 19.396µs ± 0.085µs 19.474µs 19.636µs 19.784µs 19.899µs 2.60% 0.915 0.974 0.67% 0.009µs 1 200
credit_card/is_card_number/x371413321323331 throughput 50253634.484op/s 51542093.533op/s ± 344602.427op/s 51557824.678op/s ± 226271.819op/s 51839945.657op/s 51979509.156op/s 51987247.043op/s 51990856.070op/s 0.84% -0.873 0.841 0.67% 24367.071op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 1.212µs 1.213µs ± 0.000µs 1.213µs ± 0.000µs 1.213µs 1.213µs 1.214µs 1.214µs 0.12% 0.312 0.484 0.03% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 823611761.779op/s 824658035.492op/s ± 247085.406op/s 824589298.888op/s ± 171327.297op/s 824904163.781op/s 825012589.021op/s 825077334.268op/s 825131791.466op/s 0.07% -0.310 0.476 0.03% 17471.577op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 89.154µs 91.052µs ± 0.647µs 91.134µs ± 0.351µs 91.484µs 91.931µs 92.518µs 92.984µs 2.03% -0.638 0.916 0.71% 0.046µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 10754583.628op/s 10983311.983op/s ± 78433.176op/s 10972868.508op/s ± 42123.510op/s 11014306.891op/s 11143048.993op/s 11204910.803op/s 11216515.769op/s 2.22% 0.692 0.957 0.71% 5546.063op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 82.215µs 84.890µs ± 0.581µs 84.970µs ± 0.408µs 85.336µs 85.621µs 85.915µs 86.335µs 1.61% -0.716 1.306 0.68% 0.041µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 11582823.223op/s 11780475.904op/s ± 81050.188op/s 11768878.194op/s ± 56573.335op/s 11836029.805op/s 11910812.663op/s 11981588.235op/s 12163281.959op/s 3.35% 0.775 1.538 0.69% 5731.114op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 1.212µs 1.213µs ± 0.001µs 1.213µs ± 0.000µs 1.213µs 1.213µs 1.214µs 1.222µs 0.77% 7.651 84.225 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 818432838.050op/s 824642313.078op/s ± 543480.272op/s 824721321.616op/s ± 222424.833op/s 824937372.696op/s 825057426.170op/s 825157846.214op/s 825192131.301op/s 0.06% -7.596 83.374 0.07% 38429.859op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 79.510µs 80.800µs ± 0.510µs 80.742µs ± 0.290µs 81.059µs 81.431µs 82.231µs 83.633µs 3.58% 1.683 7.853 0.63% 0.036µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 11956964.570op/s 12376693.834op/s ± 77357.023op/s 12385127.945op/s ± 44419.527op/s 12424630.588op/s 12468755.274op/s 12535988.266op/s 12577076.432op/s 1.55% -1.554 7.119 0.62% 5469.968op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 100.103µs 100.573µs ± 0.341µs 100.511µs ± 0.236µs 100.783µs 101.175µs 101.506µs 102.182µs 1.66% 1.180 2.102 0.34% 0.024µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 9786415.398op/s 9943171.251op/s ± 33582.507op/s 9949177.116op/s ± 23404.269op/s 9971026.942op/s 9981994.082op/s 9989120.849op/s 9989713.592op/s 0.41% -1.153 1.971 0.34% 2374.642op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 19.239µs 19.425µs ± 0.119µs 19.408µs ± 0.083µs 19.495µs 19.641µs 19.655µs 19.793µs 1.98% 0.390 -0.547 0.61% 0.008µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 50522872.335op/s 51482384.749op/s ± 314285.684op/s 51525522.058op/s ± 220952.570op/s 51725407.871op/s 51951900.507op/s 51973543.867op/s 51977005.697op/s 0.88% -0.366 -0.579 0.61% 22223.354op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [1.213µs; 1.214µs] or [-0.015%; +0.015%] None None None
credit_card/is_card_number/ throughput [823927175.143op/s; 824180454.292op/s] or [-0.015%; +0.015%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [109.255µs; 109.494µs] or [-0.109%; +0.109%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [9133527.165op/s; 9153362.639op/s] or [-0.108%; +0.108%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [102.915µs; 103.118µs] or [-0.099%; +0.099%] None None None
credit_card/is_card_number/ 378282246310005 throughput [9698199.050op/s; 9717163.763op/s] or [-0.098%; +0.098%] None None None
credit_card/is_card_number/37828224631 execution_time [1.213µs; 1.214µs] or [-0.016%; +0.016%] None None None
credit_card/is_card_number/37828224631 throughput [824028453.301op/s; 824299561.442op/s] or [-0.016%; +0.016%] None None None
credit_card/is_card_number/378282246310005 execution_time [99.102µs; 99.279µs] or [-0.089%; +0.089%] None None None
credit_card/is_card_number/378282246310005 throughput [10073163.319op/s; 10090928.689op/s] or [-0.088%; +0.088%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [100.501µs; 100.603µs] or [-0.051%; +0.051%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [9940197.613op/s; 9950275.437op/s] or [-0.051%; +0.051%] None None None
credit_card/is_card_number/x371413321323331 execution_time [19.384µs; 19.421µs] or [-0.093%; +0.093%] None None None
credit_card/is_card_number/x371413321323331 throughput [51494334.951op/s; 51589852.115op/s] or [-0.093%; +0.093%] None None None
credit_card/is_card_number_no_luhn/ execution_time [1.213µs; 1.213µs] or [-0.004%; +0.004%] None None None
credit_card/is_card_number_no_luhn/ throughput [824623791.831op/s; 824692279.153op/s] or [-0.004%; +0.004%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [90.962µs; 91.142µs] or [-0.099%; +0.099%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [10972441.899op/s; 10994182.067op/s] or [-0.099%; +0.099%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [84.810µs; 84.971µs] or [-0.095%; +0.095%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [11769243.127op/s; 11791708.680op/s] or [-0.095%; +0.095%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [1.213µs; 1.213µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [824566991.939op/s; 824717634.217op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [80.729µs; 80.871µs] or [-0.088%; +0.088%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [12365972.894op/s; 12387414.773op/s] or [-0.087%; +0.087%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [100.525µs; 100.620µs] or [-0.047%; +0.047%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [9938517.038op/s; 9947825.463op/s] or [-0.047%; +0.047%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [19.408µs; 19.441µs] or [-0.085%; +0.085%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [51438827.776op/s; 51525941.723op/s] or [-0.085%; +0.085%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 22c0362 1726157777 gleocadie/fix-symbolizer-in-ci
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 578.571µs 579.512µs ± 0.351µs 579.558µs ± 0.205µs 579.723µs 579.983µs 580.384µs 580.852µs 0.22% -0.034 1.035 0.06% 0.025µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1721608.947op/s 1725591.382op/s ± 1044.121op/s 1725451.915op/s ± 609.577op/s 1726244.628op/s 1727338.402op/s 1728223.702op/s 1728397.276op/s 0.17% 0.039 1.029 0.06% 73.831op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 463.845µs 464.800µs ± 0.349µs 464.780µs ± 0.216µs 465.004µs 465.354µs 465.558µs 466.234µs 0.31% 0.337 0.745 0.07% 0.025µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2144847.900op/s 2151466.307op/s ± 1617.227op/s 2151555.940op/s ± 1000.152op/s 2152453.220op/s 2153976.915op/s 2154702.075op/s 2155891.860op/s 0.20% -0.331 0.732 0.07% 114.355op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 184.002µs 184.352µs ± 0.161µs 184.366µs ± 0.093µs 184.442µs 184.631µs 184.750µs 184.813µs 0.24% 0.035 -0.065 0.09% 0.011µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5410885.023op/s 5424418.589op/s ± 4725.865op/s 5423981.810op/s ± 2736.758op/s 5426950.215op/s 5432786.687op/s 5434181.770op/s 5434719.844op/s 0.20% -0.030 -0.068 0.09% 334.169op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 46.654µs 46.835µs ± 0.061µs 46.832µs ± 0.040µs 46.875µs 46.941µs 46.966µs 47.007µs 0.37% 0.025 0.003 0.13% 0.004µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 21273543.735op/s 21351640.427op/s ± 27866.383op/s 21352758.244op/s ± 18029.736op/s 21369328.238op/s 21395208.603op/s 21416229.919op/s 21434228.534op/s 0.38% -0.017 0.005 0.13% 1970.451op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 44.181µs 44.485µs ± 0.116µs 44.499µs ± 0.071µs 44.562µs 44.646µs 44.760µs 44.778µs 0.63% -0.278 -0.113 0.26% 0.008µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 22332495.120op/s 22479854.434op/s ± 58553.399op/s 22472566.655op/s ± 35703.985op/s 22518738.467op/s 22577946.903op/s 22626112.009op/s 22634118.469op/s 0.72% 0.292 -0.110 0.26% 4140.351op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [579.463µs; 579.560µs] or [-0.008%; +0.008%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1725446.677op/s; 1725736.088op/s] or [-0.008%; +0.008%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [464.751µs; 464.848µs] or [-0.010%; +0.010%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2151242.175op/s; 2151690.439op/s] or [-0.010%; +0.010%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [184.329µs; 184.374µs] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5423763.630op/s; 5425073.549op/s] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [46.826µs; 46.843µs] or [-0.018%; +0.018%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [21347778.414op/s; 21355502.439op/s] or [-0.018%; +0.018%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [44.469µs; 44.501µs] or [-0.036%; +0.036%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [22471739.496op/s; 22487969.372op/s] or [-0.036%; +0.036%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.17%. Comparing base (30b7bc4) to head (22c0362).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #624      +/-   ##
==========================================
+ Coverage   73.15%   73.17%   +0.01%     
==========================================
  Files         252      252              
  Lines       35959    35959              
==========================================
+ Hits        26307    26314       +7     
+ Misses       9652     9645       -7     
Components Coverage Δ
crashtracker 20.53% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 90.12% <ø> (ø)
data-pipeline-ffi 0.00% <ø> (ø)
ddcommon 83.08% <ø> (ø)
ddcommon-ffi 69.52% <ø> (ø)
ddtelemetry 59.10% <ø> (ø)
ipc 83.63% <ø> (ø)
profiling 84.26% <ø> (ø)
profiling-ffi 77.42% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 40.12% <ø> (ø)
sidecar-ffi 0.00% <ø> (ø)
spawn-worker 50.36% <ø> (ø)
tinybytes 91.66% <ø> (ø)
trace-mini-agent 70.88% <ø> (ø)
trace-normalization 98.25% <ø> (ø)
trace-obfuscation 95.73% <ø> (ø)
trace-protobuf 77.67% <ø> (ø)
trace-utils 92.86% <ø> (ø)

@gleocadie gleocadie force-pushed the gleocadie/fix-symbolizer-in-ci branch 3 times, most recently from 727a279 to f6c6ad0 Compare September 12, 2024 16:06
@gleocadie gleocadie marked this pull request as ready for review September 12, 2024 16:16
@gleocadie gleocadie requested a review from a team as a code owner September 12, 2024 16:16
@gleocadie gleocadie changed the title Investigate symbolizer issue in CI Fix CI failure: update libdatadog_profiling.so SONAME Sep 12, 2024
@gleocadie gleocadie requested a review from a team as a code owner September 12, 2024 17:11
@gleocadie gleocadie force-pushed the gleocadie/fix-symbolizer-in-ci branch 2 times, most recently from b5c95aa to 22c0362 Compare September 12, 2024 17:26
Copy link
Contributor

@sanchda sanchda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'd be ideal to move away from patching binaries once we produce them, but if we're already renaming the file, then we absolutely need to patch it in order for the soname and file name to be in conformance (otherwise, -l won't work properly at all).

@sanchda
Copy link
Contributor

sanchda commented Sep 12, 2024

Thank you for fixing this

@morrisonlevi
Copy link
Contributor

As discussed in Slack, I think we should do things the "right" way if we can, but that's more work that may have unknowns. Let's get this incrementally fixed and try to do things better in another PR.

@gleocadie gleocadie merged commit 0c03f15 into main Sep 12, 2024
57 checks passed
@gleocadie gleocadie deleted the gleocadie/fix-symbolizer-in-ci branch September 12, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants