-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI failure: update libdatadog_profiling.so
SONAME
#624
Conversation
BenchmarksComparisonBenchmark execution time: 2024-09-12 17:35:58 Comparing candidate commit 22c0362 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 2 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
BaselineOmitted due to size. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #624 +/- ##
==========================================
+ Coverage 73.15% 73.17% +0.01%
==========================================
Files 252 252
Lines 35959 35959
==========================================
+ Hits 26307 26314 +7
+ Misses 9652 9645 -7
|
727a279
to
f6c6ad0
Compare
f6c6ad0
to
22c0362
Compare
libdatadog_profiling.so
SONAME
b5c95aa
to
22c0362
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it'd be ideal to move away from patching binaries once we produce them, but if we're already renaming the file, then we absolutely need to patch it in order for the soname and file name to be in conformance (otherwise, -l
won't work properly at all).
Thank you for fixing this |
As discussed in Slack, I think we should do things the "right" way if we can, but that's more work that may have unknowns. Let's get this incrementally fixed and try to do things better in another PR. |
What does this PR do?
Update the
SONAME
in thelibdatadog_profiling.so
file.Motivation
Fix CI.
Cargo produces the
libdatadog_profiling_ffi.so
then late renames it intolibdatadog_profiling.so
. But theSONAME
inlibdatadog_profiling.so
islibdatadog_profiling_ffi.so
(same as the original).So when building the symbolizer (for example) and linking against
libdatadog_profiling.so
, the linker will registerlibdatadog_profiling_ffi.so
asNEEDED
But it's not its name anymore, so we have to patch
libdatadog_profiling.so
to change itsSONAME
intolibdatadog_profiling.so
.