Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SONAME for artifact produced in Gitlab #628

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Fix SONAME for artifact produced in Gitlab #628

merged 1 commit into from
Sep 13, 2024

Conversation

gleocadie
Copy link
Contributor

@gleocadie gleocadie commented Sep 13, 2024 •
edited
Loading

What does this PR do?

Fix SONAME for artifacts produced in Gitlab.

Motivation

Since in GitLab we do not use the new builder, we have to update the build-profiling.sh shell script in order to port this change.

Additional Notes

🤷

How to test the change?

Download the artifact from Gitlab and run readelf -d libdatadog_profiling.so
image

@gleocadie gleocadie requested a review from a team as a code owner September 13, 2024 07:18
@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.19%. Comparing base (1d8c245) to head (b7140d8).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #628      +/-   ##
==========================================
+ Coverage   73.17%   73.19%   +0.01%     
==========================================
  Files         252      252              
  Lines       35942    35942              
==========================================
+ Hits        26300    26307       +7     
+ Misses       9642     9635       -7
Components Coverage Δ
crashtracker 20.53% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 90.12% <ø> (ø)
data-pipeline-ffi 0.00% <ø> (ø)
ddcommon 83.08% <ø> (ø)
ddcommon-ffi 69.52% <ø> (ø)
ddtelemetry 59.10% <ø> (ø)
ipc 83.63% <ø> (ø)
profiling 84.26% <ø> (ø)
profiling-ffi 77.42% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 40.12% <ø> (ø)
sidecar-ffi 0.00% <ø> (ø)
spawn-worker 50.36% <ø> (ø)
tinybytes 91.66% <ø> (ø)
trace-mini-agent 70.88% <ø> (ø)
trace-normalization 98.25% <ø> (ø)
trace-obfuscation 95.73% <ø> (ø)
trace-protobuf 77.67% <ø> (ø)
trace-utils 93.28% <ø> (ø)

@gleocadie gleocadie force-pushed the gleocadie/fix-soname-for-artifacts-in-gitlab branch 7 times, most recently from 4e7f7d1 to d0f7740 Compare September 13, 2024 08:47
ivoanjo
ivoanjo approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM Thanks for getting to the bottom of this whole soname thing :)

build-profiling-ffi.sh Outdated
Comment on lines 179 to 186
if [[ "$target" == "aarch64-unknown-linux-gnu" ]]; then
mkdir patchelf
cd patchelf
curl -OL https://github.com/NixOS/patchelf/releases/download/0.18.0/patchelf-0.18.0-aarch64.tar.gz
tar zxvf patchelf-0.18.0-aarch64.tar.gz
patchelf_bin=`pwd`"/bin/patchelf"
cd ..
fi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: Maybe add here a echo "Downloading patchelf to workaround bug in centos patchelf" in case someone gets surprised by this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the Docker image instead so we only have the call to patchelf

@ivoanjo ivoanjo mentioned this pull request Sep 13, 2024
Closed
2 tasks
@gleocadie gleocadie force-pushed the gleocadie/fix-soname-for-artifacts-in-gitlab branch from d0f7740 to b7140d8 Compare September 13, 2024 10:50
@pr-commenter
Copy link

pr-commenter bot commented Sep 13, 2024

Benchmarks

Comparison

Benchmark execution time: 2024-09-13 11:01:49

Comparing candidate commit b7140d8 in PR branch gleocadie/fix-soname-for-artifacts-in-gitlab with baseline commit 1d8c245 in branch main.

Found 4 performance improvements and 0 performance regressions! Performance is the same for 47 metrics, 2 unstable metrics.

scenario:credit_card/is_card_number/37828224631000521389798

  • 🟩 execution_time [-8.867µs; -8.708µs] or [-8.097%; -7.952%]
  • 🟩 throughput [+789489.719op/s; +804308.495op/s] or [+8.645%; +8.807%]

scenario:credit_card/is_card_number_no_luhn/37828224631000521389798

  • 🟩 execution_time [-8.942µs; -8.808µs] or [-8.172%; -8.050%]
  • 🟩 throughput [+800579.843op/s; +813032.673op/s] or [+8.760%; +8.896%]

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz b7140d8 1726224597 gleocadie/fix-soname-for-artifacts-in-gitlab
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 143.055µs 144.126µs ± 0.610µs 144.063µs ± 0.164µs 144.246µs 144.620µs 146.802µs 150.208µs 4.27% 5.994 51.902 0.42% 0.043µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [144.042µs; 144.211µs] or [-0.059%; +0.059%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz b7140d8 1726224597 gleocadie/fix-soname-for-artifacts-in-gitlab
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 292.148ns 303.374ns ± 13.595ns 297.778ns ± 3.701ns 304.522ns 334.185ns 348.660ns 350.153ns 17.59% 1.955 3.164 4.47% 0.961ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [301.490ns; 305.258ns] or [-0.621%; +0.621%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz b7140d8 1726224597 gleocadie/fix-soname-for-artifacts-in-gitlab
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 35.291µs 35.794µs ± 0.920µs 35.378µs ± 0.030µs 35.410µs 37.708µs 37.730µs 39.679µs 12.16% 1.819 1.805 2.56% 0.065µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [35.666µs; 35.921µs] or [-0.356%; +0.356%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz b7140d8 1726224597 gleocadie/fix-soname-for-artifacts-in-gitlab
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 578.513µs 579.623µs ± 0.374µs 579.669µs ± 0.196µs 579.844µs 580.193µs 580.329µs 580.541µs 0.15% -0.567 0.473 0.06% 0.026µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1722531.967op/s 1725260.574op/s ± 1112.325op/s 1725122.720op/s ± 582.479op/s 1725762.109op/s 1727468.138op/s 1728374.768op/s 1728568.319op/s 0.20% 0.571 0.478 0.06% 78.653op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 464.501µs 465.158µs ± 0.338µs 465.119µs ± 0.203µs 465.352µs 465.645µs 465.984µs 467.594µs 0.53% 2.043 12.182 0.07% 0.024µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2138607.665op/s 2149806.968op/s ± 1561.721op/s 2149986.449op/s ± 939.618op/s 2150841.211op/s 2151939.427op/s 2152428.820op/s 2152849.358op/s 0.13% -2.022 11.992 0.07% 110.430op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 183.974µs 184.244µs ± 0.141µs 184.247µs ± 0.099µs 184.345µs 184.468µs 184.591µs 184.605µs 0.19% 0.018 -0.320 0.08% 0.010µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5416984.576op/s 5427580.691op/s ± 4164.823op/s 5427486.474op/s ± 2924.301op/s 5430792.526op/s 5434803.875op/s 5435278.666op/s 5435560.278op/s 0.15% -0.015 -0.323 0.08% 294.497op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 46.445µs 46.650µs ± 0.085µs 46.654µs ± 0.053µs 46.706µs 46.782µs 46.830µs 46.873µs 0.47% -0.122 -0.098 0.18% 0.006µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 21334259.734op/s 21436423.109op/s ± 38935.434op/s 21434316.021op/s ± 24292.895op/s 21458888.633op/s 21503407.699op/s 21521486.509op/s 21530915.264op/s 0.45% 0.132 -0.099 0.18% 2753.151op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 44.220µs 44.433µs ± 0.107µs 44.426µs ± 0.069µs 44.494µs 44.602µs 44.738µs 44.914µs 1.10% 0.983 2.282 0.24% 0.008µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 22264706.581op/s 22506081.755op/s ± 54192.467op/s 22509338.562op/s ± 34659.095op/s 22545378.320op/s 22577680.203op/s 22613138.166op/s 22614281.270op/s 0.47% -0.960 2.188 0.24% 3831.986op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [579.571µs; 579.675µs] or [-0.009%; +0.009%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1725106.416op/s; 1725414.731op/s] or [-0.009%; +0.009%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [465.111µs; 465.205µs] or [-0.010%; +0.010%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2149590.529op/s; 2150023.408op/s] or [-0.010%; +0.010%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [184.225µs; 184.264µs] or [-0.011%; +0.011%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5427003.486op/s; 5428157.895op/s] or [-0.011%; +0.011%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [46.638µs; 46.661µs] or [-0.025%; +0.025%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [21431027.032op/s; 21441819.185op/s] or [-0.025%; +0.025%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [44.418µs; 44.448µs] or [-0.033%; +0.033%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [22498571.200op/s; 22513592.309op/s] or [-0.033%; +0.033%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz b7140d8 1726224597 gleocadie/fix-soname-for-artifacts-in-gitlab
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.606µs 2.665µs ± 0.023µs 2.672µs ± 0.009µs 2.676µs 2.710µs 2.715µs 2.720µs 1.80% -0.274 0.254 0.86% 0.002µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.662µs; 2.668µs] or [-0.119%; +0.119%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz b7140d8 1726224597 gleocadie/fix-soname-for-artifacts-in-gitlab
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 280.239µs 281.281µs ± 1.083µs 280.952µs ± 0.196µs 281.264µs 283.374µs 285.663µs 289.327µs 2.98% 3.827 18.927 0.38% 0.077µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 3456291.911op/s 3555220.113op/s ± 13497.268op/s 3559328.389op/s ± 2481.541op/s 3561462.179op/s 3564115.617op/s 3566023.434op/s 3568382.702op/s 0.25% -3.756 18.158 0.38% 954.401op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 27.497µs 27.717µs ± 0.070µs 27.726µs ± 0.047µs 27.768µs 27.811µs 27.853µs 27.908µs 0.66% -0.570 0.363 0.25% 0.005µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 35831740.905op/s 36079797.707op/s ± 91819.817op/s 36067364.311op/s ± 60771.394op/s 36138058.692op/s 36237276.916op/s 36338988.064op/s 36366979.880op/s 0.83% 0.586 0.384 0.25% 6492.642op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 16.821µs 16.870µs ± 0.033µs 16.861µs ± 0.022µs 16.891µs 16.937µs 16.957µs 16.970µs 0.65% 0.855 -0.005 0.20% 0.002µs 1 200
normalization/normalize_name/normalize_name/good throughput 58926614.577op/s 59276641.862op/s ± 116950.136op/s 59306970.645op/s ± 75621.077op/s 59375400.722op/s 59411997.466op/s 59445746.543op/s 59449527.351op/s 0.24% -0.848 -0.023 0.20% 8269.623op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [281.130µs; 281.431µs] or [-0.053%; +0.053%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [3553349.522op/s; 3557090.705op/s] or [-0.053%; +0.053%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [27.707µs; 27.726µs] or [-0.035%; +0.035%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [36067072.363op/s; 36092523.050op/s] or [-0.035%; +0.035%] None None None
normalization/normalize_name/normalize_name/good execution_time [16.865µs; 16.875µs] or [-0.027%; +0.027%] None None None
normalization/normalize_name/normalize_name/good throughput [59260433.698op/s; 59292850.026op/s] or [-0.027%; +0.027%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz b7140d8 1726224597 gleocadie/fix-soname-for-artifacts-in-gitlab
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 1.167µs 1.341µs ± 0.057µs 1.359µs ± 0.037µs 1.390µs 1.414µs 1.436µs 1.437µs 5.70% -0.632 -0.051 4.28% 0.004µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [1.333µs; 1.349µs] or [-0.594%; +0.594%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz b7140d8 1726224597 gleocadie/fix-soname-for-artifacts-in-gitlab
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 1.212µs 1.213µs ± 0.001µs 1.213µs ± 0.000µs 1.213µs 1.213µs 1.214µs 1.228µs 1.27% 11.394 146.900 0.10% 0.000µs 1 200
credit_card/is_card_number/ throughput 814312308.911op/s 824591974.977op/s ± 784520.303op/s 824635815.022op/s ± 228441.903op/s 824898245.385op/s 825004287.563op/s 825097029.983op/s 825150771.593op/s 0.06% -11.339 145.931 0.09% 55473.963op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 108.022µs 109.021µs ± 0.775µs 108.782µs ± 0.336µs 109.370µs 110.400µs 112.136µs 112.669µs 3.57% 1.917 4.856 0.71% 0.055µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 8875579.807op/s 9172976.631op/s ± 64360.519op/s 9192678.954op/s ± 28486.850op/s 9212585.338op/s 9241066.518op/s 9248672.591op/s 9257402.375op/s 0.70% -1.851 4.502 0.70% 4550.976op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 102.119µs 103.106µs ± 0.843µs 102.817µs ± 0.334µs 103.409µs 105.094µs 105.797µs 105.922µs 3.02% 1.523 1.748 0.82% 0.060µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 9440901.997op/s 9699429.826op/s ± 78307.795op/s 9726032.212op/s ± 31716.096op/s 9753380.744op/s 9776989.740op/s 9787464.552op/s 9792524.669op/s 0.68% -1.489 1.627 0.81% 5537.197op/s 1 200
credit_card/is_card_number/37828224631 execution_time 1.211µs 1.212µs ± 0.001µs 1.212µs ± 0.000µs 1.213µs 1.213µs 1.214µs 1.229µs 1.40% 11.297 145.471 0.11% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 813580994.843op/s 824891255.985op/s ± 865453.782op/s 824934311.971op/s ± 250365.015op/s 825233110.102op/s 825447240.891op/s 825488174.259op/s 825535552.558op/s 0.07% -11.233 144.370 0.10% 61196.824op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 98.407µs 99.185µs ± 0.606µs 99.021µs ± 0.290µs 99.389µs 100.505µs 100.965µs 102.238µs 3.25% 1.827 4.348 0.61% 0.043µs 1 200
credit_card/is_card_number/378282246310005 throughput 9781093.321op/s 10082571.353op/s ± 60885.552op/s 10098874.986op/s ± 29668.770op/s 10125003.189op/s 10146086.620op/s 10150486.959op/s 10161892.020op/s 0.62% -1.774 4.049 0.60% 4305.259op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 100.096µs 100.716µs ± 0.466µs 100.575µs ± 0.279µs 100.951µs 101.641µs 102.144µs 102.479µs 1.89% 1.211 1.443 0.46% 0.033µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 9758109.159op/s 9929146.020op/s ± 45651.439op/s 9942801.574op/s ± 27554.354op/s 9963078.586op/s 9982689.474op/s 9989090.525op/s 9990406.213op/s 0.48% -1.184 1.349 0.46% 3228.044op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 19.233µs 19.375µs ± 0.105µs 19.377µs ± 0.073µs 19.434µs 19.546µs 19.643µs 19.906µs 2.73% 1.081 2.707 0.54% 0.007µs 1 200
credit_card/is_card_number/x371413321323331 throughput 50236810.472op/s 51614628.468op/s ± 277662.050op/s 51608726.936op/s ± 194058.708op/s 51845074.654op/s 51971958.656op/s 51982912.210op/s 51994488.382op/s 0.75% -1.026 2.424 0.54% 19633.672op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 1.211µs 1.212µs ± 0.000µs 1.212µs ± 0.000µs 1.212µs 1.213µs 1.213µs 1.214µs 0.13% 0.783 0.091 0.04% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 823995960.922op/s 825045741.411op/s ± 306735.193op/s 825073390.278op/s ± 236610.103op/s 825313227.003op/s 825405856.187op/s 825458362.171op/s 825582861.500op/s 0.06% -0.781 0.087 0.04% 21689.454op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 89.212µs 91.123µs ± 0.624µs 91.216µs ± 0.363µs 91.492µs 92.012µs 92.433µs 92.558µs 1.47% -0.504 0.351 0.68% 0.044µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 10803982.269op/s 10974699.758op/s ± 75477.215op/s 10962946.951op/s ± 43570.896op/s 11011763.109op/s 11113402.006op/s 11182011.263op/s 11209255.503op/s 2.25% 0.547 0.401 0.69% 5337.045op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 83.536µs 84.842µs ± 0.510µs 84.844µs ± 0.380µs 85.223µs 85.585µs 85.808µs 86.165µs 1.56% -0.189 -0.500 0.60% 0.036µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 11605585.552op/s 11787085.744op/s ± 70897.298op/s 11786363.768op/s ± 52597.466op/s 11839406.950op/s 11906331.218op/s 11959083.036op/s 11970925.665op/s 1.57% 0.215 -0.490 0.60% 5013.196op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 1.211µs 1.213µs ± 0.002µs 1.213µs ± 0.000µs 1.213µs 1.214µs 1.214µs 1.237µs 2.01% 12.451 165.993 0.15% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 808391673.899op/s 824559965.735op/s ± 1197311.101op/s 824678334.216op/s ± 229501.339op/s 824886103.852op/s 825088185.429op/s 825371341.200op/s 825479438.458op/s 0.10% -12.394 164.959 0.14% 84662.680op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 79.921µs 81.303µs ± 0.445µs 81.320µs ± 0.261µs 81.556µs 82.076µs 82.314µs 82.391µs 1.32% 0.004 0.017 0.55% 0.031µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 12137206.420op/s 12299965.605op/s ± 67285.635op/s 12297133.338op/s ± 39518.375op/s 12343165.324op/s 12407838.149op/s 12443682.790op/s 12512401.404op/s 1.75% 0.029 0.031 0.55% 4757.813op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 100.094µs 100.542µs ± 0.379µs 100.416µs ± 0.210µs 100.749µs 101.212µs 101.780µs 101.789µs 1.37% 1.271 1.392 0.38% 0.027µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 9824278.051op/s 9946207.774op/s ± 37355.872op/s 9958524.273op/s ± 20845.763op/s 9973410.905op/s 9987471.319op/s 9990162.248op/s 9990651.747op/s 0.32% -1.251 1.321 0.37% 2641.459op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 19.234µs 19.412µs ± 0.121µs 19.405µs ± 0.079µs 19.484µs 19.633µs 19.706µs 19.970µs 2.91% 0.699 1.383 0.62% 0.009µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 50075283.083op/s 51517687.419op/s ± 318544.163op/s 51534257.398op/s ± 210573.271op/s 51744627.905op/s 51976191.314op/s 51985161.502op/s 51991081.763op/s 0.89% -0.647 1.175 0.62% 22524.474op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [1.213µs; 1.213µs] or [-0.013%; +0.013%] None None None
credit_card/is_card_number/ throughput [824483248.009op/s; 824700701.946op/s] or [-0.013%; +0.013%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [108.914µs; 109.129µs] or [-0.099%; +0.099%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [9164056.882op/s; 9181896.380op/s] or [-0.097%; +0.097%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [102.989µs; 103.222µs] or [-0.113%; +0.113%] None None None
credit_card/is_card_number/ 378282246310005 throughput [9688577.119op/s; 9710282.534op/s] or [-0.112%; +0.112%] None None None
credit_card/is_card_number/37828224631 execution_time [1.212µs; 1.212µs] or [-0.015%; +0.015%] None None None
credit_card/is_card_number/37828224631 throughput [824771312.415op/s; 825011199.556op/s] or [-0.015%; +0.015%] None None None
credit_card/is_card_number/378282246310005 execution_time [99.101µs; 99.269µs] or [-0.085%; +0.085%] None None None
credit_card/is_card_number/378282246310005 throughput [10074133.201op/s; 10091009.505op/s] or [-0.084%; +0.084%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [100.651µs; 100.780µs] or [-0.064%; +0.064%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [9922819.170op/s; 9935472.870op/s] or [-0.064%; +0.064%] None None None
credit_card/is_card_number/x371413321323331 execution_time [19.360µs; 19.389µs] or [-0.075%; +0.075%] None None None
credit_card/is_card_number/x371413321323331 throughput [51576147.178op/s; 51653109.757op/s] or [-0.075%; +0.075%] None None None
credit_card/is_card_number_no_luhn/ execution_time [1.212µs; 1.212µs] or [-0.005%; +0.005%] None None None
credit_card/is_card_number_no_luhn/ throughput [825003230.864op/s; 825088251.959op/s] or [-0.005%; +0.005%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [91.036µs; 91.209µs] or [-0.095%; +0.095%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [10964239.342op/s; 10985160.174op/s] or [-0.095%; +0.095%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [84.771µs; 84.912µs] or [-0.083%; +0.083%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [11777260.061op/s; 11796911.428op/s] or [-0.083%; +0.083%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [1.213µs; 1.213µs] or [-0.020%; +0.020%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [824394029.931op/s; 824725901.538op/s] or [-0.020%; +0.020%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [81.242µs; 81.365µs] or [-0.076%; +0.076%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [12290640.463op/s; 12309290.747op/s] or [-0.076%; +0.076%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [100.490µs; 100.595µs] or [-0.052%; +0.052%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [9941030.609op/s; 9951384.938op/s] or [-0.052%; +0.052%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [19.395µs; 19.428µs] or [-0.086%; +0.086%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [51473540.262op/s; 51561834.577op/s] or [-0.086%; +0.086%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz b7140d8 1726224597 gleocadie/fix-soname-for-artifacts-in-gitlab
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 73.508µs 73.702µs ± 0.205µs 73.630µs ± 0.069µs 73.800µs 74.011µs 74.085µs 75.620µs 2.70% 4.530 36.778 0.28% 0.014µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [73.674µs; 73.731µs] or [-0.039%; +0.039%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz b7140d8 1726224597 gleocadie/fix-soname-for-artifacts-in-gitlab
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.938µs 3.178µs ± 1.535µs 3.007µs ± 0.021µs 3.026µs 3.095µs 13.755µs 17.520µs 482.55% 7.916 63.216 48.18% 0.109µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [2.966µs; 3.391µs] or [-6.694%; +6.694%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz b7140d8 1726224597 gleocadie/fix-soname-for-artifacts-in-gitlab
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 18.310µs 23.896µs ± 12.048µs 18.793µs ± 0.206µs 19.276µs 43.650µs 51.256µs 113.027µs 501.42% 4.021 23.004 50.29% 0.852µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [22.226µs; 25.566µs] or [-6.987%; +6.987%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz b7140d8 1726224597 gleocadie/fix-soname-for-artifacts-in-gitlab
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 8.882ms 8.914ms ± 0.013ms 8.914ms ± 0.008ms 8.922ms 8.937ms 8.951ms 8.957ms 0.48% 0.377 0.505 0.15% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [8.912ms; 8.916ms] or [-0.021%; +0.021%] None None None

Baseline

Omitted due to size.

ivoanjo
ivoanjo approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🎉

@gleocadie gleocadie merged commit 38545ca into main Sep 13, 2024
30 checks passed
@gleocadie gleocadie deleted the gleocadie/fix-soname-for-artifacts-in-gitlab branch September 13, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivoanjo ivoanjo ivoanjo approved these changes

Assignees
No one assigned
Labels
ci-build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gleocadie @codecov-commenter @ivoanjo