[test] Do not set process.exitCode in tested code
#203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drarig29
commented
Nov 13, 2023
| @@ -43,7 +44,7 @@ describe('Run Github Action', () => { | |||
| }) | |||
|
|
|||
| test('Github Action core.getInput parameters are passed on to runTests', async () => { | |||
| jest.spyOn(synthetics, 'executeTests').mockImplementation(() => ({} as any)) | |||
| jest.spyOn(synthetics, 'executeTests').mockImplementation() | |||
There was a problem hiding this comment.
The () => ({} as any) is not needed for tests to pass.
Drarig29
commented
Nov 13, 2023
| } | ||
| await expect(run()).rejects.toThrowError('Config file not found') | ||
| expect(process.exitCode).toBe(1) |
There was a problem hiding this comment.
We can't assert on this property, since changing it will make Jest return that exit code, and fail the CI.
Drarig29
force-pushed
the
corentin.girard/fix-node-20-issue-unit-tests
branch
from
e1745fd
to
70f1af5
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
core.setFailed()makes the CI fail (for Node.js 20.x only) because this function setsprocess.exitCodeto1.Related issue: jestjs/jest#14501
So, mocking the implementation of
setFailedto a noop is required, since simply spying only registers the calls of that function.Here is what was happening: