[Bug]: In Node 20, Jest exits with non-zero exit code if process.exitCode is set in the tested code

[garrettjstevens]

Version

29.6.4

Steps to reproduce

git clone https://github.com/garrettjstevens/jest-20-exitcode-repro.git
cd jest-20-exitcode-repro/
yarn
yarn jest

Expected behavior

test('should exit cleanly', async () => {
  expect(async () => {
    process.exitCode = 1
    throw new Error('foo')
  }).rejects.toThrow('foo')
})

This is the code in the reproduction. I expect that the test will pass and Jest will exit with status code 0 since all the tests passed.

Actual behavior

In Node.js 18, Jest exits with code 0 and the output is:

yarn run v1.22.19
$ /home/garrett/Playground/jest-20-exitcode-repro/node_modules/.bin/jest
 PASS  ./exitCode.test.js
  ✓ should exit without errors (4 ms)

Test Suites: 1 passed, 1 total
Tests:       1 passed, 1 total
Snapshots:   0 total
Time:        0.244 s, estimated 1 s
Ran all test suites.
Done in 0.54s.

In Node.js 20, Jest exits with code 1 and the output is:

yarn run v1.22.19
$ /home/garrett/Playground/jest-20-exitcode-repro/node_modules/.bin/jest
 PASS  ./exitCode.test.js
  ✓ should exit without errors (4 ms)

Test Suites: 1 passed, 1 total
Tests:       1 passed, 1 total
Snapshots:   0 total
Time:        0.139 s, estimated 1 s
Ran all test suites.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Additional context

No response

Environment

# Usint Node.js 18
System:
  OS: Linux 5.15 Linux Mint 21.2 (Victoria)
  CPU: (8) x64 Intel(R) Core(TM) i7-9700 CPU @ 3.00GHz
Binaries:
  Node: 18.18.0 - ~/.nvm/versions/node/v18.18.0/bin/node
  Yarn: 1.22.19 - ~/.nvm/versions/node/v18.18.0/bin/yarn
  npm: 9.8.1 - ~/.nvm/versions/node/v18.18.0/bin/npm
  pnpm: 8.7.4 - ~/.nvm/versions/node/v18.18.0/bin/pnpm
npmPackages:
  jest: ^29.7.0 => 29.7.0

# Using Node.js 20
System:
  OS: Linux 5.15 Linux Mint 21.2 (Victoria)
  CPU: (8) x64 Intel(R) Core(TM) i7-9700 CPU @ 3.00GHz
Binaries:
  Node: 20.8.0 - ~/.nvm/versions/node/v20.8.0/bin/node
  Yarn: 1.22.19 - ~/.nvm/versions/node/v20.8.0/bin/yarn
  npm: 10.1.0 - ~/.nvm/versions/node/v20.8.0/bin/npm
  pnpm: 8.7.4 - ~/.nvm/versions/node/v20.8.0/bin/pnpm
npmPackages:
  jest: ^29.7.0 => 29.7.0

[github-actions]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 30 days.

[garrettjstevens]

I've tried with the latest release of Jest (v29.7.0) and Node.js 20 (v20.8.0) and the behavior has not changed.

[SimenB]

Happy to take a PR which makes sure to ignore any process.exitCode set by the user. We already intercept exit() calls.

jest/packages/jest-runner/src/runTest.ts

Lines 263 to 281 in 00ef0ed

	environment.global.process.exit = function exit(...args: Array<any>) {
	const error = new ErrorWithStack(
	`process.exit called with "${args.join(', ')}"`,
	exit,
	);
	const formattedError = formatExecError(
	error,
	projectConfig,
	{noStackTrace: false},
	undefined,
	true,
	);
	process.stderr.write(formattedError);
	return realExit(...args);
	};
	}

[github-actions]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 30 days.

[github-actions]

This issue was closed because it has been stalled for 30 days with no activity. Please open a new issue if the issue is still relevant, linking to this one.

[github-actions]

This issue was closed because it has been stalled for 30 days with no activity. Please open a new issue if the issue is still relevant, linking to this one.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.