Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug with ASM span tags reporting the number of WAF failed loaded rules #1555

Merged

Conversation

GustavoCaso
Copy link
Member

@GustavoCaso GustavoCaso commented Sep 4, 2023

Description

Motivation

Found the issue for why the test was failing for ruby.

We can merge this PR once this PR is merged

Workflow

  1. ⚠️⚠️ Create your PR as draft
  2. Follow the style guidelines of this project (See how to easily lint the code)
  3. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  4. Mark it as ready for review

Once your PR is reviewed, you can merge it! ❤️

Reviewer checklist

  • Check what scenarios are modified. If needed, add the relevant label (run-parametric-scenario, run-profiling-scenario...). If this PR modifies any system-tests internal, then add the run-all-scenarios label (more info).
  • CI is green
    • If not, failing jobs are not related to this change (and you are 100% sure about this statement)
  • if any of build-some-image label is present
    1. is the image labl have been updated ?
    2. just before merging, locally build and push the image to hub.docker.com
  • if a scenario is added (or removed), add (or remove) it in system-test-dasboard nightly

@GustavoCaso GustavoCaso marked this pull request as ready for review September 4, 2023 15:47
@GustavoCaso GustavoCaso requested review from a team as code owners September 4, 2023 15:47
@GustavoCaso GustavoCaso force-pushed the ruby-fix-issue-with-reporting-failed-loaded-waf-rules branch from a740fe1 to 99e8ba1 Compare September 4, 2023 15:48
@GustavoCaso GustavoCaso merged commit 6d3b8d2 into main Sep 5, 2023
@GustavoCaso GustavoCaso deleted the ruby-fix-issue-with-reporting-failed-loaded-waf-rules branch September 5, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants